Yeah that's fine for now. We can adjust plasmoid layouts to better accommodate the line in Plasma 5.19.

@broulik I'm leery of landing this for 5.18 since today is the last day for string changes. Maybe we can land it early in the 5.19 cycle?

Don't worry about it. :)

In D26655#594415, @hpereiradacosta wrote:

For the record, you were around for the original commit that made the scrollbar thiner (https://phabricator.kde.org/D9792)

Can confirm that it fixes the bug, and the code change looks sane to me.

Thanks!

Making monochrome breeze icons is tricky; you'll want to read https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips if you haven't already.

Potentially this inadvertedly introduces a behaviour change
of including group separators depending on locale.
Is this a a good feature?

Thanks David!

Rebase

Shallow copy instead of deep copy

Thanks!

@apol ping.

Ping.

Frameworks folks, Dolphin folks, and/or @elvisangelaccio, how is this looking? It would be really nice to be able to use the same backend code for the Places panel in Dolphin and the file dialogs again. :)

Let me know if and when this is reviewable, or if it's still WIP.

Please mark the inline comments that are resolved as "Done"

Much better, thanks. Remember to mark inline comments as "Done" once you've addressed them.

Here's an idea: instead of showing a field called "Filter" below the "Name field", we turn it into a real search field that becomes visible from a toolbar button or something. GNOME and macOS have a search feature in their Open/Save dialogs and I find it really handy, whereas the current filter functionality is not very useful IMO and is only sometimes available (sometimes it turns into a file type chooser combobox).

In D26649#593825, @broulik wrote:

So you can't tab around to end up focusing the text field?

Fix FIXME and don't show "Calculating blah..." text in subtitle when exact time isn't available

LGTM. Is @elvisangelaccio the maintainer?

I don't see the separator lines in plasma applets. Is that intentional?

Seems like that's a local issue actually.

Can you share before-and-after screenshots?

This patch fixes the bug, but it does indeed break leaving per-widget edit mode. Could we also exit that on left-click regardless of what other action it performs?

Thanks, this is a nice improvement, and thanks for fixing that bug which I caused when I originally rewrote the layout to use FormLayouts last year.

Thanks!

Phab strikes again...

Use the QQC2 ScrollView, and we should fix that elsewhere.

In D26655#594250, @hpereiradacosta wrote:

With all due respect:
This is irrelevant unless you do an actual poll.
You will have user feedback that want the thin scrollbar back. (I will).

Regarding the thickened scrollbars, I think it makes sense for a few reasons:

• Acknowledging user feedback: we've had a bunch of complaints about the thin scrollbars.
• Usability: even though the click area was the same size for the thin inactive scrollbars, it didn't look as large. This can make people subconsciously position their cursors more precisely than they need to
• If we draw a separator line but keep the thin scrollbar, then the track looks much too wide because the thin inactive scroll handle looks lost in the wide track. But we can't make the track narrower since it has to accommodate the scroll handle's thicker expanded width too. Much simpler and more visually pleasing to just make it always thicker and not change its size on hover.
• IMO the overall result just looks good. :)

Very nice! Overall it works very well. I found a few issues in QML KCMs:

Oh man, I think this just looks so good everywhere.

This is happening; see the linked patches. Here's what's happening:

• On the desktop, scrollbars return to their prior thickness and are always visible in a separated track regardless of the toolkit (QTWidgets, bare QQC2 on desktop, Kirigami on desktop
• On mobile with Kirigami or bare QQC2, scrollbars are always overlay style with no layout hacks, which means they can cover the content while in use. When not in use, they flatten out and hug the edge, remaining (barely) visible to serve as an indication of scroll position without getting in anyone's way

Yep, the freeze is on Friday. I think we can get this in before then.

Thanks for the explanation!

Presumably this was for space saving reasons; there's a big size difference between a 0 quality JPEG and 100 quality. Maybe set it to 80 as a compromise? These are only thumbnails, after all. We don't want to take up all the space on a user's disk for thumbnails!

I added a test case to https://bugreports.qt.io/browse/QTBUG-49646, BTW. Maybe that will help the Qt folks find the source of the issue.

No worries!

Yes you would need to add the margins by reducing the size of the minimum width.

This workaround breaks with multi-line strings:

Oops.

In T12433#217736, @niccolove wrote:

In T12433#217725, @ngraham wrote:

However clearly Latte's genesis was for people dissatisfied with the default appearance and functionality and wanting more control and a better look. So it makes sense that it targets tweakers and ricers. If Latte were to become the default panel solution, clearly it would be adapted to become more user-friendly for the default and productivity users.

I suppose the question is whether it makes more sense to make Latte more suitable for these people than it does to fix bugs in the default panel and add missing features to it, and accept that people who want more customizability and visual appeal can use Latte instead.

Personally, I think that it's technically easier to fix latte rather than plasma panel, especially since it's already quite user-friendly for beginners IMO. I guess you have the opposite opinion here?

In D26634#593553, @gvgeo wrote:

Then, is it an option to create GridDelegateSubtitles.qml instead?
As is now, without subtitles, I see everywhere squash shapes and bigger than necessary empty space.

now vs before

In this examples is not a big problem, but it must be used elsewhere that will have bigger visual effect.

However clearly Latte's genesis was for people dissatisfied with the default appearance and functionality and wanting more control and a better look. So it makes sense that it targets tweakers and ricers. If Latte were to become the default panel solution, clearly it would be adapted to become more user-friendly for the default and productivity users.

There's another category of user you're missing: the productivity user. This person uses their computer for work. This person may or may not be a technical expert, but they know more about their computer than the novice. Because this person's computer is a work machine, they have better things to do than tweak things. This person is sensitive to good defaults and wants to be able to turn on the machine and immediately get to work. They may customize some things, but the customizations are more likely to be functional than visual. Because of this, if they go to customize something but find a huge number of visual tweak settings, they will get frustrated.

Re-add busy indicator

For me it was instant after this patch. But I'll re-add it.

LGTM for short panels when using both an IOTM and a regular Task Manager. @broulik, you good with this now?

Ah, I see it now.

Visually +1, fixes the minor background color bug that came from the last commit.

It would make more sense to submit a new patch. This one wasn't reverted, so it's not clear what would happen if we tried to land it.

@krutovmikhail are you okay with that?

Fix comment whitespace

Work around https://bugreports.qt.io/browse/QTBUG-49646

Oh wow, I just noticed that putting these labels in a ColumnLayout triggered the infamous QML text kerning bug! https://bugreports.qt.io/browse/QTBUG-49646

Submitted a patch to fix it: D26634