Differential D26223

Explictly state which X11 components are required
ClosedPublic
Actions

Authored by davidedmundson on Dec 25 2019, 9:53 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R100:26f55f10c026: Explictly state which X11 components are required
Summary

Otherwise we can find X11 without the required xf86vmode and fail at
link time instead of configure time.

Current CI output:

[2019-12-25T21:45:30.854Z] CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
[2019-12-25T21:45:30.854Z] Please set them or make sure they are set and tested correctly in the CMake files:
[2019-12-25T21:45:30.854Z] X11_Xxf86vm_LIB (ADVANCED)
[2019-12-25T21:45:30.854Z] linked by target "kcm_kgamma" in directory /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/kcmkgamma
[2019-12-25T21:45:30.854Z]
[2019-12-25T21:45:30.854Z] -- Configuring incomplete, errors occurred!

Test Plan

Configured
Added a deliberate typo to my required X11 lines
Configure failed

Diff Detail

Repository
R100 KGamma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 25 2019, 9:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 25 2019, 9:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 25 2019, 9:53 PM
ngraham accepted this revision.Jan 14 2020, 5:52 PM
This revision is now accepted and ready to land.Jan 14 2020, 5:52 PM
Closed by commit R100:26f55f10c026: Explictly state which X11 components are required (authored by davidedmundson). · Explain WhyJan 14 2020, 5:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 73552

View Options

CMakeLists.txt

Loading...