[Applets/Task Manager] Fix and improve behavior tab layouts
AcceptedPublic

Authored by gvgeo on Tue, Jan 14, 12:41 PM.

Details

Reviewers
hein
ngraham
Group Reviewers
VDG
Plasma
Summary

Fix the group layout.
Change rest of behavior tab layout.
Rename various labels and texts.

BUG: 415649
FIXED-IN: 5.18.0

Test Plan

Before:
The indentation of option "Group only when the Task Manager is full"
is misleading.

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Branch
config (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21150
Build 21168: arc lint + arc unit
gvgeo created this revision.Tue, Jan 14, 12:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptTue, Jan 14, 12:41 PM
gvgeo requested review of this revision.Tue, Jan 14, 12:41 PM

From https://bugs.kde.org/show_bug.cgi?id=415649
Option 3 affects option 1 instead of 2.

gvgeo edited the test plan for this revision. (Show Details)Tue, Jan 14, 1:03 PM
ngraham edited the summary of this revision. (Show Details)Tue, Jan 14, 5:39 PM
ngraham accepted this revision.Tue, Jan 14, 5:45 PM

Thanks, this is a nice improvement, and thanks for fixing that bug which I caused when I originally rewrote the layout to use FormLayouts last year.

This revision is now accepted and ready to land.Tue, Jan 14, 5:45 PM
ngraham retitled this revision from [Task Manager]Fix and improve configuration behavior to [Applets/Task Manager] Fix and improve behavior tab layouts.Tue, Jan 14, 5:45 PM
gvgeo updated this revision to Diff 73569.Tue, Jan 14, 9:03 PM
gvgeo edited the test plan for this revision. (Show Details)

On more careful examination, "Group only when the Task Manager is full" option, does not affect grouping, when "combing into single button" is disabled.
Flipped back the order of the 2 options, and brought back the condition and text.

gvgeo edited the test plan for this revision. (Show Details)Tue, Jan 14, 9:05 PM
gvgeo edited the summary of this revision. (Show Details)
gvgeo edited the test plan for this revision. (Show Details)

Originally didn't include the bug report into the summary, because my request was: Add a 4th option, to affect option 2. IMHO these settings are confusing.
If you would welcome such a change (or similar), maybe need a new, clear bug report.

@ ngraham I made you go out of your way again. This time you even took responsibility for a mistake you didn't make :(
I shall be more careful. Well... I'll try.

Don't worry about it. :)