Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists
ClosedPublic

Authored by ndavis on Mon, Jan 13, 7:51 PM.

Details

Summary

If the widget has an item view parent, use the View Background color. Otherwise, use Window Background.

Test Plan

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Mon, Jan 13, 7:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Jan 13, 7:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Mon, Jan 13, 7:51 PM
ndavis edited the summary of this revision. (Show Details)Mon, Jan 13, 7:53 PM
ndavis added reviewers: hpereiradacosta, ngraham.

Otherwise, it should be Window Background. Doing it that way would preserve the original look in most cases.

This would lead to some regression (I think) for unchecked checkboxes in lists. (because of window background being used).

This doesn't seem to have any visual regressions like that.

After this patch, should I remove isSelectedItem()? It's currently unused.

ndavis edited the test plan for this revision. (Show Details)Mon, Jan 13, 8:03 PM
ngraham accepted this revision as: VDG.Mon, Jan 13, 8:04 PM

Visually +1, fixes the minor background color bug that came from the last commit.

ndavis updated this revision to Diff 73458.Mon, Jan 13, 8:05 PM

Fix formatting

hpereiradacosta accepted this revision.Mon, Jan 13, 9:04 PM

Otherwise, it should be Window Background. Doing it that way would preserve the original look in most cases.

This would lead to some regression (I think) for unchecked checkboxes in lists. (because of window background being used).

This doesn't seem to have any visual regressions like that.

That works yes (since you test for parent item view).
Also yes, feel free to remove the now unused isItemSelected.
Thanks for the patch !

This revision is now accepted and ready to land.Mon, Jan 13, 9:04 PM
This revision was automatically updated to reflect the committed changes.