[applets/weather] Port weather station picker to QQC2+ListView
Needs ReviewPublic

Authored by ngraham on Mon, Jan 13, 9:12 PM.

Details

Reviewers
broulik
Group Reviewers
VDG
Plasma
Summary

This fixes the bug I introduced when I fixed 414442 in the wrong way, makes the UI more
recular, removes a QQC1 dep, and makes the view fully keyboard-navigeable.

BUG: 414442
FIXED-IN: 5.18.0

Test Plan

Diff Detail

Repository
R114 Plasma Addons
Branch
port-to-listview-in-scrollview (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21283
Build 21301: arc lint + arc unit
ngraham created this revision.Mon, Jan 13, 9:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Jan 13, 9:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mon, Jan 13, 9:12 PM
fvogt added a subscriber: fvogt.Mon, Jan 13, 9:20 PM

When I tested this, there was a very noticable delay (~10s) between starting the search and items appearing, so the busy indicator is IMO necessary.

For me it was instant after this patch. But I'll re-add it.

ngraham updated this revision to Diff 73464.Mon, Jan 13, 9:24 PM

Re-add busy indicator

broulik added inline comments.Fri, Jan 17, 3:36 PM
applets/weather/package/contents/ui/config/WeatherStationPicker.qml
41–42

Given the item is hidden anyway, you can probably assign this as a binding right away

132

Does focus: true on the TextField instead of the ListView make this redundant?

141

This is unlike any other list we have in settings?

166

You're constantly breaking this binding by assigning to it elsewhere programmatically.

ngraham updated this revision to Diff 73780.Fri, Jan 17, 3:56 PM
ngraham marked 3 inline comments as done.

Address review comments

ngraham added inline comments.Fri, Jan 17, 3:56 PM
applets/weather/package/contents/ui/config/WeatherStationPicker.qml
141

I copied it from the notifications KCM :)