| elvisangelaccio | |
| broulik |
| Frameworks | |
| VDG | |
| Dolphin |
This includes:
The delegates are also made somewhat more compact to match Dolphin and spacing inbetween sections increased.
Try with branch broulik/kfileplacesview in Dolphin.
Dolphin (from left to right: current custom view, KFilePlacesView current look, KFilePlacesView more compact new look to match Dolphin)
| Lint Skipped |
| Unit Tests Skipped |
Fantastic. UI-wise, I agree that adopting Dolphin's more narrow paddings between list elements makes the file dialog feel a bit crowded. This is also a (very) minor complaint I have about Dolphin. I wonder if it wouldn't make sense to keep the existing paddings between list items, or reduce them only a tiny bit.
One thing I notice has been lost is the ability to choose the size of the icons. Dolphin currently exposes this in the context menu for places panel headers. The File dialog does something different and automatically resizes the icons according to how much vertical space is available in the dialog. However with this patch and your Dolphin branch, neither one is available and the icon sizes appear to be immutable.
It would be nice to unify the behavior between Dolphin and the file dialog with this patchset. We get bugs about them being different.
| src/filewidgets/kfileplacesview.h | ||
|---|---|---|
| 157 | For KF6 ? | |
Frameworks folks, Dolphin folks, and/or @elvisangelaccio, how is this looking? It would be really nice to be able to use the same backend code for the Places panel in Dolphin and the file dialogs again. :)
Haven't tried the dolphin branch yet, just a comment on the API for now.
From a quick look the patch looks good though.
| src/filewidgets/kfileplacesview.h | ||
|---|---|---|
| 68 | This seems to be the name of a method that makes all items visible, not the name of a bool getter. I know we already have setShowAll(), but we can deprecate it and find a better name. How about setAllPlacesVisible() / allPlacesVisible() / allPlacesVisibleChanged() ? | |
Hopefully this can proceed soon, this seems like a pretty nice step towards better maintainability and consistency to me. Looks like all major work is already done and only some minor things need discussion or changes. @broulik do you have time to look at it again in the near future?
