Same behavior for scrollbar as the desktop style
ClosedPublic

Authored by mart on Tue, Jan 14, 2:33 PM.

Details

Summary

bigger scrollbar and add a small line separator
to look consistent with D26655 and D26654

same behavior for mobile scrollbar

Test Plan

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Tue, Jan 14, 2:33 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Jan 14, 2:33 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Tue, Jan 14, 2:33 PM
mart retitled this revision from same behavior for scrollbar as the desktop style to Same behavior for scrollbar as the desktop style.Tue, Jan 14, 2:34 PM
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: ngraham.
mart updated this revision to Diff 73543.Tue, Jan 14, 4:01 PM
  • smoother transition
mart updated this revision to Diff 73545.Tue, Jan 14, 4:08 PM
  • add missing property

I don't see the separator lines in plasma applets. Is that intentional?

mart added a comment.Wed, Jan 15, 11:09 AM

I don't see the separator lines in plasma applets. Is that intentional?

most of them are still qqc1, i can look into adding them there as well

mart added a comment.EditedWed, Jan 15, 11:31 AM

actually, doesn't look that good.

this is because the scrollview has some margins and no frame, so now the scrollbar appears not centered.
those plasmoids would need to not have any margin with their content, or preferably, having the scrollviews enlarging to touch exactly the applet borders

best case scenario, we should have a look along the lines (gimped):

mart added a comment.EditedWed, Jan 15, 1:40 PM

I would put for now an exception for plasmoids to not have such line, then in a second moment we think about a proper and more complicated solution to update plasmoids design to have something along the lines of the latter mockup

mart updated this revision to Diff 73621.Wed, Jan 15, 2:44 PM
  • only show when *not* a plasmoid
ngraham accepted this revision.Wed, Jan 15, 3:38 PM

Yeah that's fine for now. We can adjust plasmoid layouts to better accommodate the line in Plasma 5.19.

This revision is now accepted and ready to land.Wed, Jan 15, 3:38 PM
davidedmundson added inline comments.
src/declarativeimports/plasmacomponents3/ScrollBar.qml
91

Math.round?

95

Math.round

src/desktoptheme/breeze/widgets/scrollbar.svg
149

We seem to have lost a lot of pixel alignment.

Probably won't make any difference unless you render at 20000x the size, but might be worth asking Noah/someone how they do it.

mart updated this revision to Diff 73631.Wed, Jan 15, 3:58 PM
  • round things
mart marked 3 inline comments as done.Wed, Jan 15, 3:58 PM
This revision was automatically updated to reflect the committed changes.