[Wallpaper] Show author as subtitle in configuration
AcceptedPublic

Authored by broulik on Wed, Jan 8, 8:12 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Summary

If we have this feature now, let's use it and give the wallpaper authors the credit they deserve rather than being tucked away in the tooltip.

Test Plan


Or should we keep the "By" prefix?

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Wed, Jan 8, 8:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Jan 8, 8:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Wed, Jan 8, 8:12 PM
broulik edited the test plan for this revision. (Show Details)

Might make sense to keep the "By" prefix, yeah. +1!

filipf added a subscriber: filipf.Wed, Jan 8, 10:41 PM

Good idea +1. I think an author's name is enough here since information is displayed in a similar way that songs info is ie. it should be obvious to everyone the second line lists the author.

"By" can also be tricky to translate into other languages. In my language you can't just literally translate it because it would mean the wallpaper is made of the author's flesh. So instead of that the translator would have to add "Author: " everywhere or just omit it.

All right, let's do this way then. However I see a problem with the delegate cell size:

However I see a problem with the delegate cell size:

That's unrelated and something I would have expected was tested when this feature was added.

"By" can also be tricky to translate into other languages

That's why we have context. Currently it also has "<image> by <author>" explanation.

mart added a subscriber: mart.Fri, Jan 10, 11:58 AM

However I see a problem with the delegate cell size:

That's unrelated and something I would have expected was tested when this feature was added.

can you look into that?

broulik added a comment.EditedMon, Jan 13, 7:55 AM

can you look into that?

Perhaps @ngraham can. In any case, if this were fixed, it would not make it for 5.18.

mart added a comment.Mon, Jan 13, 1:05 PM

can you look into that?

Perhaps @ngraham can. In any case, if this were fixed, it would not make it for 5.18.

no biggie. let's put it in as soon as the new cycle starts

I'll look into it, yeah.

Submitted a patch to fix it: D26634

ngraham accepted this revision.Fri, Jan 17, 3:16 PM
This revision is now accepted and ready to land.Fri, Jan 17, 3:16 PM