Rework system tray settings
Needs ReviewPublic

Authored by nicolasfella on Sun, Jun 30, 6:04 PM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Summary

The current system tray settings has two pages with two slightly different lists. The first page shows a list of all available plasmoids and allows to en/disable them.
The second list shows the in the previous page enabled plasmoids plus the available statusnotifieritems and offers configuration (visibility and shortcuts for plasmoids).

This patch combines both into a single list. Therefor it:

  • Has a new model that holds both plasmoids and SNIs
  • Replaces the QQC1 Tableview with a ListView + Rowlayout
  • Adds an entry 'Disabled' to the visibility combobox to disable plasmoids (functionality from the former first list)
  • Removes the old 'General' page

This removes the ability to (de-)select entire categories, but I don't consider this a particularly useful feature. The categories are intransparent to the user and the individual elements can still be en/disabled

Currently it has a slight visual bug. The scrollbar overlaps the shortcut clear buttons. Help to resolve this is welcome

BUG: 360307
BUG: 397950

Test Plan

Open system tray. Change the visibility of a plasmoid. Apply. Verify visibility in system tray. Add a shortcut to plasmoid. Verify shortcut

Diff Detail

Repository
R120 Plasma Workspace
Branch
systray
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13439
Build 13457: arc lint + arc unit
nicolasfella created this revision.Sun, Jun 30, 6:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Jun 30, 6:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sun, Jun 30, 6:04 PM
nicolasfella edited the summary of this revision. (Show Details)Sun, Jun 30, 6:04 PM

Nice!!!

Let's give the scrollview that holds this list a visible frame, like we did in the Purpose job dialog. Also maybe rename the "General" tab to say "Entries" since that's all there is there.

Nice, looks good and is a lot cleaner.

I'm mostly only echoing @broulik here, but I think we should still have some sort of help with figuring out which entry belongs to which row of buttons.

This (mockup) is something that would work, but is pretty hacky and is undocumented style:

Nice, looks good and is a lot cleaner.

I'm mostly only echoing @broulik here, but I think we should still have some sort of help with figuring out which entry belongs to which row of buttons.

This (mockup) is something that would work, but is pretty hacky and is undocumented style:

The generally accepted way to do this is to use alternating background colors. The old table view got this automatically, however this patch ports away from it since it's QQC1 only. Unfortunately, there is no QQC2 TableView.

Honestly I would support staying with the QQC1 TableView for now. Trying to move to QQC2 without a replacement for it just means we're rolling our own table view, which seems even hackier.