[kcms/feedback] Implement setRepresentsDefaults
ClosedPublic

Authored by davidedmundson on Wed, Jan 15, 1:26 AM.

Details

Test Plan

Moved slider
Defaults button enabled/disabled appropriately

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Wed, Jan 15, 1:26 AM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Jan 15, 1:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Wed, Jan 15, 1:26 AM
ngraham accepted this revision.Wed, Jan 15, 2:55 AM
This revision is now accepted and ready to land.Wed, Jan 15, 2:55 AM
meven added a subscriber: meven.Wed, Jan 15, 8:31 AM
meven added inline comments.
kcms/feedback/feedback.cpp
43

nitpick, You could move this to Feedback::setPlasmaFeedbackLevel as well.
1 saves a connect,
2 make setRepresesentsDefault and setNeedsSave close in the file

This revision was automatically updated to reflect the committed changes.
kcms/feedback/feedback.cpp
43

sorry I missed your comment.

I'll make this change.