krutovmikhail (Mikhail Krutov)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 10 2018, 10:16 AM (18 w, 6 d)
Availability
Available

Recent Activity

Thu, Mar 28

krutovmikhail added a comment to D20026: Go up in folder hierachy when in "edit mode".
Thu, Mar 28, 5:41 PM · Frameworks
krutovmikhail added a comment to D20026: Go up in folder hierachy when in "edit mode".

Whoops. I have a mix-up between two machines on which code is on, this compiles on one I've developed it on (no _urls/urls change), but not on one I've pushed from. I'll update this in several hours.

Thu, Mar 28, 9:14 AM · Frameworks

Tue, Mar 26

krutovmikhail updated the diff for D20026: Go up in folder hierachy when in "edit mode".
  • Update per phabricator comments: styling, boolean to enum, windows fix
Tue, Mar 26, 9:42 PM · Frameworks
krutovmikhail added a comment to D20052: Make tabs rename-able.

Updated.

Tue, Mar 26, 9:40 PM · Dolphin
krutovmikhail updated the diff for D20052: Make tabs rename-able.
  • FEATURE: 197009 Implement tab renaming in dolphin
Tue, Mar 26, 9:39 PM · Dolphin
krutovmikhail added a comment to D20026: Go up in folder hierachy when in "edit mode".

Yes, I was mostly pointing out that it seems to be out of scope of this revision to fix that problem :-)

Tue, Mar 26, 9:17 PM · Frameworks
krutovmikhail updated the diff for D20026: Go up in folder hierachy when in "edit mode".
  • Update per phabricator comments: styling, boolean to enum, windows fix
Tue, Mar 26, 9:13 PM · Frameworks
krutovmikhail added a comment to D20026: Go up in folder hierachy when in "edit mode".

ngraham, in Dolphin, this commit is to blame for loosing editMode on changing URL: https://github.com/KDE/dolphin/commit/2af331b42c0514f4fdf848d0cc22f02717f7bec0

Tue, Mar 26, 8:57 PM · Frameworks
krutovmikhail added a comment to D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.

Thanks for your comments! Revision updated.

Tue, Mar 26, 8:52 PM · Dolphin
krutovmikhail updated the diff for D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.
  • Update per phabricator comments: Windows crash, intialization & logic
Tue, Mar 26, 8:52 PM · Dolphin
krutovmikhail added a comment to D20052: Make tabs rename-able.

I've updated the diff, fixing both the issue with tab movement and styling.

Tue, Mar 26, 8:47 PM · Dolphin
krutovmikhail updated the diff for D20052: Make tabs rename-able.
  • index -> uuid for tab identification
Tue, Mar 26, 8:45 PM · Dolphin
krutovmikhail updated the diff for D20052: Make tabs rename-able.
  • index -> uuid for tab identification
Tue, Mar 26, 8:44 PM · Dolphin
krutovmikhail updated the diff for D20052: Make tabs rename-able.
  • index -> uuid for tab identification
Tue, Mar 26, 8:40 PM · Dolphin
krutovmikhail added a comment to D20052: Make tabs rename-able.

Thanks for the review.

Tue, Mar 26, 3:41 PM · Dolphin
krutovmikhail added a comment to D20026: Go up in folder hierachy when in "edit mode".

Thanks, I'll apply styling changes & will take a look at GWenView. Out of KDE Applications, what other consumers use KUrlNavigator? Is there an easy way to find out?

Tue, Mar 26, 3:28 PM · Frameworks

Mon, Mar 25

krutovmikhail added a reviewer for D20052: Make tabs rename-able: Dolphin.
Mon, Mar 25, 10:44 PM · Dolphin
krutovmikhail requested review of D20052: Make tabs rename-able.
Mon, Mar 25, 10:39 PM · Dolphin
krutovmikhail added a comment to D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.

Thanks for noticing! I've updated the patch to fix the crash.

Mon, Mar 25, 9:24 PM · Dolphin
krutovmikhail updated the diff for D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.

Fixed crash

Mon, Mar 25, 9:23 PM · Dolphin
krutovmikhail updated the diff for D20026: Go up in folder hierachy when in "edit mode".

Upated - Working variant with proper widgets - amending due to lost changes

Mon, Mar 25, 9:10 PM · Frameworks
krutovmikhail updated the diff for D20026: Go up in folder hierachy when in "edit mode".

Updated - Working variant with proper widgets

Mon, Mar 25, 9:01 PM · Frameworks
krutovmikhail updated the summary of D20026: Go up in folder hierachy when in "edit mode".
Mon, Mar 25, 8:59 PM · Frameworks
krutovmikhail added a comment to D20026: Go up in folder hierachy when in "edit mode".

After bit digging, found out a proper-er solution to both questions.

Mon, Mar 25, 8:58 PM · Frameworks
krutovmikhail updated the diff for D20026: Go up in folder hierachy when in "edit mode".

Updated - Working variant with proper widgets

Mon, Mar 25, 8:57 PM · Frameworks
krutovmikhail added a reviewer for D20049: Fix unexpected behaviour when calling dolphin with a file as an argument: Dolphin.
Mon, Mar 25, 6:13 PM · Dolphin
krutovmikhail requested review of D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.
Mon, Mar 25, 6:12 PM · Dolphin
krutovmikhail added a comment to D20026: Go up in folder hierachy when in "edit mode".

I've updated the diff with a couple questions I have (about UI mostly). Still WIP.

Mon, Mar 25, 10:45 AM · Frameworks
krutovmikhail updated the diff for D20026: Go up in folder hierachy when in "edit mode".
  • initial take at dropdown list
Mon, Mar 25, 10:41 AM · Frameworks

Sun, Mar 24

krutovmikhail abandoned D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode".
Sun, Mar 24, 7:45 PM · Frameworks
krutovmikhail added a comment to D20026: Go up in folder hierachy when in "edit mode".

This was created as a new revision due to --amend prior to arc diff. Not sure on how to update diff on previous one properly, previous is abandoned now.

Sun, Mar 24, 7:45 PM · Frameworks
krutovmikhail added reviewers for D20026: Go up in folder hierachy when in "edit mode": ngraham, Dolphin.
Sun, Mar 24, 7:44 PM · Frameworks
krutovmikhail requested review of D20026: Go up in folder hierachy when in "edit mode".
Sun, Mar 24, 7:43 PM · Frameworks
krutovmikhail updated the summary of D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode".
Sun, Mar 24, 7:42 PM · Frameworks
krutovmikhail added reviewers for D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode": Dolphin, ngraham.
Sun, Mar 24, 7:40 PM · Frameworks
krutovmikhail requested review of D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode".
Sun, Mar 24, 7:39 PM · Frameworks
krutovmikhail added a comment to D19988: Fix lengthy URLs in tooltips.

Nathaniel, I've tried to reach to you on IRC to clarify this question, but there was no answer :)

Sun, Mar 24, 6:06 PM · Baloo
krutovmikhail abandoned D20004: Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit.

Alright, I'll re-open this vs KUrlNavigator soon. Thanks!

Sun, Mar 24, 6:02 PM · Dolphin
krutovmikhail added a comment to D19988: Fix lengthy URLs in tooltips.

Also please write a descriptive commit message and use the BUG: keyword. See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

Sun, Mar 24, 12:50 PM · Baloo
krutovmikhail updated the diff for D19988: Fix lengthy URLs in tooltips.
  • BUG: 389963 Limiting length of URLs in tooltips
Sun, Mar 24, 12:37 PM · Baloo
krutovmikhail added a comment to D19988: Fix lengthy URLs in tooltips.

Thanks for input, done

Sun, Mar 24, 11:53 AM · Baloo
krutovmikhail abandoned D19987: Bug 405620 - Move 'Safely Remove' down in Places popup menu.
Sun, Mar 24, 11:52 AM · Dolphin
krutovmikhail updated the diff for D19988: Fix lengthy URLs in tooltips.
  • Update per comments on phabricator
Sun, Mar 24, 11:49 AM · Baloo

Sat, Mar 23

krutovmikhail added a reviewer for D19988: Fix lengthy URLs in tooltips: Dolphin.
Sat, Mar 23, 11:25 PM · Baloo
krutovmikhail added a reviewer for D20004: Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit: Dolphin.
Sat, Mar 23, 11:25 PM · Dolphin
krutovmikhail requested review of D20004: Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit.
Sat, Mar 23, 6:45 PM · Dolphin
krutovmikhail added a comment to D19988: Fix lengthy URLs in tooltips.

broulik, this makes sense. Updated, thank you for your input :)

Sat, Mar 23, 12:40 PM · Baloo
krutovmikhail updated the diff for D19988: Fix lengthy URLs in tooltips.
  • Use KStringHandler per suggestion in phabricator
Sat, Mar 23, 12:39 PM · Baloo
krutovmikhail added a comment to D19987: Bug 405620 - Move 'Safely Remove' down in Places popup menu.

Oh. Alright. How do I close this MR?

Sat, Mar 23, 12:25 PM · Dolphin

Mar 23 2019

krutovmikhail added a comment to D19988: Fix lengthy URLs in tooltips.

To reproduce the issue (https://bugs.kde.org/show_bug.cgi?id=389963):

Mar 23 2019, 12:43 AM · Baloo
krutovmikhail requested review of D19988: Fix lengthy URLs in tooltips.
Mar 23 2019, 12:40 AM · Baloo

Mar 22 2019

krutovmikhail requested review of D19987: Bug 405620 - Move 'Safely Remove' down in Places popup menu.
Mar 22 2019, 11:38 PM · Dolphin

Mar 15 2019

krutovmikhail updated the diff for D19769: Bug 404162 File/Save acts always acts like "Save as...".
  • Update per phabricator comments: message wording & indention
Mar 15 2019, 10:13 PM · KDE Edu

Mar 14 2019

krutovmikhail updated the diff for D19769: Bug 404162 File/Save acts always acts like "Save as...".

Updating D19769: Bug 404162 File/Save acts always acts like "Save as..."

Mar 14 2019, 7:55 PM · KDE Edu
krutovmikhail updated the diff for D19769: Bug 404162 File/Save acts always acts like "Save as...".

Updating D19769: Bug 404162 File/Save acts always acts like "Save as..."

Mar 14 2019, 7:53 PM · KDE Edu
krutovmikhail requested review of D19769: Bug 404162 File/Save acts always acts like "Save as...".
Mar 14 2019, 7:44 PM · KDE Edu

Dec 10 2018

krutovmikhail added a member for Bugsquad: krutovmikhail.
Dec 10 2018, 10:16 AM