Yup

Thanks for the headsup!

So, I'm really sorry for *very* long absence in this context. Updated diff.. Which works. I'll go over style and things tomorrow.

• fix build
• Fixes for behaviour

Sorry for long time no update. I'll be getting back to this soon.

Whoops. I have a mix-up between two machines on which code is on, this compiles on one I've developed it on (no _urls/urls change), but not on one I've pushed from. I'll update this in several hours.

• Update per phabricator comments: styling, boolean to enum, windows fix

Updated.

• FEATURE: 197009 Implement tab renaming in dolphin

Yes, I was mostly pointing out that it seems to be out of scope of this revision to fix that problem :-)

• Update per phabricator comments: styling, boolean to enum, windows fix

ngraham, in Dolphin, this commit is to blame for loosing editMode on changing URL: https://github.com/KDE/dolphin/commit/2af331b42c0514f4fdf848d0cc22f02717f7bec0

Thanks for your comments! Revision updated.

• Update per phabricator comments: Windows crash, intialization & logic

I've updated the diff, fixing both the issue with tab movement and styling.

• index -> uuid for tab identification

• index -> uuid for tab identification

• index -> uuid for tab identification

Thanks for the review.

Thanks, I'll apply styling changes & will take a look at GWenView. Out of KDE Applications, what other consumers use KUrlNavigator? Is there an easy way to find out?

Thanks for noticing! I've updated the patch to fix the crash.

Fixed crash

Upated - Working variant with proper widgets - amending due to lost changes

Updated - Working variant with proper widgets

After bit digging, found out a proper-er solution to both questions.

Updated - Working variant with proper widgets

I've updated the diff with a couple questions I have (about UI mostly). Still WIP.

• initial take at dropdown list

This was created as a new revision due to --amend prior to arc diff. Not sure on how to update diff on previous one properly, previous is abandoned now.

Nathaniel, I've tried to reach to you on IRC to clarify this question, but there was no answer :)

Alright, I'll re-open this vs KUrlNavigator soon. Thanks!

In D19988#437169, @elvisangelaccio wrote:

Also please write a descriptive commit message and use the BUG: keyword. See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

• BUG: 389963 Limiting length of URLs in tooltips

Thanks for input, done

• Update per comments on phabricator

broulik, this makes sense. Updated, thank you for your input :)

• Use KStringHandler per suggestion in phabricator

Oh. Alright. How do I close this MR?

To reproduce the issue (https://bugs.kde.org/show_bug.cgi?id=389963):

• Update per phabricator comments: message wording & indention

Updating D19769: Bug 404162 File/Save acts always acts like "Save as..."

Updating D19769: Bug 404162 File/Save acts always acts like "Save as..."