- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Nov 29 2017
Okay, I gave it another unsuccesful go. Will have to test together if you have some time.
Address issues pointed out
Won't it be loaded nevertheless with the QPT?
Then fix the warnings that appear? Or doesn't it show any issues?
Nov 28 2017
Okay, maybe it's not important...
Lack of context in the patch makes it hard to review.
Looks cool!
In D9021#172842, @mart wrote:could the ide always take info from a set theme, like the base "default" one somehow?
Note this breaks integration in the IDE.
Nov 27 2017
+1
correct the bottom margin
Nov 26 2017
Nov 25 2017
I don't really see the value here. Can't the application developer also do the QTimer gimmick?
Nov 24 2017
Nov 23 2017
+1
LGTM, the only weird thing you had to touch was already doing weird things...
Nov 22 2017
+1 for these reviews it's usually better to send a picture to see what it looks like.
This should go to ECM.
@adridg the icons you can find them in breeze: dialog-error, dialog-warning, dialog-question and dialog-information
Here's a video of what it looks like after the patch, in Discover
+1
That would explain why I didn't get it
This creates a "slight" problem for Wayland as ksmserver is forced to XCB. What do you think about doing it like with kscreenlocker? On X11 ksmserver, on Wayland KWin? Otherwise +1000 to this suggestion.
Nov 21 2017
At the moment we have builds of the runtime, as it's being built in flathub. Not for applications so far.
+1 for having it all in once place.
Remove cast
Better API
Nov 20 2017
Okay, let's get this in, maybe we will get to fix the main issue down the line and restore the optimization at some point.
PA_INVALID_INDEX
Nov 19 2017
Yes, sorry: QOverload<>::of.