Feed Advanced Search

Nov 29 2017

apol committed R857:c0defaa9aa24: Make it possible to pass cmake arguments to generic builds (authored by apol).
Make it possible to pass cmake arguments to generic builds
Nov 29 2017, 2:44 PM
apol added a comment to D8173: Use readelf to find project dependencies.

Okay, I gave it another unsuccesful go. Will have to test together if you have some time.

Nov 29 2017, 2:29 PM · Build System, Frameworks
apol committed R883:1505474: Remove links to sponsors.
Remove links to sponsors
Nov 29 2017, 1:43 PM
apol updated the diff for D8859: Adapt the cmake buildsystem to be able to work with KDE CI.

Address issues pointed out

Nov 29 2017, 1:34 PM · KDE Edu
apol added inline comments to D9049: Compile with stricter compilation flags.
Nov 29 2017, 1:33 PM · Frameworks
apol committed R857:9a3865e4fcb6: Add ignore rules for frameworks that were recently added (authored by apol).
Add ignore rules for frameworks that were recently added
Nov 29 2017, 1:29 PM
apol committed R857:89cbbf1f9f19: Simplify logic (authored by apol).
Simplify logic
Nov 29 2017, 1:29 PM
apol accepted D9031: Delay kdeconnectd autostart phase.
Nov 29 2017, 11:43 AM
apol accepted D9047: kglobalacceld: Avoid loading an icon loader for no reason.

Won't it be loaded nevertheless with the QPT?

Nov 29 2017, 11:23 AM · Frameworks
apol added a comment to D9042: Add -Werror=switch and -Wcovered-switch-default.

Then fix the warnings that appear? Or doesn't it show any issues?

Nov 29 2017, 12:25 AM

Nov 28 2017

apol committed R134:4a3e14ffbe5c: PackageKit: Remove special case remnants of Eula in favor of proceedFunctions (authored by apol).
PackageKit: Remove special case remnants of Eula in favor of proceedFunctions
Nov 28 2017, 6:57 PM
apol committed R134:c17feb9f77b5: PackageKit: Make it possible to add new signatures in response to the error (authored by apol).
PackageKit: Make it possible to add new signatures in response to the error
Nov 28 2017, 6:57 PM
apol committed R134:12906bbfbcc4: PackageKit: de-couple proceeding from EULA so it can be used by anything else (authored by apol).
PackageKit: de-couple proceeding from EULA so it can be used by anything else
Nov 28 2017, 6:57 PM
apol committed R134:8f7fa400b91e: Move TransactionSet into a separate file (authored by apol).
Move TransactionSet into a separate file
Nov 28 2017, 6:57 PM
apol accepted D9021: determine QQC2 version at build time.

Okay, maybe it's not important...

Nov 28 2017, 5:36 PM · Plasma
apol added a comment to D9033: man ioslave: asserts trying to display pam(8).

Lack of context in the patch makes it hard to review.

Nov 28 2017, 5:23 PM · Frameworks, Dolphin, Documentation, Plasma
apol added a comment to D9037: use desktop file actions instead of global shortcuts.

Looks cool!

Nov 28 2017, 5:09 PM · Plasma
apol committed R134:74b1746182a2: PK: Use the stream to store the information rather than the transaction (authored by apol).
PK: Use the stream to store the information rather than the transaction
Nov 28 2017, 12:54 PM
apol added a comment to D9021: determine QQC2 version at build time.
In D9021#172842, @mart wrote:

could the ide always take info from a set theme, like the base "default" one somehow?

Nov 28 2017, 11:28 AM · Plasma
apol added inline comments to D9028: [UDisks DeviceBackend] Slightly optimize.
Nov 28 2017, 11:26 AM · Frameworks
apol added a comment to D9021: determine QQC2 version at build time.

Note this breaks integration in the IDE.

Nov 28 2017, 12:06 AM · Plasma

Nov 27 2017

apol added a comment to D9018: Don't cause circular linking on Windows.

+1

Nov 27 2017, 11:58 PM · Frameworks
apol committed R169:6d5e1dc22070: Offset the scrollbar by the header size (authored by apol).
Offset the scrollbar by the header size
Nov 27 2017, 12:50 PM
apol closed D8939: Offset the scrollbar by the header size.
Nov 27 2017, 12:50 PM · Kirigami
apol updated the diff for D8939: Offset the scrollbar by the header size.

correct the bottom margin

Nov 27 2017, 12:33 PM · Kirigami
apol committed R134:47c19354886e: Flatpak: Make sure we don't degrade resources' state (authored by apol).
Flatpak: Make sure we don't degrade resources' state
Nov 27 2017, 11:54 AM
apol committed R134:0c558176124c: If it's busy, try again in a second (authored by apol).
If it's busy, try again in a second
Nov 27 2017, 11:46 AM
apol committed R134:0cd350842af3: Group updater refreshes (authored by apol).
Group updater refreshes
Nov 27 2017, 11:46 AM
apol committed R134:2d304b655cbf: StandardUpdater: Only refresh when it's going to make a difference (authored by apol).
StandardUpdater: Only refresh when it's going to make a difference
Nov 27 2017, 11:46 AM
apol committed R134:0eeb9866510a: Narrow down the scope of a variable (authored by apol).
Narrow down the scope of a variable
Nov 27 2017, 11:46 AM
apol committed R32:2aec8448c949: Make sure the flatpak filename rx is what we expected it to be (authored by apol).
Make sure the flatpak filename rx is what we expected it to be
Nov 27 2017, 10:00 AM
apol committed R244:70b09f9b08fb: Warn about errors when parsing json files (authored by apol).
Warn about errors when parsing json files
Nov 27 2017, 8:02 AM
apol closed D8992: Warn about errors when parsing json files.
Nov 27 2017, 8:02 AM · Frameworks

Nov 26 2017

apol committed R134:d91eb6d359a1: Make it possible for updaters to show notifications at any time (authored by apol).
Make it possible for updaters to show notifications at any time
Nov 26 2017, 12:42 AM
apol committed R134:a0a7aea36e84: Remove unused code (authored by apol).
Remove unused code
Nov 26 2017, 12:42 AM

Nov 25 2017

apol added a comment to D8999: KJob: add start(int delay) method.

I don't really see the value here. Can't the application developer also do the QTimer gimmick?

Nov 25 2017, 8:47 PM · Frameworks
apol committed R134:df1f776d7574: Remove hidden styling from the delegate's comment (authored by apol).
Remove hidden styling from the delegate's comment
Nov 25 2017, 8:44 PM
apol committed R120:1edc633c0137: Properly use QCLP to get the theme name (authored by apol).
Properly use QCLP to get the theme name
Nov 25 2017, 3:01 PM
apol closed D8993: Properly use QCLP to get the theme name.
Nov 25 2017, 3:00 PM · Plasma
apol created D8993: Properly use QCLP to get the theme name.
Nov 25 2017, 1:29 AM · Plasma
apol created D8992: Warn about errors when parsing json files.
Nov 25 2017, 1:21 AM · Frameworks
apol committed R113:6b9a5c720727: Remove unused cmake file (authored by apol).
Remove unused cmake file
Nov 25 2017, 1:06 AM
apol committed R120:b2cb400f5042: Remove unused cmake file (authored by apol).
Remove unused cmake file
Nov 25 2017, 12:37 AM

Nov 24 2017

apol committed R282:f9079223401e: Remove redundant map look-ups (authored by apol).
Remove redundant map look-ups
Nov 24 2017, 8:48 PM
apol closed D8976: Remove redundant map look-ups.
Nov 24 2017, 8:47 PM · Frameworks

Nov 23 2017

apol added a comment to D8971: Port from QDom to QXmlStreamReader.

+1

Nov 23 2017, 6:54 PM · Frameworks
apol created D8976: Remove redundant map look-ups.
Nov 23 2017, 6:53 PM · Frameworks
apol committed R116:634ee75c7ee9: Fix NetworkModel::rowCount when the parent is one of the list items (authored by apol).
Fix NetworkModel::rowCount when the parent is one of the list items
Nov 23 2017, 3:41 PM
apol accepted D8962: Drop unfinished support for binary & before/after diffs from VcsDiff.
Nov 23 2017, 11:51 AM
apol accepted D8959: Make more signals non-const.

LGTM, the only weird thing you had to touch was already doing weird things...

Nov 23 2017, 1:02 AM

Nov 22 2017

apol requested changes to D8957: Add title, artist and album to MPRIS network packets.
Nov 22 2017, 11:43 PM
apol added a comment to D8955: Use material icons in MPRIS activity.

+1 for these reviews it's usually better to send a picture to see what it looks like.

Nov 22 2017, 11:39 PM
apol accepted D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData.
Nov 22 2017, 4:09 PM · Frameworks
apol added a comment to D8951: CMakeLists.txt: Append KF5 macros to CMAKE_AUTOMOC_MACRO_NAMES.

This should go to ECM.

Nov 22 2017, 3:15 PM
apol added a comment to M116: Calamares Telemetry Page Design suggestion.

@adridg the icons you can find them in breeze: dialog-error, dialog-warning, dialog-question and dialog-information

Nov 22 2017, 2:25 PM · Plasma
apol accepted D8825: do not show edit bookmarks action if keditbookmarks is not installed.
Nov 22 2017, 12:32 PM · Frameworks
apol added reviewers for D8939: Offset the scrollbar by the header size: ngraham, abetts.
Nov 22 2017, 11:43 AM · Kirigami
apol added a comment to D8939: Offset the scrollbar by the header size.

Here's a video of what it looks like after the patch, in Discover

.

Nov 22 2017, 11:42 AM · Kirigami
apol created D8939: Offset the scrollbar by the header size.
Nov 22 2017, 11:41 AM · Kirigami
apol committed R883:1505070: update freewear merchandise.
update freewear merchandise
Nov 22 2017, 10:27 AM
apol committed R256:86ae035bd977: Make sure org.freedesktop.* is built (authored by apol).
Make sure org.freedesktop.* is built
Nov 22 2017, 8:34 AM
apol added a comment to D8929: Fix progress widget on bottom bar not being shown in some sessions.

+1
That would explain why I didn't get it

Nov 22 2017, 8:26 AM
apol committed R892:0f347704d1b2: Use the last timestamp we have for objects without destruction (authored by apol).
Use the last timestamp we have for objects without destruction
Nov 22 2017, 8:26 AM
apol committed R892:cbcf01d8594e: Polish (authored by apol).
Polish
Nov 22 2017, 8:26 AM
apol committed R892:2089ebd649a9: Always use the same code to turn QVariant values into strings (authored by apol).
Always use the same code to turn QVariant values into strings
Nov 22 2017, 8:26 AM
apol committed R892:f01604cfbea3: Delaying initialization sometimes leads to crash (authored by apol).
Delaying initialization sometimes leads to crash
Nov 22 2017, 8:26 AM
apol committed R892:f661a8e23a18: Fix crash (authored by apol).
Fix crash
Nov 22 2017, 8:26 AM
apol added a comment to D8924: Move the KDE Polkit-Agent into ksmserver.

This creates a "slight" problem for Wayland as ksmserver is forced to XCB. What do you think about doing it like with kscreenlocker? On X11 ksmserver, on Wayland KWin? Otherwise +1000 to this suggestion.

Nov 22 2017, 8:20 AM · Plasma
apol accepted D8739: Include fcitx's platform input context in runtime..
Nov 22 2017, 8:01 AM

Nov 21 2017

apol committed R134:997c1a0bdd6b: No need to explicitly notify (authored by apol).
No need to explicitly notify
Nov 21 2017, 2:47 PM
apol added a comment to T6768: Get builds for other architectures.

At the moment we have builds of the runtime, as it's being built in flathub. Not for applications so far.

Nov 21 2017, 1:48 PM · Flatpak
apol committed R282:9eb778022c36: Don't do unnecessary QString allocations to convert parts of it into strings (authored by apol).
Don't do unnecessary QString allocations to convert parts of it into strings
Nov 21 2017, 1:25 PM
apol closed D8925: Don't do unnecessary QString allocations to convert parts of it into strings.
Nov 21 2017, 1:25 PM · Frameworks
apol added a comment to D8924: Move the KDE Polkit-Agent into ksmserver.

+1 for having it all in once place.

Nov 21 2017, 12:27 PM · Plasma
apol created D8925: Don't do unnecessary QString allocations to convert parts of it into strings.
Nov 21 2017, 12:14 PM · Frameworks
apol updated the diff for D8923: Offer QWindow API for KJobWidgets:: decorators.

Remove cast

Nov 21 2017, 11:20 AM · Frameworks
apol added inline comments to D8923: Offer QWindow API for KJobWidgets:: decorators.
Nov 21 2017, 11:19 AM · Frameworks
apol updated the diff for D8923: Offer QWindow API for KJobWidgets:: decorators.

Better API

Nov 21 2017, 10:58 AM · Frameworks
apol created D8923: Offer QWindow API for KJobWidgets:: decorators.
Nov 21 2017, 10:16 AM · Frameworks
apol committed R120:78525595e174: Remove unused include (authored by apol).
Remove unused include
Nov 21 2017, 10:15 AM

Nov 20 2017

apol accepted D8852: Fix crash deep inside VcsOverlayProxyModel::data().

Okay, let's get this in, maybe we will get to fix the main issue down the line and restore the optimization at some point.

Nov 20 2017, 6:20 PM
apol accepted D8732: Fix race that starts kactivitymanagerd multiple times.
Nov 20 2017, 5:03 PM · Frameworks
apol accepted D8733: DBus activate KActivityManagerd.
Nov 20 2017, 5:03 PM · Plasma
apol created D8917: Reduce the amount of spurious property changes on ColorScope.
Nov 20 2017, 3:43 PM · Frameworks, Plasma
apol committed R242:28d9c7146ed5: Remove double lookup (authored by apol).
Remove double lookup
Nov 20 2017, 3:16 PM
apol committed R242:3e17a2d0a207: Remove duplicate boilerplate code (authored by apol).
Remove duplicate boilerplate code
Nov 20 2017, 3:15 PM
apol closed D8914: Remove duplicate boilerplate code.
Nov 20 2017, 3:15 PM · Frameworks, Plasma
apol created D8914: Remove duplicate boilerplate code.
Nov 20 2017, 2:35 PM · Frameworks, Plasma
apol committed R115:e39f4e0e2b49: Fix uninitialized warning on valgrind (authored by apol).
Fix uninitialized warning on valgrind
Nov 20 2017, 12:16 PM
apol closed D8909: Fix uninitialized warning on valgrind.
Nov 20 2017, 12:16 PM · Plasma
apol committed R237:f1e5d65ec128: Don't look for /etc/kderc every single time (authored by apol).
Don't look for /etc/kderc every single time
Nov 20 2017, 12:12 PM
apol closed D8871: Don't look for /etc/kderc every single time.
Nov 20 2017, 12:12 PM · Frameworks
apol committed R242:aa4aa72d6322: Synchronize the component with the one in Kirigami (authored by apol).
Synchronize the component with the one in Kirigami
Nov 20 2017, 12:10 PM
apol closed D8870: Synchronize the component with the one in Kirigami.
Nov 20 2017, 12:09 PM · Frameworks, Plasma
apol updated the diff for D8909: Fix uninitialized warning on valgrind.

PA_INVALID_INDEX

Nov 20 2017, 12:08 PM · Plasma
apol committed R323:c8413cf12ab3: Remove unneeded type conversion (authored by apol).
Remove unneeded type conversion
Nov 20 2017, 12:06 PM
apol created D8909: Fix uninitialized warning on valgrind.
Nov 20 2017, 2:46 AM · Plasma

Nov 19 2017

apol added a comment to D7968: Forward QComboBox signals instead of QComboBox lineedit signals.

Yes, sorry: QOverload<>::of.

Nov 19 2017, 11:16 PM · Frameworks
apol requested changes to D7968: Forward QComboBox signals instead of QComboBox lineedit signals.
Nov 19 2017, 10:59 PM · Frameworks
apol accepted D7967: KComboBox: Return early when setting editable to previous value.
Nov 19 2017, 10:58 PM · Frameworks