Differential D8870

Synchronize the component with the one in Kirigami
ClosedPublic
Actions

Authored by apol on Nov 17 2017, 3:49 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:aa4aa72d6322: Synchronize the component with the one in Kirigami
Summary

Using the height property together with paintedHeight had binding loops.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Nov 17 2017, 3:49 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptNov 17 2017, 3:49 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Nov 17 2017, 3:51 PM

Are you sure this results in the same "bottom gap" below the item? Perhaps bottomPadding (new in Qt 5.6) could help here?

apol added a comment.Nov 17 2017, 4:02 PM

Yes, this works, the code in question was in SystemTray, it looks just fine there.
Also I've been using Heading in Discover for months and never saw this issue.

apol updated this revision to Diff 22544.Nov 17 2017, 9:08 PM

Search all frameworks together as components

apol updated this revision to Diff 22545.Nov 17 2017, 9:09 PM

unrelated things

mart accepted this revision.Nov 20 2017, 9:52 AM
This revision is now accepted and ready to land.Nov 20 2017, 9:52 AM
Closed by commit R242:aa4aa72d6322: Synchronize the component with the one in Kirigami (authored by apol). · Explain WhyNov 20 2017, 12:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22641

View Options

src/declarativeimports/plasmaextracomponents/qml/Heading.qml

Loading...