Differential D8871

Don't look for /etc/kderc every single time
ClosedPublic
Actions

Authored by apol on Nov 17 2017, 4:50 PM.

Details

Reviewers
mpyne
dfaure
Group Reviewers
Frameworks
Commits
R237:f1e5d65ec128: Don't look for /etc/kderc every single time
Summary

Every time we open a configuration file, we are checking if this file is there.
Since it's a sysadmin setting I'd say it's fine to assume that it's not appearing
and disappearing.
Also we are not supporting the case of the file changing during runtime or so.

Diff Detail

Repository
R237 KConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Nov 17 2017, 4:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 17 2017, 4:50 PM
mpyne accepted this revision.Nov 18 2017, 12:48 AM
mpyne added a subscriber: mpyne.

+1

This revision is now accepted and ready to land.Nov 18 2017, 12:48 AM
dfaure accepted this revision.Nov 20 2017, 8:42 AM
dfaure added a subscriber: dfaure.

Patch looks good. Commit log looks wrong, it's not /etc/kderc but /etc/kde5rc.

Closed by commit R237:f1e5d65ec128: Don't look for /etc/kderc every single time (authored by apol). · Explain WhyNov 20 2017, 12:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/kconfig.cpp (1 line)

Diff 22642

View Options

src/core/kconfig.cpp

Loading...