Details
Details
- Reviewers
dfaure - Commits
- R263:7005889ba644: Compile with stricter compilation flags
Diff Detail
Diff Detail
- Repository
- R263 KXmlGui
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| autotests/kactioncollectiontest.cpp | ||
|---|---|---|
| 235 | Yeah, standard action names are definitely latin1. Actions defined by applications, however, can use utf8 (sometimes to transport a QString into the name, used in the slot connected to the action) | |
| autotests/kxmlgui_unittest.cpp | ||
| 298 | I wouldn't bet my life on the fact that MSVC will like the ternary operator with a QStringLiteral and a QString which aren't the same type at all. fromLatin1 would be safer, especially since this is definitely not time-critical ;) | |
| src/ksendbugmail/smtp.cpp | ||
| 227 | This is used to call processLine, so see implementation of processLine below... | |
| 327 | Given the toLatin1 here, I think fromLatin1 is safe, but this also tells me that all of this should just be ported to QByteArray. | |
Comment Actions
The commit log needs to have a one-line summary, like "Compile with stricter compilation flags".