Feed Advanced Search

Yesterday

apol committed R256:02b1774907f6: Include an ARGS variable (authored by apol).
Include an ARGS variable
Sat, May 26, 1:47 PM

Fri, May 25

apol added a comment to D13124: [RFC] Add Share action to Dolphin context menu.

I have the feeling that it should be a KAbstractFileItemActionPlugin? It's how we implemented it for KDE Connect at least and it should be more generic.

Fri, May 25, 11:13 PM · Frameworks, Dolphin
apol added a comment to D13123: Make .deb and .rpm mime type handling optional at build time.

Good idea!
How about looking for the rpm and dpkg executables?

Fri, May 25, 11:11 PM · Plasma
apol accepted D13119: Abort transaction on PK dependency resolution error.

Looks better, thanks!

Fri, May 25, 11:09 PM · Plasma
apol requested changes to D13119: Abort transaction on PK dependency resolution error.
Fri, May 25, 6:52 PM · Plasma
apol added a comment to D13119: Abort transaction on PK dependency resolution error.

Looks like it's missing checking the exit argument in ::cleanup() for ExitFailed no? Can you check if in this case we're getting the an ExitFailed? If so the setStatus should go there.

Fri, May 25, 6:52 PM · Plasma
apol accepted D13120: fix i18n issues in framworks/purpose/plugins.

Thanks!

Fri, May 25, 6:32 PM · Frameworks
apol committed R256:90f6fddb6b39: im.kaidan needs building too now (authored by apol).
im.kaidan needs building too now
Fri, May 25, 5:15 PM
apol added a comment to T8425: Simplify announcement submission.
In T8425#137515, @aacid wrote:

Looking at @jriddell script and without being a ruby reader i see it seems to create the announcement page, the changelog page and the info page.

Fri, May 25, 4:21 PM · Websites: WKO Migration
apol committed R993:29fa08062bcf: Android: we now have more than *-debug.apk builds (authored by apol).
Android: we now have more than *-debug.apk builds
Fri, May 25, 3:47 PM
apol committed R224:f4e4df17e9ba: Don't re-add a conversation when a message from it into the model (authored by apol).
Don't re-add a conversation when a message from it into the model
Fri, May 25, 2:34 PM
apol committed R224:ca7f27f468b2: --warning (authored by apol).
--warning
Fri, May 25, 2:34 PM
apol committed R224:6d60aac3c974: Sort conversations by date (authored by apol).
Sort conversations by date
Fri, May 25, 2:34 PM
apol committed R224:ae51b56174b3: No need to create a PersonData per delegate (authored by apol).
No need to create a PersonData per delegate
Fri, May 25, 2:34 PM
apol updated the diff for D13043: Properly sanitize input.

address kai's remarks

Fri, May 25, 12:10 PM · Frameworks
apol added inline comments to D13043: Properly sanitize input.
Fri, May 25, 12:09 PM · Frameworks
apol added a comment to D13102: Don't include a 64 when building 64bit architectures on flatpak.

Please update the doc above.

Fri, May 25, 11:27 AM · Build System, Frameworks
apol accepted D13006: Move the inline installer progress cancel button to the left side.
Fri, May 25, 9:34 AM · Plasma
apol committed R134:41ca473bc806: Use a GridLayout to compose the ApplicationDelegate (authored by apol).
Use a GridLayout to compose the ApplicationDelegate
Fri, May 25, 1:38 AM
apol updated subscribers of D13102: Don't include a 64 when building 64bit architectures on flatpak.
Fri, May 25, 1:10 AM · Build System, Frameworks
apol requested review of D13102: Don't include a 64 when building 64bit architectures on flatpak.
Fri, May 25, 1:09 AM · Build System, Frameworks

Thu, May 24

apol accepted D13092: make sure paths in rcc are never derived from absolute paths.
Thu, May 24, 4:28 PM · Frameworks
apol committed R857:0d78f5b23dfc: Also process the project's negated deps (authored by apol).
Also process the project's negated deps
Thu, May 24, 3:46 PM
apol committed R857:8bfd62a7ea31: Android: also build release apks (authored by apol).
Android: also build release apks
Thu, May 24, 3:46 PM
apol committed R857:f7f8351770b7: Android: Remove parts of poppler that aren't necessary (authored by apol).
Android: Remove parts of poppler that aren't necessary
Thu, May 24, 3:46 PM
apol committed R857:0f4040238d07: Android: have all builds started with build-generic as persistant (authored by apol).
Android: have all builds started with build-generic as persistant
Thu, May 24, 3:46 PM
apol committed R256:52f3540cb373: Use latest stable llvm (authored by apol).
Use latest stable llvm
Thu, May 24, 3:14 PM
apol committed R256:1f24ca52fbb7: Dependencies come from flathub, generate deltas (authored by apol).
Dependencies come from flathub, generate deltas
Thu, May 24, 3:14 PM
apol committed R256:dfad99100a63: Fix kexi build (authored by apol).
Fix kexi build
Thu, May 24, 12:37 PM
apol added a comment to D13092: make sure paths in rcc are never derived from absolute paths.

Don't we have to make sure path is relative to the package root?

Thu, May 24, 11:26 AM · Frameworks

Wed, May 23

apol accepted D12896: Add Telegram plugin.

Okay, let's land this and I'll try to fix it myself.

Wed, May 23, 8:08 PM · Frameworks
apol committed R134:256233dec7c2: Adapt test to changes in the backend (authored by apol).
Adapt test to changes in the backend
Wed, May 23, 4:37 PM
apol committed R134:fa1066b1aa35: Adapt tests to the new behaviors (authored by apol).
Adapt tests to the new behaviors
Wed, May 23, 4:32 PM
apol committed R134:9b6ab165ca6d: Port all uses of QQC1 to QQC2 (authored by apol).
Port all uses of QQC1 to QQC2
Wed, May 23, 4:32 PM
apol committed R134:9a192aea9ea9: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by apol).
Merge branch 'Plasma/5.12' into Plasma/5.13
Wed, May 23, 4:32 PM
apol committed R134:13a8722112dd: Remove unused file (authored by apol).
Remove unused file
Wed, May 23, 4:32 PM
apol committed R134:f9075bdbe54e: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by apol).
Merge branch 'Plasma/5.12' into Plasma/5.13
Wed, May 23, 4:32 PM
apol committed R134:f09e3ed1934f: Fix UpdateAndInstall test (authored by apol).
Fix UpdateAndInstall test
Wed, May 23, 4:13 PM
apol committed R134:88257be7ee9b: Fix dummy test (authored by apol).
Fix dummy test
Wed, May 23, 4:13 PM
apol committed R134:358a03b88778: Properly check if we should be checking for a resource's reviews (authored by apol).
Properly check if we should be checking for a resource's reviews
Wed, May 23, 4:01 PM
apol added a comment to D12896: Add Telegram plugin.
In D12896#266713, @apol wrote:

Then just read the Exec field and we'll add the sendpath by hand. This is ad-hoc for telegram anyway.

I'm not quite sure what to do. Best I came up with is something like

execStr = parseExec()

if (execStr.contains("flatpak"))
    execStr += "-sendpath @@ url @@"
else
    execStr += "-sendpath url"

Is this what you had in mind?

Wed, May 23, 3:36 PM · Frameworks
apol committed R134:37e166aed196: Remove unnecessary complexity in InstallApplicationButton (authored by apol).
Remove unnecessary complexity in InstallApplicationButton
Wed, May 23, 3:11 PM
apol committed R134:c62613f1175c: Adapt if the application object is destroyed (authored by apol).
Adapt if the application object is destroyed
Wed, May 23, 3:09 PM
apol committed R224:b114364c69e9: Make the ConversationDisplay actually show things (authored by apol).
Make the ConversationDisplay actually show things
Wed, May 23, 2:37 PM
apol committed R224:784f5d37bd42: Pass the phone number to the conversation display (authored by apol).
Pass the phone number to the conversation display
Wed, May 23, 2:37 PM
apol committed R224:4842a89ec2d4: Cleanup (authored by apol).
Cleanup
Wed, May 23, 2:37 PM
apol committed R858:681b8fba260d: It turns out the flickable in a scrollview is the contentItem (authored by apol).
It turns out the flickable in a scrollview is the contentItem
Wed, May 23, 12:09 PM
apol closed D13049: It turns out the flickable in a scrollview is the contentItem.
Wed, May 23, 12:09 PM · Plasma
apol updated the diff for D13049: It turns out the flickable in a scrollview is the contentItem.

Include a test for item views

Wed, May 23, 11:39 AM · Plasma
apol committed R256:bcb7ac8c628e: Adopt Qt 5.11 wherever we were using 5.10 (authored by apol).
Adopt Qt 5.11 wherever we were using 5.10
Wed, May 23, 10:33 AM
apol committed R134:eda974690d38: Improve ALPM log display (authored by apol).
Improve ALPM log display
Wed, May 23, 1:43 AM
apol committed R134:44a7538e2635: Skip the beginning of the ALPM log (authored by apol).
Skip the beginning of the ALPM log
Wed, May 23, 1:43 AM
apol requested review of D13049: It turns out the flickable in a scrollview is the contentItem.
Wed, May 23, 12:41 AM · Plasma

Tue, May 22

apol committed R257:b21141d81b28: Stable Qt is 5.11 now (authored by apol).
Stable Qt is 5.11 now
Tue, May 22, 11:56 PM
apol added inline comments to D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName().
Tue, May 22, 11:51 PM · Frameworks
apol added a comment to D12883: Adopt a more reasonable approach for passing the file to purpose.

ping

Tue, May 22, 11:40 PM
apol committed R224:8c9dd4c2d791: Introduce a "living room" use-case (authored by apol).
Introduce a "living room" use-case
Tue, May 22, 11:34 PM
apol committed R224:d5f92b5824ca: remove unused code (authored by apol).
remove unused code
Tue, May 22, 11:34 PM
apol committed R224:1f3a51f24295: Rough implementation for a casting feature (authored by apol).
Rough implementation for a casting feature
Tue, May 22, 11:34 PM
apol added a comment to D12896: Add Telegram plugin.

I've played around with flatpaked Telegram and made it working. However:
My Telegram.desktop file executes this:
/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=telegram-desktop --file-forwarding org.telegram.desktop -- @@u %u @@
I can share a file using
/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=telegram-desktop --file-forwarding org.telegram.desktop -sendpath @@ /home/nico/test.py @@
But that would require changing the command I get from the desktop file. I can achieve the same goal just by appending something to the command from the desktop file:
/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=telegram-desktop --file-forwarding org.telegram.desktop -- @@u %u @@ -sendpath @@ /home/nico/test.py @@
However, appending this to the command does not work with the regular command.
I don't see any way to support all without some special-case handling for flatpak. I didn't even test snap.
Any ideas?

Tue, May 22, 10:12 PM · Frameworks
apol added a comment to M127: Card layout and card content layout for Kirigami and Discover.

Hey,
Interesting work. Some thoughts:

  • having a vertical alignment between the icon and the stars breaks the fact that we only had 1 thing at the left on the vertical views. This adds clutter.
  • we won't be able to vertically align the stars and the icon on the left, it may look crowded
  • it would be interesting to see whether this matches the Cards concept Marco had in mind.
  • for now I'd have all items in the same view have the same size and layout, otherwise it will scroll weirdly.
  • the progress bar on the last screenshot doesn't look like Breeze scroll bars. Please don't make high definition mockups with the wrong components because everyone gets sad afterwards.
  • breeze stars are blue.
Tue, May 22, 4:50 PM · Discover Software Store, Kirigami
apol added a comment to D12678: Fix multimonitor blur.

What's the status of this?

Tue, May 22, 4:42 PM · KWin
apol requested review of D13043: Properly sanitize input.
Tue, May 22, 4:40 PM · Frameworks
apol committed R134:fcc6105d6e9c: Merge branch 'Plasma/5.13' (authored by apol).
Merge branch 'Plasma/5.13'
Tue, May 22, 1:32 PM
apol committed R134:342db07b0a0f: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by apol).
Merge branch 'Plasma/5.12' into Plasma/5.13
Tue, May 22, 1:32 PM
apol committed R134:0c4e121d78df: Guard against calling a null object (authored by apol).
Guard against calling a null object
Tue, May 22, 1:28 PM
apol committed R134:fd4f6382136f: Report when progress changes unconditionally (authored by apol).
Report when progress changes unconditionally
Tue, May 22, 1:27 PM

Mon, May 21

apol added a comment to D12896: Add Telegram plugin.

Can this even work with Telegram installed as sandboxed Flatpak?

Mon, May 21, 11:13 PM · Frameworks

Fri, May 18

apol committed R134:984040115528: Forward the download speed from PackageKit into transactions (authored by apol).
Forward the download speed from PackageKit into transactions
Fri, May 18, 4:46 PM
apol committed R134:82f69cffc8ff: Resolve all packages that have been modified by the transaction (authored by apol).
Resolve all packages that have been modified by the transaction
Fri, May 18, 2:27 PM
apol committed R223:add2c598089c: Kirigami: Don't show two drawer items (authored by apol).
Kirigami: Don't show two drawer items
Fri, May 18, 12:43 PM

Thu, May 17

apol committed R223:885e1f226975: Android: Make it possible to open documents from Android (authored by apol).
Android: Make it possible to open documents from Android
Thu, May 17, 11:45 PM
apol committed R223:356229a74fa7: Kirigami/Android: Try to get all android-specific code together (authored by apol).
Kirigami/Android: Try to get all android-specific code together
Thu, May 17, 11:45 PM
apol committed R223:9ca00505a5d2: Kirigami: Remove unused slot (authored by apol).
Kirigami: Remove unused slot
Thu, May 17, 11:45 PM
apol added a comment to T6136: Preparation: Set up the Android environment .

I guess this can be closed now, correct?

Thu, May 17, 11:05 PM · Android, Marble: Material Maps
apol created T8741: Document build-generic.
Thu, May 17, 10:57 PM · Android
apol claimed T8740: Have binary-factory spit signed builds.
Thu, May 17, 10:56 PM · Android
apol created T8740: Have binary-factory spit signed builds.
Thu, May 17, 10:56 PM · Android
apol closed T3575: Add libintl-lite to ki18n build dependencies in kdesrc.rc file as Resolved.
Thu, May 17, 10:55 PM · Android
apol added a comment to T2927: Compiling for F-Droid.

Had a discussion with F-Droid today. Now the plan is to create our own F-Droid repository with the Android binaries coming from binary-factory.kde.org.

Thu, May 17, 10:55 PM · Android
apol closed T2925: Document projects with dependencies as Resolved.
Thu, May 17, 10:54 PM · Android
apol closed T1774: Prepare Docker Image for Executing Unit Tests as Resolved.
Thu, May 17, 10:53 PM · Android
apol closed T2917: Add Android platform to CI System as Resolved.
Thu, May 17, 10:53 PM · Android
apol committed R134:787598775886: Use a monospace font (authored by apol).
Use a monospace font
Thu, May 17, 6:34 PM
apol committed R134:1f9338f37ec4: Only show ALPM scriptlet lines (authored by apol).
Only show ALPM scriptlet lines
Thu, May 17, 6:34 PM
apol committed R223:600e72100b13: Remove the internal file navigation from the global drawer (authored by apol).
Remove the internal file navigation from the global drawer
Thu, May 17, 2:57 PM
apol closed D12884: Remove the internal file navigation from the global drawer.
Thu, May 17, 2:57 PM · Okular
apol accepted D12943: Don't disable apply button when I resize the window.
Thu, May 17, 2:23 PM · Plasma
apol committed R256:34825d75d492: master should be kf5 now (authored by apol).
master should be kf5 now
Thu, May 17, 12:33 PM

Wed, May 16

apol updated the diff for D12884: Remove the internal file navigation from the global drawer.

Remove hardcoded path

Wed, May 16, 11:04 PM · Okular
apol committed R134:60e471ffde34: Only show ALPM scriptlet lines (authored by apol).
Only show ALPM scriptlet lines
Wed, May 16, 9:17 PM
apol committed R134:5178f31a1aba: Include pacman's log on arch (authored by apol).
Include pacman's log on arch
Wed, May 16, 5:43 PM
apol updated the task description for T8624: contributor trainings.
Wed, May 16, 3:33 PM · KDE e.V.
apol added inline comments to D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side).
Wed, May 16, 3:28 PM · KDE Connect
apol added a comment to D12905: KF5I18NMacros: Don't install an empty dir when no po files exist.

LGTM

Wed, May 16, 3:06 PM · Frameworks
apol updated the diff for D12884: Remove the internal file navigation from the global drawer.

Don't add logic in core/ just in case

Wed, May 16, 3:03 PM · Okular
apol added inline comments to D12884: Remove the internal file navigation from the global drawer.
Wed, May 16, 2:59 PM · Okular
apol committed R858:d3f21aee2f8f: Add test file for ScrollView { TextArea {} } (authored by apol).
Add test file for ScrollView { TextArea {} }
Wed, May 16, 1:15 PM
apol added a comment to T8718: Issue with updates permanently shows as 3 updates available.

Could be this bug: https://bugs.kde.org/show_bug.cgi?id=394043

Wed, May 16, 11:22 AM · KDE Neon : bionic
apol committed R858:c6ce523e6994: Fix warning (authored by apol).
Fix warning
Wed, May 16, 11:15 AM