Differential D8671

KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData
ClosedPublic
Actions

Authored by dfaure on Nov 5 2017, 9:55 PM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R301:fb467669f8a3: KEmoticons: port plugins to JSON and add support for loading with…
Summary

This makes it possible to run the autotests without installing kemoticons.

Test Plan

ctest; also playing a bit with kcmshell5 emoticons, but not full coverage there.

Diff Detail

Repository
R301 KEmoticons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Nov 5 2017, 9:55 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 5 2017, 9:55 PM
apol added a subscriber: apol.Nov 6 2017, 1:00 AM

Other than that +1

src/providers/adium/CMakeLists.txt
19

Why do we need to keep them?

Whoever uses this it will be with the new version of the library as well.

dfaure added a comment.Nov 6 2017, 6:04 AM

The KCM uses KServiceTypeTrader so we still need the desktop files.

dfaure added a reviewer: apol.Nov 22 2017, 3:25 PM
apol accepted this revision.Nov 22 2017, 4:09 PM
This revision is now accepted and ready to land.Nov 22 2017, 4:09 PM
Closed by commit R301:fb467669f8a3: KEmoticons: port plugins to JSON and add support for loading with… (authored by dfaure). · Explain WhyNov 22 2017, 4:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22751

View Options

src/core/kemoticons.cpp

Loading...
View Options

src/providers/adium/CMakeLists.txt

Loading...
View Options

src/providers/adium/adium_emoticons.cpp

Loading...
View Options

src/providers/adium/emoticonstheme_adium.json

Loading...
View Options

src/providers/kde/CMakeLists.txt

Loading...
View Options

src/providers/kde/emoticonstheme_kde.json

Loading...
View Options

src/providers/kde/kde_emoticons.cpp

Loading...
View Options

src/providers/pidgin/CMakeLists.txt

Loading...
View Options

src/providers/pidgin/emoticonstheme_pidgin.json

Loading...
View Options

src/providers/pidgin/pidgin_emoticons.cpp

Loading...
View Options

src/providers/xmpp/CMakeLists.txt

Loading...
View Options

src/providers/xmpp/emoticonstheme_xmpp.json

Loading...
View Options

src/providers/xmpp/xmpp_emoticons.cpp

Loading...