src/kjobwidgets.cpp
67	`WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef QT_PREPEND_NAMESPACE(quintptr) WId;` Besides: `QVariant::fromValue(window->winId())` should work just fine, or?

apol marked an inline comment as done.Nov 21 2017, 11:19 AM

apol added inline comments.

src/kjobwidgets.cpp
67	Note I didn't change any code, I just moved it around. Removing the cast still seems to work, so I'll do that.

Remove cast

src/kjobwidgets.cpp
67	Note I didn't change any code, I just moved it around. Whoops, sorry. Didn't notice.

dfaure added a subscriber: dfaure.

dfaure added inline comments.

src/kjobwidgets.h
76	Unlikely at this point (tagging today).

This revision is now accepted and ready to land.Dec 2 2017, 4:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/kjobwidgets.h (28 lines)
M			src/kjobwidgets.cpp (31 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	22684	f87fbcb		Nov 21 2017, 10:16 AM	★	★
Diff 2	22685	f87fbcb	Better API	Nov 21 2017, 10:58 AM	★	★
Diff 3	22686	f87fbcb	Remove cast	Nov 21 2017, 11:20 AM	★	★
Diff 4	23820	2ccc82c	R288:02053c0ff28fe3c987d5d9411f6868e191899bd0	Dec 12 2017, 5:13 PM	★	★

Offer QWindow API for KJobWidgets:: decoratorsClosedPublicActions