KComboBox: Return early when setting editable to previous value
ClosedPublic

Authored by mwolff on Sep 24 2017, 11:55 AM.

Details

Summary

Instead of creating a new line edit, keep the previous one intact.
This ensures we don't set a new line edit for code such as the
following:

KComboBox combo(/* rw = */ true);
combo.setEditable(true);

Diff Detail

Repository
R284 KCompletion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Sep 24 2017, 11:55 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 24 2017, 11:55 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
apol accepted this revision.Nov 19 2017, 10:58 PM
This revision is now accepted and ready to land.Nov 19 2017, 10:58 PM
This revision was automatically updated to reflect the committed changes.