The Qt Xml module is not actively maintained anymore and docs suggest to use QXmlStreamReader. Also removes the dependency on Qt Xml
Details
Details
- Reviewers
dfaure - Group Reviewers
Frameworks - Commits
- R292:f3342f4ccaba: Port from QDom to QXmlStreamReader
I can still convert currencies just fine. When the XML file is corrupt, it tries to read it again. It does not try to re-download it, though, but that has been an issue before too (it only checks exists && mtime)
ValueTest fails
FAIL! : ValueTest::testCurrencyNotDownloaded() '!eur.isValid()' returned FALSE. ()
but this is also without this patch and might be an issue when running it locally (it fails even worse if run with locale != en)
Diff Detail
Diff Detail
- Repository
- R292 KUnitConversion
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/currency.cpp | ||
|---|---|---|
| 713 | To compare double to int is never good idea, it can be even worst when compared it to double :) if (multiplier > std::numeric_limits<double>::epsilon()) | |