Differential D9047

kglobalacceld: Avoid loading an icon loader for no reason
ClosedPublic
Actions

Authored by davidedmundson on Nov 29 2017, 11:07 AM.

Details

Reviewers
apol
Commits
R268:d965b98304d0: kglobalacceld: Avoid loading an icon loader for no reason
Summary

We know this is a QGuiApplication app, so we know it doesn't have any
widgets we also know it doesn't use QtQuick anywhere.

Therefore it won't have any windows and setting a default window icon is
pointless.
This has a surprisingly big overhead as it instantiates the KDE icon theme
engine. Saves near 5% of startup time.

Test Plan

Compiles

Diff Detail

Repository
R268 KGlobalAccel
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 29 2017, 11:07 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
davidedmundson requested review of this revision.Nov 29 2017, 11:07 AM
apol accepted this revision.Nov 29 2017, 11:23 AM
apol added a subscriber: apol.

Won't it be loaded nevertheless with the QPT?

This revision is now accepted and ready to land.Nov 29 2017, 11:23 AM
davidedmundson added a comment.Nov 29 2017, 11:29 AM

Won't it be loaded nevertheless with the QPT?

Hotspot says it doesn't.

Closed by commit R268:d965b98304d0: kglobalacceld: Avoid loading an icon loader for no reason (authored by davidedmundson). · Explain WhyNov 29 2017, 11:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/runtime/main.cpp (1 line)

Diff 23125

View Options

src/runtime/main.cpp

Loading...