Differential D8993

Properly use QCLP to get the theme name
ClosedPublic
Actions

Authored by apol on Nov 25 2017, 1:28 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:1edc633c0137: Properly use QCLP to get the theme name
Summary

Instead of guessing it will be the first argument, which leads to very
weird behavior.

Test Plan

Checked the kcm still works
Played around with it

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Nov 25 2017, 1:28 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 25 2017, 1:28 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Nov 25 2017, 1:28 AM
davidedmundson accepted this revision.Nov 25 2017, 3:22 AM
davidedmundson added a subscriber: davidedmundson.

Much neater

This revision is now accepted and ready to land.Nov 25 2017, 3:22 AM
Closed by commit R120:1edc633c0137: Properly use QCLP to get the theme name (authored by apol). · Explain WhyNov 25 2017, 3:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22921

View Options

ksplash/ksplashqml/splashapp.h

Loading...
View Options

ksplash/ksplashqml/splashapp.cpp

Loading...
View Options

ksplash/ksplashqml/splashwindow.h

Loading...
View Options

ksplash/ksplashqml/splashwindow.cpp

Loading...