determine QQC2 version at build time
ClosedPublic

Authored by mart on Nov 27 2017, 3:33 PM.

Details

Summary

the qqc2 theme style needs to import the same qqc2 version
than the latest one available in the installed Qt, otherwise
users of QQC2 will only be able to use features available in
Qt 5.7, even if they have a more recent Qt installed.
this will also be needed to conditionally support the icon
property introduced in Qt 5.10

BUG:386289

Test Plan

kirigami gallery works with the style installed in this way
it will need a better way to figure out what the available
qqc2 version is

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Nov 27 2017, 3:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 27 2017, 3:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Nov 27 2017, 3:33 PM
mart updated this revision to Diff 23035.Nov 27 2017, 3:42 PM
  • remove useless output
rizzitello accepted this revision.Nov 27 2017, 3:49 PM
rizzitello added a subscriber: rizzitello.

This removes the runtime problem referanced in the bug above.

This revision is now accepted and ready to land.Nov 27 2017, 3:49 PM
davidedmundson accepted this revision.Nov 27 2017, 4:18 PM
mart updated this revision to Diff 23036.Nov 27 2017, 4:20 PM
  • support editable for comboboxes
apol added a subscriber: apol.Nov 28 2017, 12:06 AM

Note this breaks integration in the IDE.

Is it maybe something to discuss with upstream?

mart added a comment.Nov 28 2017, 9:49 AM
In D9021#172748, @apol wrote:

Note this breaks integration in the IDE.

Is it maybe something to discuss with upstream?

could the ide always take info from a set theme, like the base "default" one somehow?

apol added a comment.Nov 28 2017, 11:28 AM
In D9021#172842, @mart wrote:

could the ide always take info from a set theme, like the base "default" one somehow?

Well you are introducing some bit from a different language, so parsers won't be able to process it ever.

mart added a comment.Nov 28 2017, 1:02 PM
In D9021#172905, @apol wrote:
In D9021#172842, @mart wrote:

could the ide always take info from a set theme, like the base "default" one somehow?

Well you are introducing some bit from a different language, so parsers won't be able to process it ever.

I don't think that for this project in particular it's really important, as is not providing any new api whatsoever.
conversely, the state is at the moment simply breaks any usage of qtcontrols 2.2+ api on every application, so it's a very severe blocker

apol accepted this revision.Nov 28 2017, 5:35 PM

Okay, maybe it's not important...

CMakeLists.txt
4

This is unrelated and incorrect.

This revision was automatically updated to reflect the committed changes.