+1

So it resulted in something like aspell.dll requiring aspell.dll?
What is the simplest/fastest way to test this?

In D9018#172789, @alexeymin wrote:

So it resulted in something like aspell.dll requiring aspell.dll?

Exactly that, yes... took me running it through Dependency Walker to work out what was going on :P

What is the simplest/fastest way to test this?

For building a unit test, i'm not really sure (though, i think, running a unit test on windows which loads the plugins and check that they load would likely do the trick, not sure there is one).

For testing the patch before accepting it, simply attempting to run anything on Windows which uses Sonnet should cause the failure. i found out because of Calligra Gemini, but anything which does spell checking should cause the issue to happen - for example the spell checker in ktexteditor. The symptom is having no functioning spell check at all (and debug output will complain that Sonnet could not load the plugin because it "could not find the specified procedure").

+1

Would it be possible to get an accept here, or is there something people fundamentally disagree with about it?