Rebased to master into https://invent.kde.org/plasma/kwin/-/merge_requests/145.

It doesn't apply on current master, so my test is a few weeks old

I'd love to merge it.

Ping? I tested it the other day on my Pinebook and didn't notice anything unusual

Merged

Overall this makes quite good sense, and I applaud the effort. Couple of thoughts and notes:

Moved here: https://invent.kde.org/plasma/kwin/-/merge_requests/106

This might be relevant: https://www.w3.org/TR/css-values-4/#absolute-lengths

After living with a 4K 14" screen for a bit now, I've changed my mind.

I was trying to work something on it but I got stuck somewhere and I wasn't able to launch Kwin with both a debugger and the libinput backend. I was doing it in a very different way than @zzag suggested and I do believe that way is a better and more extensible to implement it. Right now I don't have the time to implement it, but maybe in a few weeks I might have.

Ping, it should be committed?

This is basically a simple feature request, so I'm going to close it in favor of https://bugs.kde.org/show_bug.cgi?id=422938.

Moved to https://invent.kde.org/plasma/kwin/-/merge_requests/70.

Thanks ! Any chance you could submit this as a merge request on https://invent.kde.org/plasma/kwin/? It will probably get more review eyeballs now that we have moved patch review over there.

I think you already posted this to reddit, right? https://www.reddit.com/r/kde/comments/h9pkpy/crazy_idea_adopt_the_only_true_approach_to/

Apparently QButtonGroups are not supported by KConfigDialogManager (i.e., they cannot be managed automatically). I guess the manual wiring would have to do, otherwise a separate QGroupBox is warranted (as it is supported by the framework).

Please review my radio button wiring in effects/desktopgrid/desktopgrid_config.cpp. Is there a way to automate this mapping (i.e., have the framework manage the widgets)? One downside of this wiring is that the Defaults button is not properly updated when a radio button is clicked. The same issue occurs in the Desktop name alignment combo box (unrelated to the patch).

Address review comments:

• Use an enum config to store the click behavior
• Add a kconf_update Python script to migrate existing config files (tested with both Python 2 and 3)

@zzag I believe I can land now

In T13158#233081, @ndavis wrote:

@churaev Please don't derail the discussion.

@churaev Please don't derail the discussion.

In T13158#232973, @ndavis wrote:

I think I agree with the general idea, but it's a bit hard to fully grasp the scope of what must be done and I'm not sure what our first steps should be.

I think I agree with the general idea, but it's a bit hard to fully grasp the scope of what must be done and I'm not sure what our first steps should be.

Before merging, ti needs a kconf update script to migrate existing config files, or else it needs to not rename config file key names.

I've been using an effective 125% scale factor on my 13.3" FHD screen laptop and it magically made everything feel a ton better. We might want to consider that.

I am in favor of merging this. @davidedmundson or @zzag any thoughts ?

This should be ready.

Add a KWIN_UTILS logging category

In general, +1. I'm not certain about what a better place to put the new service utilities is, though. Perhaps it's better to move them to libkwineffects or something. Either way, it can be revisited later...

Use Real DBus interface name as required value in X-KDE-DBUS-Restricted-Interfaces

Add documentation, improve variable naming

Fix emails in copyrights

Remove whitespace & rebase

@zzag @davidedmundson https://invent.kde.org/plasma/kwin/-/merge_requests/47

Plasma/5.19 has been reset. Can you please create a merge request on invent.kde.org/plasma/kwin that fixes bug 420563?

In D29343#674536, @shubham wrote:

https://invent.kde.org/plasma/kwin/-/commit/914065ae66b0a8e147ca398450346242c8d3cc3c

Re: Commit subject line

@zzag How do I close this revision and also will the bug will get close itself?

https://invent.kde.org/plasma/kwin/-/commit/914065ae66b0a8e147ca398450346242c8d3cc3c
Pushed!

Push it to Plasma/5.19, please.

So while I'm not absolutely sure on this point, maybe the biggest benefit of migrating from script to effect (or maybe a plasmoid?) would be to avoid the limit of type of window allowed for scripts. Could this provide some integration with plasma panels and their plasmoids (like launchers)?

On second thought, although I've only thought of one disadvantage, I think it outweighs all the advantages of switching from ThumbnailItem to EffectWindow. Mixing C++ and QML elements in the same UI would make everything a nice (even impractical) mess.

The question is define the best way to implement this. KWin script? KWin effect? Plasmoid?

Right. And migrating the effects from C++ to QML can bring good results. Plasma itself shows that QML is great for building UI.

I very strongly support unifying Present Windows and Desktop Grid, and I would like virtual desktop management in the style of Parachute too. One Effect To Rule Them All. :)

Moved to invent !40

Moved here: https://invent.kde.org/plasma/kwin/-/merge_requests/39

LGTM!

Rebase

Revert fileUrl change

No rush, I just wanted to use Requested Changes for the first and last time here at Phab :D

sorry forgot about it, let me finish it now

Ping @ognarb? I think it's just the fileUrl thing that's missing.

• Make it const

• Address comments
• Use match() to get the index

Seems good to me @zzag @davidedmundson ?

• Add indexOf() method
• Delegate suggestions to a different method

LGTM

ping on this?