[kcmkwin/effects] Relocate KCM to System Settings' "Appearance" section
Changes PlannedPublic

Authored by ngraham on Jan 20 2019, 9:22 PM.

Details

Reviewers
None
Group Reviewers
VDG
Plasma
Maniphest Tasks
T11314: Systematic KCM reorganisation: Appearance section
Summary

This patch moves the Desktop Effects KCM out of the Workspace Behavior category and
into the top-level Appearance section, as discussed in T8871.

Test Plan

Diff Detail

Repository
R108 KWin
Branch
relocate-desktop-effects (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7356
Build 7374: arc lint + arc unit
ngraham created this revision.Jan 20 2019, 9:22 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 20 2019, 9:22 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
ngraham requested review of this revision.Jan 20 2019, 9:22 PM
ngraham edited the summary of this revision. (Show Details)Jan 20 2019, 9:26 PM
zzag added a subscriber: zzag.Jan 20 2019, 9:28 PM

Please remove [3/3] part from the subject line.

ngraham retitled this revision from [kcmkwin/effects] Relocate KCM to implement new Appearance section layout [3/3] to [kcmkwin/effects] Relocate KCM to implement new Appearance section layout.Jan 20 2019, 9:30 PM

On hold until all three are accepted, and there's some unresolved discussion in D18419.

The goal of moving effects which are only related to eye-candy to Appearance definitely makes sense and is a goal I 1000% support.

But the current KCM is a mixture of high level selection a user should be meddling with and low level tech things which happen to use the effects plugin structure.

Things like blur settings are purely tech focussed, zoom is purely behvaioural accessibility and "showFPS" shouldn't exist in the UI.

I think it's a good example of a case where we need to enforce ground-up rethinking and moving just the releavnt parts.

We can make a kwin task about splitting this.

ngraham planned changes to this revision.Aug 1 2019, 3:56 PM

That makes sense. Let's put this on hold until the KCM gets split up accordingly.

ngraham retitled this revision from [kcmkwin/effects] Relocate KCM to implement new Appearance section layout to [kcmkwin/effects] Relocate KCM to System Settings' "Appearance" section.Aug 1 2019, 7:37 PM
ngraham edited the summary of this revision. (Show Details)
GB_2 added a comment.Aug 2 2019, 9:05 AM

I think we can still rename the KCM to "Graphical Effects" though.

zzag added a comment.Aug 2 2019, 1:37 PM
In D18416#505633, @GB_2 wrote:

I think we can still rename the KCM to "Graphical Effects" though.

What's wrong with "Desktop Effects?"

In D18416#505710, @zzag wrote:
In D18416#505633, @GB_2 wrote:

I think we can still rename the KCM to "Graphical Effects" though.

What's wrong with "Desktop Effects?"

It misleadingly includes the word "Desktop", which in the typical user's understanding for this context, is the thing with the wallpaper that has files and folders and icons on it.

zzag added a comment.Aug 2 2019, 1:54 PM

It misleadingly includes the word "Desktop", which in the typical user's understanding for this context, is the thing with the wallpaper that has files and folders and icons on it.

People have been using "desktop effects" term since Compiz was all the rage and perhaps even before that. So, I doubt the "desktop" part causes confusion.

In D18416#505727, @zzag wrote:

It misleadingly includes the word "Desktop", which in the typical user's understanding for this context, is the thing with the wallpaper that has files and folders and icons on it.

People have been using "desktop effects" term since Compiz was all the rage and perhaps even before that. So, I doubt the "desktop" part causes confusion.

Regular users don't have any idea what Compiz is (or was). Our user interfaces are designed for normal people, not technical experts.

Anyway, we can continue the discussion in D22894 now that I've submitted it. I wound encourage KWin folks to give the VDG the benefit of the doubt when it comes to the user interface though, the way we have been encouraged to give KWin developers the benefit of the doubt regarding implementation details.