Add Findepoll.cmake to find epoll/epoll-shim and add initial FreeBSD support
Needs ReviewPublic

Authored by tcberner on Jan 6 2019, 11:24 AM.

Details

Reviewers
None
Group Reviewers
Automotive
KWin
FreeBSD
Summary

Initial FreeBSD support for wayland.

Diff Detail

Repository
R108 KWin
Branch
Plasma/5.14
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6697
Build 6715: arc lint + arc unit
tcberner created this revision.Jan 6 2019, 11:24 AM
Restricted Application added a project: KWin. · View Herald TranscriptJan 6 2019, 11:24 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
tcberner requested review of this revision.Jan 6 2019, 11:24 AM
tcberner updated this revision to Diff 48793.Jan 6 2019, 11:55 AM
  • add include directory
  • fix HAVE_epoll -> epoll_FOUND

I'm not sure whether KWin should carry this patch. No developer will be able to test it or ensure it works. It makes changes more difficult, it basically turns this into a don't touch me area.

For the Udev case I would prefer if FreeBSD would provide a shim udev KWin can link against and which provides the hack deviceFromSyspath("/dev/dri/card0");

I really don't think KWin should break the Udev code path for differences in the platforms. If Udev cannot be used, then we don't use udev. But we don't fake udev inside our udev integration code.

graesslin added inline comments.Jan 12 2019, 6:53 AM
CMakeLists.txt
278

If this is FreeBSD specific it should be indicated so. Don't list it as an optional feature on platforms not affected. Please check whether it's needed and then turn it into a required feature on FreeBSD.

528

and if epoll becomes a required feature on FreeBSD we can remove this check here. No need to keep the special if for freebsd.

virtual_terminal.cpp
88

why is that linux specific?

105–109

this I would prefer if it goes through a configure file, so that we don't need the ifdef in code.