Differential D28224

Improve tests behaviour on set ups with high dpi
ClosedPublic
Actions

Authored by apol on Mar 23 2020, 7:28 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:9b7ab4d16a8e: Improve tests behaviour on set ups with high dpi
Summary

We are testing on a 100x100 mock display. We'd ask QWidget for our
display's dpi, it would not use the mock display but the actual
system's. On my system it made the corners overlap with each other and
all sorts of weird things happened.

Test Plan

The tests actually pass here.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Mar 23 2020, 7:28 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 23 2020, 7:28 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
apol requested review of this revision.Mar 23 2020, 7:28 PM
davidedmundson accepted this revision.Mar 23 2020, 7:29 PM
This revision is now accepted and ready to land.Mar 23 2020, 7:29 PM
Closed by commit R108:9b7ab4d16a8e: Improve tests behaviour on set ups with high dpi (authored by apol). · Explain WhyMar 23 2020, 11:16 PM
This revision was automatically updated to reflect the committed changes.
Zren added a subscriber: Zren.Jun 21 2020, 3:06 PM
Zren added inline comments.
screenedge.cpp
730

Was (X + X + 5) / 6 deliberate here? The old behavior was (X + Y + 5) / 6.

zzag added a subscriber: zzag.Jun 22 2020, 6:59 AM
zzag added inline comments.
screenedge.cpp
730

I don't think so. Can you please create a merge request?

Revision Contents
Changeset List

PathPackages
Mgestures.cpp (3 lines)
Mscreenedge.cpp (3 lines)
Mscreens.h (3 lines)
Mscreens.cpp (10 lines)

Diff 78322

View Options

gestures.cpp

Loading...
View Options

screenedge.cpp

Loading...
View Options

screens.h

Loading...
View Options

screens.cpp

Loading...