arrowd (Gleb Popov)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 7:47 AM (186 w, 22 h)
Availability
Available

Recent Activity

Mon, Mar 11

arrowd added a comment to D17760: astyle: support the system astyle library.

Question: does any distro package that?

At least my openSUSE doesn't nor any other distro I know of, only thing I found was:

https://rpmfind.net/linux/rpm2html/search.php?query=libastyle-devel

Mon, Mar 11, 11:48 AM · KDevelop

Sun, Mar 3

Restricted Application edited projects for D1283: ASCII-art output platform, added: KWin; removed Plasma.
Sun, Mar 3, 11:01 AM · KWin

Sat, Feb 23

arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Pingy-ping, bumpy-bump.

Sat, Feb 23, 4:36 PM · Plasma

Feb 10 2019

arrowd added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

I have little Qt experience, why nested event loops are bad? What are options to avoid them?

Feb 10 2019, 7:39 PM · KDevelop
arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Bump();

Feb 10 2019, 8:34 AM · Plasma

Feb 8 2019

arrowd added a reviewer for D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted.: KDevelop.
Feb 8 2019, 1:28 PM · KDevelop

Feb 5 2019

arrowd requested review of D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..
Feb 5 2019, 12:43 PM · KDevelop
arrowd committed R32:fbb955c772ec: Workaround the bug found by ASan, which can be seen on FreeBSD CI. (authored by arrowd).
Workaround the bug found by ASan, which can be seen on FreeBSD CI.
Feb 5 2019, 9:37 AM
arrowd closed D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..
Feb 5 2019, 9:37 AM · KDevelop
arrowd added a comment to D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..

Oh, sorry, I forgot to press "Submit" on Phab and thought I posted ASan log here.

Feb 5 2019, 8:57 AM · KDevelop

Feb 3 2019

arrowd updated the diff for D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..

Remove code used for description.

Feb 3 2019, 5:09 PM · KDevelop
arrowd added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

you are right, this code should essentially do if (rt->findExecutable(compiler->path().isEmpty()) continue;, could you introduce that please?

Feb 3 2019, 4:56 PM

Jan 29 2019

arrowd committed R68:ba7e9fd3adba: Fix Xdebug disconnecting after php finished if multiple connections are allowed (authored by wcancino).
Fix Xdebug disconnecting after php finished if multiple connections are allowed
Jan 29 2019, 2:19 PM
arrowd closed D18122: Fix Xdebug disconnecting after php finished if multiple connections are allowed.
Jan 29 2019, 2:19 PM · KDevelop

Jan 27 2019

arrowd added inline comments to D14391: Fix random order of plugin's config pages.
Jan 27 2019, 5:55 PM · KDevelop

Jan 24 2019

arrowd committed R32:a2ab30ed7c09: Support for indent-after-parens astyle option (authored by miroslawstein).
Support for indent-after-parens astyle option
Jan 24 2019, 7:07 PM
arrowd committed R32:7fd559bba4b6: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer) (authored by antonanikin).
Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer)
Jan 24 2019, 5:25 PM
arrowd closed D15565: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer).
Jan 24 2019, 5:25 PM · KDevelop
arrowd added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

the path of the compiler is now always the path of the compiler in the local host, which breaks when you have a runtime with a different setup.

Jan 24 2019, 4:38 PM

Jan 23 2019

arrowd requested review of D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..
Jan 23 2019, 6:33 AM · KDevelop

Jan 19 2019

arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Ping? Any chance to get this into 5.15?

Jan 19 2019, 8:29 AM · Plasma

Jan 16 2019

arrowd requested review of D18296: Add support for passing cursor information via URL parameters when running kioclient exec..
Jan 16 2019, 1:59 PM · Plasma

Jan 15 2019

arrowd abandoned D17938: Add support for passing cursor information to KRun..

Right.

Jan 15 2019, 4:21 PM · Frameworks
arrowd committed R40:1fa3a0e85e71: Add ability to get cursor data from URL query arguments, like file://foo.txt? (authored by arrowd).
Add ability to get cursor data from URL query arguments, like file://foo.txt?
Jan 15 2019, 11:17 AM
arrowd closed D18099: Add ability to get cursor data from URL query arguments, like file://foo.txt?line=123&column=456.
Jan 15 2019, 11:17 AM · Kate
arrowd added a comment to D18099: Add ability to get cursor data from URL query arguments, like file://foo.txt?line=123&column=456.

Can I push this?

Jan 15 2019, 7:07 AM · Kate

Jan 14 2019

arrowd added a comment to D5447: Only add auto-detected compilers to model if they actually exist.
In D5447#393144, @apol wrote:

Let's look at this the other way around, what are you trying to fix?

Jan 14 2019, 6:51 PM
arrowd accepted D18216: Scratchpad: Validate actions when opening context menu.

Works great now, thanks!

Jan 14 2019, 7:06 AM · KDevelop

Jan 12 2019

arrowd committed R59:de4ebe3cc162: Fix "unused parameter/variable" warnings. Cleanup whitespace. Original patch by… (authored by arrowd).
Fix "unused parameter/variable" warnings. Cleanup whitespace. Original patch by…
Jan 12 2019, 6:47 PM
arrowd committed R59:311ac83d93ff: Fix unused parameters warnings (authored by arrowd).
Fix unused parameters warnings
Jan 12 2019, 6:47 PM
arrowd closed D10115: Fix unused parameters warnings.
Jan 12 2019, 6:47 PM
arrowd added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I found the following minor issue:

When I just started KDevelop and open "Scratchpad" toolview, any action except "New Scratch" are greyed out. Even "Remove Scratch", as well as "Run Scratch". When I open any scratch, it turns back to normal, even if I again close all Sratchpad windows.

That's intended. The actions are all associated with the selected scratch in the toolview list. Switching the window to a different scratch also changes this selection, while closing a window keeps the selection.

Jan 12 2019, 2:17 PM · KDevelop
arrowd added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

But that's not related to your change, so please push it. Not sure where to, 5.3, I guess.

Jan 12 2019, 8:54 AM · KDevelop
arrowd added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I found the following minor issue:

Jan 12 2019, 8:50 AM · KDevelop
arrowd added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
Jan 12 2019, 8:27 AM
arrowd updated the diff for D5447: Only add auto-detected compilers to model if they actually exist.

Restore another check.

Jan 12 2019, 8:26 AM

Jan 11 2019

arrowd added a comment to D14391: Fix random order of plugin's config pages.

The problem with current revision is that pages added in uicontroller.cpp:530 aren't sorted.

Jan 11 2019, 1:23 PM · KDevelop

Jan 10 2019

arrowd updated the diff for D14391: Fix random order of plugin's config pages.

Fix docs, rename append* methods to add*.

Jan 10 2019, 3:02 PM · KDevelop
arrowd updated the diff for D14391: Fix random order of plugin's config pages.

Remove insert API and use append everywhere.

Jan 10 2019, 2:35 PM · KDevelop
arrowd commandeered D14391: Fix random order of plugin's config pages.
Jan 10 2019, 2:31 PM · KDevelop
arrowd added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
Jan 10 2019, 1:23 PM

Jan 8 2019

arrowd added a comment to D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

Sorry for being late to the party. Checked this on FreeBSD - no regressions.

Jan 8 2019, 5:08 PM · KDevelop
arrowd committed R32:16c8d3c661a7: GrepView: Extend default file extensions to search (authored by arrowd).
GrepView: Extend default file extensions to search
Jan 8 2019, 4:57 PM
arrowd closed D17892: GrepView: Extend default file extensions to search.
Jan 8 2019, 4:57 PM · KDevelop
arrowd committed R32:b53ea9aa452e: Meson plugin: First working version (authored by dmensinger).
Meson plugin: First working version
Jan 8 2019, 4:52 PM
arrowd closed D17278: Meson plugin: First working version.
Jan 8 2019, 4:52 PM · Documentation, KDevelop
arrowd updated the diff for D18099: Add ability to get cursor data from URL query arguments, like file://foo.txt?line=123&column=456.

Change the type from uint to int.

Jan 8 2019, 4:34 PM · Kate
arrowd added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
Jan 8 2019, 4:31 PM
arrowd updated the diff for D5447: Only add auto-detected compilers to model if they actually exist.

Restore a check.

Jan 8 2019, 4:30 PM
arrowd added a comment to D18099: Add ability to get cursor data from URL query arguments, like file://foo.txt?line=123&column=456.

+1, but it would be good if we could share this code...

Jan 8 2019, 3:29 PM · Kate
arrowd requested review of D18099: Add ability to get cursor data from URL query arguments, like file://foo.txt?line=123&column=456.
Jan 8 2019, 3:25 PM · Kate

Jan 5 2019

arrowd added a comment to D17938: Add support for passing cursor information to KRun..

I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API.

Jan 5 2019, 5:26 PM · Frameworks
arrowd accepted D17525: Show "Move into Source" action in code menu.

Yep, sorry, everything's alright.

Jan 5 2019, 9:33 AM · KDevelop
arrowd added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
Jan 5 2019, 9:11 AM
arrowd accepted D17370: Add assistant to generate header guards.

Works great, good job!

Jan 5 2019, 8:56 AM · KDevelop
arrowd accepted D17892: GrepView: Extend default file extensions to search.
Jan 5 2019, 8:52 AM · KDevelop

Jan 4 2019

arrowd accepted D17278: Meson plugin: First working version.

I also don't know why the icons don't show up. I have oriented myself on the code from the CMake plugin, and I don't know what I am doing different/wrong. Maybe KDevelop has to be installed in a system directory (/usr) for this to work?

Jan 4 2019, 3:30 PM · Documentation, KDevelop
arrowd added a comment to D17278: Meson plugin: First working version.

Yep, that fixed the issue.

Jan 4 2019, 1:22 PM · Documentation, KDevelop
arrowd committed R32:263a57379ef6: QuickOpen: Trim whitespace from input (authored by arrowd).
QuickOpen: Trim whitespace from input
Jan 4 2019, 10:44 AM
arrowd closed D17885: QuickOpen: Trim whitespace from input.
Jan 4 2019, 10:44 AM · KDevelop

Jan 3 2019

arrowd added a comment to D17370: Add assistant to generate header guards.

It now compiles and unit test passes, however my own quick test revealed following problem.

Jan 3 2019, 8:15 PM · KDevelop
arrowd added a comment to D17525: Show "Move into Source" action in code menu.

Strange. I don't have this menu item even with your patch.

Jan 3 2019, 8:03 PM · KDevelop
arrowd accepted D17839: Update kdevelop app icon to latest breeze-icons version.

Looks good to me.

Jan 3 2019, 7:02 PM · KDevelop
arrowd added a comment to D17525: Show "Move into Source" action in code menu.

Sorry for silly question, but where this change is reflected in KDevelop UI?

Jan 3 2019, 6:57 PM · KDevelop
arrowd added a comment to D17278: Meson plugin: First working version.

Tried this out on FreeBSD with KDevelop master.

Jan 3 2019, 6:46 PM · Documentation, KDevelop
arrowd added a comment to D15565: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer).

Since 5.3.1 was released, can we get this in?

Jan 3 2019, 6:11 PM · KDevelop
arrowd accepted D14391: Fix random order of plugin's config pages.

I have tried this out on master and it works for me. If no one objects in next few days, please push this.

Jan 3 2019, 5:32 PM · KDevelop
arrowd updated the diff for D10115: Fix unused parameters warnings.

Refresh diff and address comments.

Jan 3 2019, 4:34 PM
arrowd commandeered D10115: Fix unused parameters warnings.
Jan 3 2019, 4:30 PM
arrowd updated the diff for D5447: Only add auto-detected compilers to model if they actually exist.

Pass absolute path instead of the compiler name to createCompiler(). Remove strange check that was breaking tests.

Jan 3 2019, 2:26 PM
arrowd commandeered D5447: Only add auto-detected compilers to model if they actually exist.
Jan 3 2019, 2:25 PM
arrowd closed T6685: Fix debugger unit test failures on CI as Resolved.

Judging from current CI output, this has been fixed.

Jan 3 2019, 12:45 PM · KDevelop
arrowd added inline comments to D17794: Pkg-config plugin.
Jan 3 2019, 12:38 PM · KDevelop
arrowd added inline comments to D17370: Add assistant to generate header guards.
Jan 3 2019, 12:03 PM · KDevelop
arrowd added a reviewer for D17370: Add assistant to generate header guards: KDevelop.
Jan 3 2019, 11:40 AM · KDevelop
arrowd requested review of D17938: Add support for passing cursor information to KRun..
Jan 3 2019, 9:35 AM · Frameworks

Dec 25 2018

arrowd added inline comments to D17794: Pkg-config plugin.
Dec 25 2018, 7:33 AM · KDevelop

Dec 3 2018

arrowd added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.

If the problem this patch solves is to have CMAKE_INSTALL_PREFIX to be set for newly-created projects, why not just add a configuration option to the CMake plugin?

Dec 3 2018, 4:45 AM · KDevelop

Oct 15 2018

arrowd added a comment to D16218: [KDevelop/Core]: safe signal-handler implementation.

Oh, misunderstanding! I simply don't have a full KF5 build environment on FreeBSD yet. I'm running TrueOS in a VM on a system that isn't exactly powerful, so I'm waiting until "Project Trident" is released with a full KF5 desktop option.

Oct 15 2018, 10:26 AM · KDevelop
arrowd added inline comments to D16218: [KDevelop/Core]: safe signal-handler implementation.
Oct 15 2018, 10:04 AM · KDevelop
arrowd added a comment to D16218: [KDevelop/Core]: safe signal-handler implementation.

Re: the testing I did on FreeBSD: that's with a dedicated demonstrator; I cannot currently build KDevelop5 there.

Oct 15 2018, 10:04 AM · KDevelop
arrowd added inline comments to D16218: [KDevelop/Core]: safe signal-handler implementation.
Oct 15 2018, 10:02 AM · KDevelop

Oct 6 2018

arrowd added inline comments to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..
Oct 6 2018, 8:22 AM · KDevelop

Oct 4 2018

arrowd added a comment to D15895: Use CLANG_INCLUDE_DIRS for clang include dir.

FreeBSD+Clang 6 also works fine with this patch.

Oct 4 2018, 9:24 AM · KDevelop

Oct 2 2018

arrowd added a comment to D15895: Use CLANG_INCLUDE_DIRS for clang include dir.

Does it work with clang 6.0?

Oct 2 2018, 2:03 PM · KDevelop

Sep 28 2018

arrowd added a comment to D9344: [KDevelop] : [fixed] consistent use of the project name allowing to create multiple projects in a single source tree.
A proper solution would be to delete just the settings file, if overwriting is to be done.
Sep 28 2018, 8:30 AM · KDevelop
arrowd added a comment to D9344: [KDevelop] : [fixed] consistent use of the project name allowing to create multiple projects in a single source tree.

I don't quite get it. In which situation do we want to override the project (delete .kdev file), but do not clear .kdev dir?

Sep 28 2018, 7:04 AM · KDevelop
arrowd added a comment to T6262: Overriding an existing project should wipe .kdev4 directory.

(In any case I don't see how it could *not* be recreated given that it will hold the new settings file).

Sep 28 2018, 7:01 AM · KDevelop

Aug 22 2018

arrowd added a comment to D14432: Appwizard plugin. Add more repository information in the project file. .

IMHO we should change the code then to allow the respective vcs plugin used for the new project to write any additional data it wants/needs to store in the config, instead of this generic writing which is only currently needed for one system. No idea yet how this could be done, not looked at the code, just speaking in principle.

Aug 22 2018, 10:38 AM · KDevelop

Aug 14 2018

arrowd committed R32:bbcf0cfa29c6: Use "gmake" command in custommake plugin on FreeBSD. Fixes unit test. (authored by arrowd).
Use "gmake" command in custommake plugin on FreeBSD. Fixes unit test.
Aug 14 2018, 9:47 AM
arrowd closed D14731: Use "gmake" command in custommake plugin on FreeBSD. Fixes unit test..
Aug 14 2018, 9:47 AM · KDevelop

Aug 13 2018

arrowd added a comment to T9249: KDevelop's GDB pretty printer units tests fail due to non-UTF-8 default codec.

Yes, I think the issue is in the test itself. Thanks for poking with CI.

Aug 13 2018, 11:59 AM · FreeBSD, KDevelop, build.kde.org
arrowd added a comment to T9249: KDevelop's GDB pretty printer units tests fail due to non-UTF-8 default codec.

KDevelop tests on FreeBSD are disabled now due to hangs, but the last test run shows that python support is working OK. The test fails somewhere in the middle, though, but python gets initialized OK.

Aug 13 2018, 11:34 AM · FreeBSD, KDevelop, build.kde.org

Aug 11 2018

arrowd added a comment to D13905: Fix KTextEditor::MainWindow to outlive the KTextEditor::View objects.

Same for Linux: https://build.kde.org/view/KDevelop/job/KDevelop%20kdevelop%20kf5-qt5%20SUSEQt5.9/330/

Aug 11 2018, 10:24 AM · KDevelop
arrowd added a comment to D13905: Fix KTextEditor::MainWindow to outlive the KTextEditor::View objects.

It seems, after this change the test ktexteditorpluginintegration started to fail: https://build.kde.org/view/KDevelop/job/KDevelop%20kdevelop%20kf5-qt5%20FreeBSDQt5.10/57/testReport/junit/(root)/TestSuite/test_ktexteditorpluginintegration/

Aug 11 2018, 10:23 AM · KDevelop
arrowd committed R32:db57eb31c392: Fix `test_clang-duchain` by making the test expectedly fail. (authored by arrowd).
Fix `test_clang-duchain` by making the test expectedly fail.
Aug 11 2018, 9:56 AM
arrowd closed D14315: Fix `test_clang-duchain` by making the test expectedly fail..
Aug 11 2018, 9:55 AM · KDevelop
arrowd added a comment to D14731: Use "gmake" command in custommake plugin on FreeBSD. Fixes unit test..

It turned out that BSD make just don't need that flag, so add it conditionally.

Aug 11 2018, 9:49 AM · KDevelop
arrowd updated the diff for D14731: Use "gmake" command in custommake plugin on FreeBSD. Fixes unit test..

Address comments.

Aug 11 2018, 9:48 AM · KDevelop
arrowd updated the diff for D14731: Use "gmake" command in custommake plugin on FreeBSD. Fixes unit test..

Fix the test another way.

Aug 11 2018, 9:44 AM · KDevelop