arrowd (Gleb Popov)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 7:47 AM (220 w, 3 d)
Availability
Available

Recent Activity

Oct 2 2019

arrowd committed R126:f6dcff90718f: Correctly handle relative paths with line information, like `../foo.txt:123`. (authored by arrowd).
Correctly handle relative paths with line information, like `../foo.txt:123`.
Oct 2 2019, 7:20 AM

Sep 27 2019

arrowd committed R126:37cac45cc1fc: Fix a bug in `kioclient exec foo.txt:123` handling. (authored by arrowd).
Fix a bug in `kioclient exec foo.txt:123` handling.
Sep 27 2019, 6:09 PM

Sep 26 2019

arrowd retitled D18758: Make Project::open() method use async KIO methods. from Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted. to Make Project::open() method use async KIO methods..
Sep 26 2019, 10:27 AM · KDevelop
arrowd committed R32:d1b13f5217be: Add IRuntime::findExecutable method. Use it in `custom-definesandincludes`… (authored by arrowd).
Add IRuntime::findExecutable method. Use it in `custom-definesandincludes`…
Sep 26 2019, 10:26 AM
arrowd closed D5447: Only add auto-detected compilers to model if they actually exist.
Sep 26 2019, 10:26 AM

Jul 20 2019

arrowd added a comment to D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes..

I'm not familiar with KDE release engineering, so I'm asking to do merging someone else.

Jul 20 2019, 6:41 PM · Plasma
arrowd committed R126:6d86fd453417: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with… (authored by arrowd).
kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with…
Jul 20 2019, 3:20 PM
arrowd closed D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes..
Jul 20 2019, 3:20 PM · Plasma
arrowd added a comment to D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes..

I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc.
So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries have a different meaning, one that we can't know client-side).

Jul 20 2019, 10:49 AM · Plasma

Jul 19 2019

arrowd added a reviewer for D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.: Frameworks.
Jul 19 2019, 3:03 PM · Plasma
arrowd added a comment to D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes..

Oh, if the latter syntax also works, then you are right.

Jul 19 2019, 3:02 PM · Plasma

Jul 18 2019

arrowd added a comment to D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes..

Could we only apply the :xx check on the filename part, not on the server part? Someone might expect that http://path.to/file.txt:99 also works for remote files.

Jul 18 2019, 5:00 PM · Plasma
arrowd requested review of D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes..
Jul 18 2019, 9:03 AM · Plasma

Jul 10 2019

arrowd committed R32:01e62e6cdcbb: Remove invalid check from test_projectload test. (authored by arrowd).
Remove invalid check from test_projectload test.
Jul 10 2019, 7:15 AM
arrowd closed D22350: Remove invalid check from test_projectload test..
Jul 10 2019, 7:15 AM · KDevelop

Jul 9 2019

arrowd requested review of D22350: Remove invalid check from test_projectload test..
Jul 9 2019, 6:33 PM · KDevelop

Jun 18 2019

arrowd added a comment to D18758: Make Project::open() method use async KIO methods..

so, I've now committed an alternative fix (or so I hope...) see:

commit bd048e67f056b5be25ed57fb2be947444f68c24e
Author: Milian Wolff <mail@milianw.de>
Date:   Mon Jun 17 22:26:32 2019 +0200

    Guard against crashes when IStatus object gets destroyed at bad times
Jun 18 2019, 8:48 AM · KDevelop

Jun 10 2019

arrowd added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

Now the test passes!

Jun 10 2019, 11:52 AM · Baloo, Frameworks
arrowd committed R286:346918916474: Enable usermetadatawritertest for all UNIXes, not only Linux. (authored by arrowd).
Enable usermetadatawritertest for all UNIXes, not only Linux.
Jun 10 2019, 11:26 AM
arrowd closed D21720: Enable usermetadatawritertest for all UNIXes, not only Linux..
Jun 10 2019, 11:26 AM · Baloo, Frameworks
arrowd requested review of D21720: Enable usermetadatawritertest for all UNIXes, not only Linux..
Jun 10 2019, 11:25 AM · Baloo, Frameworks
arrowd added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code?

Jun 10 2019, 11:22 AM · Baloo, Frameworks
arrowd added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

It compiles now, but the test fails:

Jun 10 2019, 11:02 AM · Baloo, Frameworks
arrowd added inline comments to D20967: [UserMetaData] Add method to query which attributes are set.
Jun 10 2019, 7:40 AM · Baloo, Frameworks

May 28 2019

arrowd added a comment to D18758: Make Project::open() method use async KIO methods..
In D18758#469623, @apol wrote:

Quite possibly, it doesn't happen outside of tests after all, right?

May 28 2019, 8:22 AM · KDevelop

May 24 2019

arrowd added a comment to D18758: Make Project::open() method use async KIO methods..

I'm more interested in fixing the intial issue. With KIO jobs in openProject turned async, the crash now happens right in qWait(1) of KDevelop::TestCore::shutdown(). And what's strange is that adding qWait(1) at the end of testReload() test still fixes issue.

May 24 2019, 4:14 PM · KDevelop
arrowd accepted D21380: show static word wrap marker always if requested.
May 24 2019, 1:45 PM · Frameworks, Kate

May 21 2019

arrowd updated the diff for D18758: Make Project::open() method use async KIO methods..

Changes:

  • Import QtPromise 0.5.0 into kdevplatform/3dparty/ directory.
  • Remove synchronious KIO calls from Project::open() and use QPromises there instead.
May 21 2019, 10:12 AM · KDevelop

May 7 2019

arrowd added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
May 7 2019, 3:12 PM
arrowd updated the diff for D5447: Only add auto-detected compilers to model if they actually exist.
  • Use compiler executable name instead of absolute path.
May 7 2019, 3:12 PM

May 6 2019

arrowd added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
May 6 2019, 6:26 PM
arrowd updated the diff for D5447: Only add auto-detected compilers to model if they actually exist.
  • Address some comments.
May 6 2019, 6:24 PM
arrowd committed R32:4c947c58f85d: Fix deadlock exception in FileManagerListJob. (authored by arrowd).
Fix deadlock exception in FileManagerListJob.
May 6 2019, 12:19 PM

May 2 2019

arrowd added a comment to R32:a0fd2014489c: Don't crash when background listing outlasts file manager list job.

This commit introduced a crash in some tests on FreeBSD. The m_listing mutex gets locked twice by the same thread causing deadlock exception.

May 2 2019, 3:10 PM

Apr 13 2019

arrowd added a comment to D18758: Make Project::open() method use async KIO methods..

Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?

Apr 13 2019, 6:55 PM · KDevelop

Apr 11 2019

arrowd committed R126:8072a6acf221: Add support for passing cursor information via URL parameters when running… (authored by arrowd).
Add support for passing cursor information via URL parameters when running…
Apr 11 2019, 7:46 AM
arrowd closed D18296: Add support for passing cursor information via URL parameters when running kioclient exec..
Apr 11 2019, 7:46 AM · Plasma

Apr 10 2019

arrowd added inline comments to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..
Apr 10 2019, 6:53 AM · Plasma
arrowd updated the diff for D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Address comments.

Apr 10 2019, 6:52 AM · Plasma

Apr 9 2019

arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Is the makeURL function still used, or should it be removed now?

Apr 9 2019, 5:21 AM · Plasma

Apr 6 2019

arrowd added inline comments to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..
Apr 6 2019, 5:33 PM · Plasma
arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Is it really necessary to copy urlinfo.h here? Wouldn't be enough to just create a static function and put the URL parsing logic there?

Apr 6 2019, 5:32 PM · Plasma
arrowd added a comment to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

@thomassc it is because I commandeered your revision to be able to update it. If you want, you do the same. First select "Commandeer Revision" at the bottom of this page, and then use arc diff (possibly with --update D18567) to update it.

Apr 6 2019, 12:33 PM · KDevelop

Apr 5 2019

arrowd updated the diff for D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Simplify code.

Apr 5 2019, 12:56 PM · KDevelop
arrowd commandeered D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Apr 5 2019, 12:56 PM · KDevelop
arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Can I finally push this?

Apr 5 2019, 8:45 AM · Plasma

Apr 4 2019

arrowd added a comment to D18758: Make Project::open() method use async KIO methods..

After finishing initial implementation I found out that QtPromise requires exceptions enabled. KDevelop seem to have exceptions disabled right now.

Apr 4 2019, 6:36 PM · KDevelop

Apr 1 2019

arrowd added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
Apr 1 2019, 5:10 PM
arrowd updated the diff for D5447: Only add auto-detected compilers to model if they actually exist.
  • Move the bracket.
Apr 1 2019, 5:10 PM
arrowd updated the diff for D5447: Only add auto-detected compilers to model if they actually exist.

Add IRuntime::findExecutable() API and make compilerprovider use it.

Apr 1 2019, 1:46 PM
arrowd added a comment to D18758: Make Project::open() method use async KIO methods..

KAsync looks a bit unmaintained. On the other hand, QtPromise seems to be an active project. Should I start looking into the latter?

Apr 1 2019, 12:06 PM · KDevelop
arrowd committed R32:e8b3ee4a2541: Output config subpages alphabetically, instead of order in which corresponding… (authored by arrowd).
Output config subpages alphabetically, instead of order in which corresponding…
Apr 1 2019, 11:29 AM
arrowd closed D14391: Fix random order of plugin's config pages.
Apr 1 2019, 11:29 AM · KDevelop
arrowd added a comment to D14391: Fix random order of plugin's config pages.

Onto master?

Apr 1 2019, 10:58 AM · KDevelop

Mar 31 2019

arrowd added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

I started working on it.

Mar 31 2019, 11:25 AM
arrowd committed R32:44fcd808e6bf: Flatpak plugin - fix typo ("flies" -> "files"). (authored by arrowd).
Flatpak plugin - fix typo ("flies" -> "files").
Mar 31 2019, 11:13 AM

Mar 29 2019

arrowd added a comment to D14391: Fix random order of plugin's config pages.

I don't remember details of this revision, but at least it seems to do like how we agreed.

Mar 29 2019, 1:06 PM · KDevelop
arrowd updated the diff for D14391: Fix random order of plugin's config pages.

Remove API changes and just sort plugins list.

Mar 29 2019, 1:05 PM · KDevelop

Mar 25 2019

arrowd updated the diff for D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Address comments.

Mar 25 2019, 2:01 PM · Plasma
arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..
In D18296#437985, @apol wrote:

Overall this makes sense to me, this assumes though that there will never be a file ending with :digit, is that something we can live with?

Mar 25 2019, 1:57 PM · Plasma
arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Monthly bump.

Mar 25 2019, 11:40 AM · Plasma

Mar 11 2019

arrowd added a comment to D17760: astyle: support the system astyle library.

Question: does any distro package that?

At least my openSUSE doesn't nor any other distro I know of, only thing I found was:

https://rpmfind.net/linux/rpm2html/search.php?query=libastyle-devel

Mar 11 2019, 11:48 AM · KDevelop

Mar 3 2019

Restricted Application edited projects for D1283: ASCII-art output platform, added: KWin; removed Plasma.
Mar 3 2019, 11:01 AM · KWin

Feb 23 2019

arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Pingy-ping, bumpy-bump.

Feb 23 2019, 4:36 PM · Plasma

Feb 10 2019

arrowd added a comment to D18758: Make Project::open() method use async KIO methods..

I have little Qt experience, why nested event loops are bad? What are options to avoid them?

Feb 10 2019, 7:39 PM · KDevelop
arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Bump();

Feb 10 2019, 8:34 AM · Plasma

Feb 8 2019

arrowd added a reviewer for D18758: Make Project::open() method use async KIO methods.: KDevelop.
Feb 8 2019, 1:28 PM · KDevelop

Feb 5 2019

arrowd requested review of D18758: Make Project::open() method use async KIO methods..
Feb 5 2019, 12:43 PM · KDevelop
arrowd committed R32:fbb955c772ec: Workaround the bug found by ASan, which can be seen on FreeBSD CI. (authored by arrowd).
Workaround the bug found by ASan, which can be seen on FreeBSD CI.
Feb 5 2019, 9:37 AM
arrowd closed D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..
Feb 5 2019, 9:37 AM · KDevelop
arrowd added a comment to D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..

Oh, sorry, I forgot to press "Submit" on Phab and thought I posted ASan log here.

Feb 5 2019, 8:57 AM · KDevelop

Feb 3 2019

arrowd updated the diff for D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..

Remove code used for description.

Feb 3 2019, 5:09 PM · KDevelop
arrowd added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

you are right, this code should essentially do if (rt->findExecutable(compiler->path().isEmpty()) continue;, could you introduce that please?

Feb 3 2019, 4:56 PM

Jan 29 2019

arrowd committed R68:ba7e9fd3adba: Fix Xdebug disconnecting after php finished if multiple connections are allowed (authored by wcancino).
Fix Xdebug disconnecting after php finished if multiple connections are allowed
Jan 29 2019, 2:19 PM
arrowd closed D18122: Fix Xdebug disconnecting after php finished if multiple connections are allowed.
Jan 29 2019, 2:19 PM · KDevelop

Jan 27 2019

arrowd added inline comments to D14391: Fix random order of plugin's config pages.
Jan 27 2019, 5:55 PM · KDevelop

Jan 24 2019

arrowd committed R32:a2ab30ed7c09: Support for indent-after-parens astyle option (authored by miroslawstein).
Support for indent-after-parens astyle option
Jan 24 2019, 7:07 PM
arrowd committed R32:7fd559bba4b6: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer) (authored by antonanikin).
Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer)
Jan 24 2019, 5:25 PM
arrowd closed D15565: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer).
Jan 24 2019, 5:25 PM · KDevelop
arrowd added a comment to D5447: Only add auto-detected compilers to model if they actually exist.

the path of the compiler is now always the path of the compiler in the local host, which breaks when you have a runtime with a different setup.

Jan 24 2019, 4:38 PM

Jan 23 2019

arrowd requested review of D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..
Jan 23 2019, 6:33 AM · KDevelop

Jan 19 2019

arrowd added a comment to D18296: Add support for passing cursor information via URL parameters when running kioclient exec..

Ping? Any chance to get this into 5.15?

Jan 19 2019, 8:29 AM · Plasma

Jan 16 2019

arrowd requested review of D18296: Add support for passing cursor information via URL parameters when running kioclient exec..
Jan 16 2019, 1:59 PM · Plasma

Jan 15 2019

arrowd abandoned D17938: Add support for passing cursor information to KRun..

Right.

Jan 15 2019, 4:21 PM · Frameworks
arrowd committed R40:1fa3a0e85e71: Add ability to get cursor data from URL query arguments, like file://foo.txt? (authored by arrowd).
Add ability to get cursor data from URL query arguments, like file://foo.txt?
Jan 15 2019, 11:17 AM
arrowd closed D18099: Add ability to get cursor data from URL query arguments, like file://foo.txt?line=123&column=456.
Jan 15 2019, 11:17 AM · Kate
arrowd added a comment to D18099: Add ability to get cursor data from URL query arguments, like file://foo.txt?line=123&column=456.

Can I push this?

Jan 15 2019, 7:07 AM · Kate

Jan 14 2019

arrowd added a comment to D5447: Only add auto-detected compilers to model if they actually exist.
In D5447#393144, @apol wrote:

Let's look at this the other way around, what are you trying to fix?

Jan 14 2019, 6:51 PM
arrowd accepted D18216: Scratchpad: Validate actions when opening context menu.

Works great now, thanks!

Jan 14 2019, 7:06 AM · KDevelop

Jan 12 2019

arrowd committed R59:de4ebe3cc162: Fix "unused parameter/variable" warnings. Cleanup whitespace. Original patch by… (authored by arrowd).
Fix "unused parameter/variable" warnings. Cleanup whitespace. Original patch by…
Jan 12 2019, 6:47 PM
arrowd committed R59:311ac83d93ff: Fix unused parameters warnings (authored by arrowd).
Fix unused parameters warnings
Jan 12 2019, 6:47 PM
arrowd closed D10115: Fix unused parameters warnings.
Jan 12 2019, 6:47 PM
arrowd added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I found the following minor issue:

When I just started KDevelop and open "Scratchpad" toolview, any action except "New Scratch" are greyed out. Even "Remove Scratch", as well as "Run Scratch". When I open any scratch, it turns back to normal, even if I again close all Sratchpad windows.

That's intended. The actions are all associated with the selected scratch in the toolview list. Switching the window to a different scratch also changes this selection, while closing a window keeps the selection.

Jan 12 2019, 2:17 PM · KDevelop
arrowd added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

But that's not related to your change, so please push it. Not sure where to, 5.3, I guess.

Jan 12 2019, 8:54 AM · KDevelop
arrowd added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I found the following minor issue:

Jan 12 2019, 8:50 AM · KDevelop
arrowd added inline comments to D5447: Only add auto-detected compilers to model if they actually exist.
Jan 12 2019, 8:27 AM
arrowd updated the diff for D5447: Only add auto-detected compilers to model if they actually exist.

Restore another check.

Jan 12 2019, 8:26 AM

Jan 11 2019

arrowd added a comment to D14391: Fix random order of plugin's config pages.

The problem with current revision is that pages added in uicontroller.cpp:530 aren't sorted.

Jan 11 2019, 1:23 PM · KDevelop

Jan 10 2019

arrowd updated the diff for D14391: Fix random order of plugin's config pages.

Fix docs, rename append* methods to add*.

Jan 10 2019, 3:02 PM · KDevelop
arrowd updated the diff for D14391: Fix random order of plugin's config pages.

Remove insert API and use append everywhere.

Jan 10 2019, 2:35 PM · KDevelop