Port keystates to use QtWayland's generator
Needs ReviewPublic

Authored by apol on Jul 10 2019, 1:19 AM.


Group Reviewers

Saves us some of the boilerplate code

Test Plan

The plasmoid still works

Diff Detail

R127 KWayland
Lint SkippedExcuse: x
No Unit Test Coverage
Build Status
Buildable 13791
Build 13809: arc lint + arc unit
apol created this revision.Jul 10 2019, 1:19 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 10 2019, 1:19 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jul 10 2019, 1:19 AM
apol updated this revision to Diff 61478.Jul 10 2019, 1:21 AM


apol added a comment.Jul 10 2019, 1:22 AM

As discussed in the Plasma sprint.
Removes some boilerplate code and turns it into C++ overrides.

As some background:

At a recent Plasma sprint, one comment was that adding protocols to KWayland was an absolute pain involving writing a tonne of boiler plate. My experience adding a protocol to Qt was relatively painless.

We said we'd try on a really simple protocol.

IMHO this looks encouraging.

Obviously having a mix of styles isn't great, but something has to be first.

One thing we need to resolve is

will call init which will call wl_global_create

Global::Private will call wl_global_create

Calling that twice is wrong.