Create Task
Maniphest T8611

Support dbus-broker
Closed, ResolvedPublic
Actions

Description

dbus-broker is part of the Bus1 project and is slated to replace the reference implementation of dbus-daemon in a number of distributions by the next distribution release cycle (eg, Fedora 29). dbus-broker aims to be a conforming implementation of the DBus standard, but drops everything marked DEPRECATED in the standard and a few other features not explicitly part of the standard. More details here: https://github.com/bus1/dbus-broker/wiki/Deviations

One known change that affects KDE Connect is deprecation of "eavesdropping" via org.freedesktop.DBus.AddMatch() in favour of org.freedesktop.DBus.Monitoring.BecomeMonitor(). This is a relatively easy fix, but has some differing requirements to AddMatch(). BecomeMonitor() must be called on a dedicated DBus connection, and the exported interface method Notify() (used to eavesdrop and proxy libnotify notifications) must be exported on that connection. The match string itself can stay the same, but exclude the eavesdrop=true parameter.

More information here: https://dbus.freedesktop.org/doc/dbus-specification.html#bus-messages-become-monitor

apol added a subscriber: apol.May 2 2018, 1:04 PM

Looks reasonable. Could you turn this into a patch so it can be properly reviewed?

andyholmes added a comment.May 7 2018, 7:59 AM

I'm a bit backed up with some other projects to jump into phabricator and Qt (both new to me) at the moment, but I'll try and get to this when I can since I've at least implemented it in GSConnect. There's probably a fair amount of time to deal with this anyways (at least another release cycle), but anyone else can obviously take it if bug reports start getting filed and I haven't come back to it.

nicolasfella moved this task from Ideas to Junior Jobs on the KDE Connect board.May 10 2018, 4:44 PM
andyholmes updated the task description. (Show Details)Oct 15 2018, 8:58 PM
andyholmes updated the task description. (Show Details)
andyholmes added a comment.Oct 15 2018, 9:00 PM

I've removed the part about systemd as that was incorrect. All that needs to be done is to port to BecomeMonitor()

msethi added a subscriber: msethi.Jan 29 2020, 3:47 PM

Hey I could start working on this

andyholmes assigned this task to msethi.Feb 21 2020, 2:56 AM
cubix added a subscriber: cubix.Sep 13 2020, 6:10 AM

Hi I would like to work on this.

apol reassigned this task from msethi to cubix.Sep 13 2020, 11:03 PM

@cubix tell us if you don't know where to start from or if you have any questions. :)

shreyanshyad added a subscriber: shreyanshyad.Nov 10 2020, 1:13 AM

Hi, I would like to work on this if it's up for taking.

apol added a comment.Nov 10 2020, 3:02 AM

Like we said to the last few, feel free to work on it. I haven't seen much activity happen around the topic. Maybe you would like to explain how you'd like to start working on it?