configmodule: Make sure the kcm information is loaded when the qml is created
Needs ReviewPublic

Authored by apol on Wed, Jan 8, 3:21 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Frameworks
Summary

Otherwise we'll initialize with dumb values and refresh it when shown, which
isn't all that effective.

Test Plan

Tested against the feedback kcm

Diff Detail

Repository
R296 KDeclarative
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20806
Build 20824: arc lint + arc unit
apol created this revision.Wed, Jan 8, 3:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptWed, Jan 8, 3:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Wed, Jan 8, 3:21 PM

I kinda see what you're saying, I don't understand why we currently do anything on showEvent()

But now we're going to call load() twice, which doesn't sound very optimal.

mart added a subscriber: mart.Thu, Jan 9, 3:46 PM

that depends how heavy the load() implementation is...

both ways are not optimal..
this behavior comes from KCModule, where the module nevel loads itself and a load() must be called from outside.

here may be worth doing that even if it's two loads as would avoid a binding reevaluation. othe the other hand.. a config read more, hmmm