Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS
AbandonedPublic

Authored by apol on Sat, Aug 1, 10:12 AM.

Details

Reviewers
jgrulich
enriquem
Summary

Methods are added to NetworkManager::SecretAgent to allow passing a capabilities argument. This is intended for plasma-nm to pass flag NM_SECRET_AGENT_CAPABILITY_VPN_HINTS in the registration process. Later, changes will have to be made to plasma-nm and the VPN plugins to use this new methods and pass hints from SecretAgent::GetSecrets() to VPN plugins.

Partial development so solve https://bugs.kde.org/show_bug.cgi?id=424678

Diff Detail

Repository
R282 NetworkManagerQt
Lint
Lint Skipped
Unit
Unit Tests Skipped
enriquem created this revision.Sat, Aug 1, 10:12 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSat, Aug 1, 10:12 AM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
enriquem requested review of this revision.Sat, Aug 1, 10:12 AM
apol added a subscriber: apol.Sun, Aug 2, 12:22 AM

We have moved to gitlab, now patches should be uploaded here: https://invent.kde.org/frameworks/networkmanager-qt

Sorry for the change (@jgrulich can still review it, but it's better to have everything in the new infrastructure).

The patch itself looks okay to me.

ngraham added a subscriber: ngraham.Sun, Aug 2, 3:20 PM

I did too, but time marches on. :)

You can Abandon this patch now.