Use deprecated variables as fallback if defined

works for me, calligraplan builds fine after this change!

In D23202#513068, @vkrause wrote:

see https://cgit.kde.org/kcalcore.git/tree/src/CMakeLists.txt#n138 - seems to work here

In D23202#513056, @vkrause wrote:

This isn't wrong, but I'm surprised it's needed, we explicitly install headers in the old location too, for compatibility?

drop translations, rename to 'Plasma on Xorg'

FWIW, Gnome appear to be calling theirs 'Gnome on Xorg' (and likewise, just 'Gnome' for the wayland session).

I'll have to do this downstream, anyway...

update README.md

Okay then... I do have commit access, fyi.

In D22164#492330, @sitter wrote:

Currently debating throwing out Qt4 altogether.

Well, what's the current situation - SDDM have made the decision on their part to append that tech-garbage for Wayland sessions, users end up with:

• Plasma
• Plasma (Wayland)

As a distro packager, in no way would I already build this one without explicitly setting the option already. Of course, it should end up in the changelog.

In D19011#480868, @ngraham wrote:

and we should lobby distros to ship with the new repo/package.

This should probably also be posted on release-team ML.

Drop X11 cruft as well

At least with ICU 63 there is no problem with the change, I can't test with older versions. The same thing had to be also done for xmlsec, for reference: https://github.com/lsh123/xmlsec/pull/249

In D21148#464674, @ngraham wrote:

Does this break anything for the older exiv releases?

I guess this can be closed?

Review submitted: https://phabricator.kde.org/D21011

In D20229#460647, @elvisangelaccio wrote:

@asturmlechner Is Spectacle also affected then? This cmake code was copied from there.

This fix just got sent my way:

In D20229#459294, @ngraham wrote:

Hmm, can you help me understand why this change breaks in a sandboxed environment?

In D20713#456355, @aacid wrote:

It compiles here (including vkontakte)

TBH i don't know enough about the logic behind all the code your changing

Thanks for testing. The commits really do only what they tell, to make it look more like a regular kde-apps project. 'New' lines in CMakeLists.txt are only those parts copied (not otherwise changed) from DETECT_* macros that are relevant to kipi-plugins standalone building, all the other stuff was for building it as part of some 'Digikam SC' bundle.

In D20239#443172, @apol wrote:

This patch should go to the stable branch too.

Hm, any reason why this is still pending?

Builds fine for me!