Enable PHONON_BUILD_PHONON4QT5 by default
AbandonedPublic

Authored by sitter on Jun 30 2019, 12:46 PM.

Details

Reviewers
bernieinnocenti
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This drops the last remaining dependency on Qt4 in default kdesrc-build builds.

Test Plan

kdesrc-build phonon

Diff Detail

Repository
R487 Phonon
Branch
noqt4 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13455
Build 13473: arc lint + arc unit
Owners added a reviewer: Restricted Owners Package.Jun 30 2019, 12:46 PM
bernieinnocenti requested review of this revision.Jun 30 2019, 12:46 PM

Use my personal email for KDE commits

Actually amend the committer email this time

Also reset the author's email

Sorry for the noise, this is my first time using git through
Phabricator's arc cli command.

ognarb added a reviewer: sitter.EditedJun 30 2019, 3:39 PM
ognarb added a subscriber: ognarb.
NOTE: I think this change can be usefull, but the doc need to be also updated https://api.kde.org/phonon/html/phonon4qt5.html and the distros need to know about this change. https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=phonon-qt4

As a distro packager, in no way would I already build this one without explicitly setting the option already. Of course, it should end up in the changelog.

Update documentation to reflect the change in PHONON_BUILD_PHONON4QT5's default

What's the next step? Should @sitter review and ack / nak?

sitter added a comment.Jul 8 2019, 1:55 PM

Currently debating throwing out Qt4 altogether.

Currently debating throwing out Qt4 altogether.

Ah, great. Last week I was wondering why it's still there: https://mstdn.io/web/statuses/102365500412259826

Currently debating throwing out Qt4 altogether.

count me in on that ;)

sitter commandeered this revision.Jul 29 2019, 1:07 PM
sitter abandoned this revision.
sitter edited reviewers, added: bernieinnocenti; removed: sitter.