Fix plugins/qpa build with Qt 5.13
ClosedPublic

Authored by asturmlechner on Apr 3 2019, 10:39 PM.

Details

Summary

Upstream moved screen maintenance functions from
QPlatformIntegration to QWSI.

BUG: 406056
See also: https://code.qt.io/cgit/qt/qtbase.git/commit/?h=5.13&id=01e1df90

Test Plan

Built fine with Qt 5.12.2 and Qt 5.13 stable branch.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 10423
Build 10441: arc lint + arc unit
asturmlechner created this revision.Apr 3 2019, 10:39 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 3 2019, 10:39 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
asturmlechner requested review of this revision.Apr 3 2019, 10:39 PM
asturmlechner added a subscriber: arojas.
zzag accepted this revision.Apr 3 2019, 11:12 PM
zzag added a subscriber: zzag.

Thank you for fixing it

This revision is now accepted and ready to land.Apr 3 2019, 11:12 PM
asturmlechner closed this revision.Apr 3 2019, 11:18 PM

This patch should go to the stable branch too.
We will also somehow have to notify distros that kwin needs to be recompiled when they switch Qt versions there. @jriddell maybe it can be part of the release notes somehow?

arojas added a comment.Apr 4 2019, 6:29 AM
In D20239#443172, @apol wrote:

We will also somehow have to notify distros that kwin needs to be recompiled when they switch Qt versions there. @jriddell maybe it can be part of the release notes somehow?

Note that kwin always needs to be recompiled for new minor Qt version since it uses private API, so this is nothing new for packagers.

In D20239#443172, @apol wrote:

This patch should go to the stable branch too.

No problem for me to pick this for 5.15 branch, if you are sure.