Fix build with exiv2-0.27.1
ClosedPublic

Authored by asturmlechner on May 12 2019, 6:47 AM.

Details

Summary

Upstream is moving things around between headers. While they are busy doing that, they recommend including exiv2.hpp.

lib/imagemetainfomodel.cpp:293:40: error: expected unqualified-id before ‘&’ token
             } catch (const Exiv2::Error& error) {
                                        ^

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asturmlechner created this revision.May 12 2019, 6:47 AM
Restricted Application added a project: Gwenview. · View Herald TranscriptMay 12 2019, 6:47 AM
asturmlechner requested review of this revision.May 12 2019, 6:47 AM
asturmlechner edited the summary of this revision. (Show Details)May 12 2019, 6:48 AM

Does this break anything for the older exiv releases?

Does this break anything for the older exiv releases?

No, it will work just fine. Most exiv2-0.27 fixes I made in other packages already use the exiv2.hpp catchall header.

ngraham accepted this revision.May 15 2019, 8:32 PM
This revision is now accepted and ready to land.May 15 2019, 8:32 PM
This revision was automatically updated to reflect the committed changes.