- Raise KF5_MIN_VERSION to 5.18.0 and use for ECM
- Simplify optional Qt5/KF5 deps, drop ENABLE_KIO
- Drop use of DETECT_LIBKIPI macro and move relevant part to CMakeLists.txt
- Drop use of DETECT_LIBMEDIAWIKI
- Drop use of DETECT_LIBKVKONTAKTE
- cmake: Remove MacroLocalLibs.cmake module
- Use FeatureSummary instead of local MacroUtils.cmake
- cmake: Remove unused MacroUtils.cmake module
Details
Details
- Reviewers
jriddell aacid - Commits
- R480:60c8a15e726f: cmake: Remove unused MacroUtils.cmake module
Built successfully against KF5MediaWiki and KF5KIO, could not test KF5Vkontakte
Diff Detail
Diff Detail
- Repository
- R480 Kipi Plugins
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
It compiles here (including vkontakte)
TBH i don't know enough about the logic behind all the code your changing to comment, so take this as a +0.5 i guess, at some point if you're bored of waiting and sure this is fine or commit to fix whatever this breaks i'd say you can commit
Comment Actions
Thanks for testing. The commits really do only what they tell, to make it look more like a regular kde-apps project. 'New' lines in CMakeLists.txt are only those parts copied (not otherwise changed) from DETECT_* macros that are relevant to kipi-plugins standalone building, all the other stuff was for building it as part of some 'Digikam SC' bundle.