Differential D14967

Disable loading of translations for kformattest, which was not designed with translations
Needs ReviewPublic
Actions

Authored by habacker on Aug 21 2018, 8:07 AM.

Details

Reviewers
dfaure
aacid
Summary

Required reviews: D14940 D14966

Review Request: https://phabricator.kde.org/D14779

Test Plan

compiled and checked with kformattest on linux and windows using cross compiled build

Diff Detail

Repository
R244 KCoreAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2061
Build 2079: arc lint + arc unit
habacker created this revision.Aug 21 2018, 8:07 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 21 2018, 8:07 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
habacker requested review of this revision.Aug 21 2018, 8:07 AM
aacid added a comment.Aug 21 2018, 10:26 PM

I personally don't think this is the way to go and as said many times think that loading a custom translation for tests like ki18n way does is the way to go.

Your issue with that seems to be that it won't work on windows, well then i'd say skip the test on windows until Qt gets better at it.

But if someone else approves i'm not going to block on it.

asturmlechner added a subscriber: asturmlechner.Feb 16 2021, 4:11 PM

Hm, I find myself disabling ever more tests because I get a report like kformattest when someone has translations installed. How does CI get over that?

dfaure added a comment.Feb 18 2021, 10:59 PM

CI runs things in a sandbox, there are no translations installed that are accessible to kf5 tests.

Revision Contents
Changeset List

PathPackages
Mautotests/kformattest.cpp (9 lines)
Msrc/lib/CMakeLists.txt (2 lines)

Diff 40119

View Options

autotests/kformattest.cpp

Loading...
View Options

src/lib/CMakeLists.txt

Loading...