Since version 5.69, KBookmarkMenu doesn't automatically create an action
collection. This causes Konqueror to crash when going on a submenu in
the Bookmarks menu. To avoid it, manually create the action collection.
Also, avoid calling the version of KBookmarkMenu construction which
takes a KActionCollection, as it's deprecated.
Open the bookmarks menu and hover with the mouse on a submenu. Check
that it crashes. Do the same after this change and check it doesn't crash
anymore.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I guarded all the m_actionCollection usage in kbookmarksmenu.cpp with checks, but didn't check konqbookmarksmenu, sorry.
Given that making KActionCollection optional is not a concern for Konqueror I think this fix is fine
Well, the problem is that this means the KBookmarks change broke the "behaviour compatibility" promise.
Most likely one or many of the other users of KBookmarkMenu are affected as well, see https://lxr.kde.org/ident?_i=KBookmarkMenu&_remember=1
Shouldn't KBookmarkMenu keep setting m_actionCollection when used "like before", and only do things different when called with a new constructor / flag?
There was also (apparently related) crash in KJots, see D28775: [KJots] Fix bookmarks actions.
Of course, but I'm not sure how to do that (it's the first time I need to push to somewhere different from master). Since I don't want to risk making a mess because of some mistake, could you please tell me how to do it? Thanks
Backported: https://commits.kde.org/konqueror/d6e3f653d265acad006ce65455b557b2fb58f251
But this commit doesn't fix a crash, does it? (the crash was when nobody was creating the action collection, iirc)