The Bookmarks menu is still added as expected and the actions still show
in the configure shortcuts dialog. I couldn't test actually creating a
bookmark as I have no access to remote servers.
Details
Details
Diff Detail
Diff Detail
- Repository
- R436 KRDC
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Was the API change actually required to fix a bug? I don't see an "Edit Bookmarks..." menu item in KCharSelect, Dolphin, or Konqueror (see bug 418666) and I guess that any other user of that API suddenly got broken, which seem against our API stability promises.
Comment Actions
The API change was in D25660, basically removing the KActionCollection dep (and hence KXMLGui) from KBookmarks.
AFAIK you need to have keditbookmarks installed for the "Edit Bookmarks" menu action to show at all. I don't know where exactly that condition exists in the code, but I know that while testing yesterday I had to install keditbookmarks :). I'll update the bug report.
Comment Actions
Based on D28789, this is OK IIUC, so I've just cherry-pick'ed this to release/20.04 (I hope that's OK).