AmarokProject
ActivePublic

Recent Activity

Sun, May 31

adridg closed D26008: Include the gmock prefix in the search path.
Sun, May 31, 4:02 PM · Amarok

May 2 2020

pipo moved T7463: Integrate bpm-tools into Amarok from Abandoned to Todo on the Amarok board.
May 2 2020, 3:03 AM · Amarok
pipo moved T2699: Documentation update from Abandoned to Todo on the Amarok board.
May 2 2020, 3:03 AM · Amarok
pipo moved T8078: Port away from libmysqld (embedded server) from Needs review to Todo on the Amarok board.
May 2 2020, 3:02 AM · Amarok
pipo moved T8119: fix crash when some external APIs fail from Needs review to Todo on the Amarok board.
May 2 2020, 3:02 AM · Amarok
pipo moved T2700: Create a tool for inspecting collection scanner results from Abandoned to Todo on the Amarok board.
May 2 2020, 3:02 AM · Amarok
pipo moved T8078: Port away from libmysqld (embedded server) from Tests needed to Needs review on the Amarok board.
May 2 2020, 3:02 AM · Amarok
pipo moved T8078: Port away from libmysqld (embedded server) from Abandoned to Tests needed on the Amarok board.
May 2 2020, 3:02 AM · Amarok
pipo moved T8119: fix crash when some external APIs fail from Abandoned to Needs review on the Amarok board.
May 2 2020, 3:02 AM · Amarok
pipo moved T2699: Documentation update from Todo to Abandoned on the Amarok board.
May 2 2020, 3:01 AM · Amarok
pipo moved T2700: Create a tool for inspecting collection scanner results from Todo to Abandoned on the Amarok board.
May 2 2020, 3:01 AM · Amarok
pipo moved T7463: Integrate bpm-tools into Amarok from Todo to Abandoned on the Amarok board.
May 2 2020, 3:01 AM · Amarok
pipo moved T8078: Port away from libmysqld (embedded server) from Todo to Abandoned on the Amarok board.
May 2 2020, 3:01 AM · Amarok
pipo moved T8119: fix crash when some external APIs fail from Todo to Abandoned on the Amarok board.
May 2 2020, 3:01 AM · Amarok

Apr 14 2020

Restricted Application added a project to D26008: Include the gmock prefix in the search path: Amarok.

e17a38b179197d9afa303de6e254fbc284c5fa9e did something similar, I suppose this can be closed?

Apr 14 2020, 7:58 PM · Amarok

Apr 12 2020

mdn added a watcher for Amarok: mdn.
Apr 12 2020, 7:52 PM

Apr 11 2020

pgomes closed D27949: Conclude porting of Last.fm to Amarok KF5.
Apr 11 2020, 3:24 PM · Amarok
pgomes added inline comments to D28593: Fix copying and moving files to collection.
Apr 11 2020, 3:13 PM · Qt 5 Porting, Amarok
pgomes added a comment to D28593: Fix copying and moving files to collection.

Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716

Apr 11 2020, 3:11 PM · Qt 5 Porting, Amarok
pgomes closed D28593: Fix copying and moving files to collection.
Apr 11 2020, 3:10 PM · Qt 5 Porting, Amarok
heikobecker added a comment to D28593: Fix copying and moving files to collection.

Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716

Apr 11 2020, 11:03 AM · Qt 5 Porting, Amarok
heikobecker accepted D28593: Fix copying and moving files to collection.
Apr 11 2020, 11:00 AM · Qt 5 Porting, Amarok
heikobecker accepted D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Apr 11 2020, 10:31 AM · Amarok
heikobecker accepted D27949: Conclude porting of Last.fm to Amarok KF5.
Apr 11 2020, 10:04 AM · Amarok

Apr 5 2020

pgomes requested review of D28593: Fix copying and moving files to collection.
Apr 5 2020, 1:30 PM · Qt 5 Porting, Amarok

Mar 31 2020

pgomes added a comment to D27949: Conclude porting of Last.fm to Amarok KF5.

Fixed generation of export header

Mar 31 2020, 2:33 PM · Amarok
pgomes updated the diff for D27949: Conclude porting of Last.fm to Amarok KF5.
  • Fix generation and usage of export headers
Mar 31 2020, 2:30 PM · Amarok
pgomes added inline comments to D27949: Conclude porting of Last.fm to Amarok KF5.
Mar 31 2020, 10:22 AM · Amarok

Mar 26 2020

heikobecker closed D28165: Fix compatibility with modern MySQL.
Mar 26 2020, 8:37 PM · Amarok

Mar 25 2020

asturmlechner updated the diff for D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

re-add accidentally removed required includes to FindMySQLe.cmake

Mar 25 2020, 8:06 PM · Amarok
wbauer added a comment to D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Mar 25 2020, 7:29 PM · Amarok
wbauer added a comment to D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

On openSUSE, it doesn't enable MySQLe anymore:

Mar 25 2020, 7:23 PM · Amarok
jfowkes removed a watcher for Amarok: jfowkes.
Mar 25 2020, 6:48 PM
asturmlechner updated the summary of D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Mar 25 2020, 6:39 PM · Amarok
asturmlechner updated the diff for D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

updated for the case when mysqle is shipped with mariadb

Mar 25 2020, 6:36 PM · Amarok
wbauer added a comment to D28165: Fix compatibility with modern MySQL.

The content of my /usr/include/mysql/mysql_version.h (which is just a symlink to mariadb_version.h):

I just went back and installed mariadb-connector-c in Gentoo in mysqlcompat-mode (a soon to be removed option) and interestingly, it does not provide that symlink.

Indeed, the symlink is added in openSUSE's packaging. From mariadb-connector-c.spec:

# add a compatibility symlink
ln -s mariadb_config %{buildroot}%{_bindir}/mysql_config
ln -s mariadb_version.h %{buildroot}%{_includedir}/mysql/mysql_version.h
Mar 25 2020, 6:23 PM · Amarok
vmatare added a comment to D28165: Fix compatibility with modern MySQL.

I assume you don't have commit access and you'll need somebody to push this patch for you, right?

Yes, please go ahead if you think this has been tested well enough.

Mar 25 2020, 6:17 PM · Amarok
wbauer added a comment to D28165: Fix compatibility with modern MySQL.

Waiting for @wbauer to confirm it works as well

Yes, the latest version builds fine here (the previous did as well), and the embedded collection still works as well.

Mar 25 2020, 6:09 PM · Amarok
Restricted Application added a project to D24817: Restore scripting functionalities and Qt bindings.: Amarok.
Mar 25 2020, 6:05 PM · Amarok
asturmlechner added a comment to D27949: Conclude porting of Last.fm to Amarok KF5.

scrobble it does 👍

Mar 25 2020, 4:34 PM · Amarok
heikobecker added inline comments to D27949: Conclude porting of Last.fm to Amarok KF5.
Mar 25 2020, 4:12 PM · Amarok
asturmlechner requested review of D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Mar 25 2020, 3:43 PM · Amarok
heikobecker accepted D28165: Fix compatibility with modern MySQL.

Builds fine here with mariadb and WITH_MYSQL_EMBEDDED=TRUE.

Mar 25 2020, 3:36 PM · Amarok
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

Waiting for @wbauer to confirm it works as well - btw, does openSUSE still provide mysqle to test -DWITH_MYSQL_EMBEDDED=on?

Mar 25 2020, 3:19 PM · Amarok
asturmlechner accepted D28165: Fix compatibility with modern MySQL.

Please test again, and thanks a lot for the review so far.

Mar 25 2020, 11:52 AM · Amarok
vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

Another attempt at a simple solution that works with all versions of MariaDB and MySQL. This one comes with the added cost of including the full mysql.h because that seems to be the only consistently supplied drop-in header by MariaDB. Other solutions would involve additional CMake hackery to distinguish between MariaDB and MySQL, but for the sake of sanity, let's sacrifice compilation time for simplicity here.

Mar 25 2020, 2:49 AM · Amarok
vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

indent with 4 spaces in cmake

Mar 25 2020, 2:19 AM · Amarok
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

The content of my /usr/include/mysql/mysql_version.h (which is just a symlink to mariadb_version.h):

Mar 25 2020, 1:15 AM · Amarok

Mar 24 2020

asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

Confirming successful build here as well.

Mar 24 2020, 2:48 PM · Amarok
jfowkes added a comment to D28165: Fix compatibility with modern MySQL.

Thanks for the very nice patch! Compiles and works for me on Gentoo (MySQL Connector/C 8.0.19).

Mar 24 2020, 8:47 AM · Amarok