Conclude porting of to Amarok KF5

Authored by pgomes on Mar 9 2020, 4:02 PM.



Restores service to Amarok with the following changes:

  • restore's cmake task
  • add/replace deprecated defs to enable compilation
  • fix authentication (method: auth.getMobileSession) to the current API version. Now it uses HTTPS and use liblastfm's signing function
  • remove references to "neighbours" since API method "user.getNeighbours" is deprecated
  • remove suggestion to join "Amarok Users" community from configuration dialog since no longer have communities

Diff Detail

R181 Amarok
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
pgomes requested review of this revision.Mar 9 2020, 4:02 PM
pgomes created this revision.
pgomes created this object with edit policy "Administrators".
pgomes edited the summary of this revision. (Show Details)
pgomes updated this revision to Diff 77890.Mar 18 2020, 9:51 AM

fix segfault when destroying LastfmService due to bad QSharedPointer usage

heikobecker added inline comments.

Any reason not to use a generated export header for that?

scrobble it does ๐Ÿ‘

pgomes added inline comments.Mar 31 2020, 10:22 AM

No strong reason.

The reason was that I didn't know what's the different between QT_DECL_EXPORT and the generated __attribute__((visibility("default"))).
Also Ampache and Gpodder do not generate exports, so I followed them. Should I use the attribute?

pgomes updated this revision to Diff 78991.Mar 31 2020, 2:30 PM
  • Fix generation and usage of export headers
pgomes marked 2 inline comments as done.Mar 31 2020, 2:33 PM

Fixed generation of export header

heikobecker accepted this revision as: heikobecker.Apr 11 2020, 10:04 AM
This revision is now accepted and ready to land.Apr 11 2020, 10:04 AM
This revision was automatically updated to reflect the committed changes.