Conclude porting of Last.fm to Amarok KF5
ClosedPublic
Actions

Authored by pgomes on Mar 9 2020, 4:02 PM.

Details

Reviewers

amarok-devel
heikobecker

Group Reviewers

Amarok

Commits

R181:abca65432fce: Conclude porting of Last.fm to Amarok KF5

Summary

Restores Last.fm service to Amarok with the following changes:

restore Last.fm's cmake task
add/replace deprecated defs to enable compilation
fix authentication (method: auth.getMobileSession) to the current API version. Now it uses HTTPS and use liblastfm's signing function
remove references to "neighbours" since API method "user.getNeighbours" is deprecated
remove suggestion to join "Amarok Users" community from configuration dialog since Last.fm no longer have communities

Repository

R181 Amarok

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

pgomes requested review of this revision.Mar 9 2020, 4:02 PM

pgomes created this revision.

pgomes created this object with edit policy "Administrators".

pgomes edited the summary of this revision. (Show Details)

fix segfault when destroying LastfmService due to bad QSharedPointer usage

heikobecker added inline comments.

src/services/lastfm/LastFmServiceConfig.h
37	Any reason not to use a generated export header for that?

scrobble it does 👍

src/services/lastfm/LastFmServiceConfig.h
37	No strong reason. The reason was that I didn't know what's the different between `QT_DECL_EXPORT` and the generated `__attribute__((visibility("default")))`. Also Ampache and Gpodder do not generate exports, so I followed them. Should I use the attribute?

Fixed generation of export header

This revision is now accepted and ready to land.Apr 11 2020, 10:04 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/services/CMakeLists.txt (2 lines)
M			src/services/lastfm/AvatarDownloader.cpp (3 lines)
M			src/services/lastfm/LastFmConfigWidget.ui (59 lines)
M			src/services/lastfm/LastFmService.cpp (21 lines)
M			src/services/lastfm/LastFmServiceCollection.h (4 lines)
M			src/services/lastfm/LastFmServiceCollection.cpp (114 lines)
M			src/services/lastfm/LastFmServiceConfig.h (4 lines)
M			src/services/lastfm/LastFmServiceSettings.h (2 lines)
M			src/services/lastfm/LastFmServiceSettings.cpp (20 lines)
M			src/services/lastfm/LastFmTreeModel.h (15 lines)
M			src/services/lastfm/LastFmTreeModel.cpp (94 lines)
M			src/services/lastfm/LastFmTreeView.cpp (3 lines)
M			src/services/lastfm/meta/LastFmMultiPlayableCapability.h (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	77290			Mar 9 2020, 3:50 PM	★	★
Diff 2	77890			Mar 18 2020, 9:50 AM	★	★
Diff 3	78991			Mar 31 2020, 2:25 PM	★	★
Diff 4	79869	96eaac4	R181:abca65432fceda41de05eb8a80b701de2d77498e	Apr 11 2020, 3:18 PM	★	★