Fix DESTDIR usage
Needs ReviewPublic

Authored by arojas on Tue, Feb 11, 6:46 PM.

Details

Reviewers
asturmlechner
lbeltrame
fvogt
Group Reviewers
KDE Games
Summary

kajongg's build system uses DESTDIR during cmake to construct the command that creates the kajongg and kajonggserver symlinks in bindir. This is a problem for distributions, which usually have separated ckame/make/make install stages with DESTDIR only available in the later one. So distros are currently working around this in different ways, either creating the symlinks manually after make install (Gentoo, Fedora) or defining DESTDIR before running cmake (Arch, Opensuse).
This patch changes the symlink installation process to only make the DESTDIR substitution during make install.

Test Plan

cmake && make && make DESTDIR=foo install, symlinks are correctly created inside foo.

Diff Detail

Repository
R387 Kajongg
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas created this revision.Tue, Feb 11, 6:46 PM
Restricted Application added a subscriber: kde-games-devel. ยท View Herald TranscriptTue, Feb 11, 6:46 PM
arojas requested review of this revision.Tue, Feb 11, 6:46 PM