sandsmark (Martin Tobias Holmedahl Sandsmark)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2015, 5:16 PM (184 w, 9 h)
Availability
Available

Recent Activity

Thu, Dec 13

sandsmark updated subscribers of D17266: Use DECSCUSR 0 to reset to default.
Thu, Dec 13, 10:51 AM · Konsole
sandsmark updated subscribers of D17293: Add warning when pasting unprintable chars and ask to filter them out.
Thu, Dec 13, 10:51 AM · Konsole

Fri, Dec 7

sandsmark added a comment to D17414: fix cursor when anti aliasing is enabled.

i. e. there is a _margin of 1 pixel, but some of the antialiasing "blur" leaks to 0,0. so it is fixed with a full update() (e. g. when it regains focus), but not when just some content updates in the window.

Fri, Dec 7, 8:13 PM · Konsole
sandsmark requested review of D17414: fix cursor when anti aliasing is enabled.
Fri, Dec 7, 8:11 PM · Konsole
sandsmark updated the diff for D17294: Add special support for block characters.

Fixed the bound, added some comments

Fri, Dec 7, 5:44 PM · Konsole

Tue, Dec 4

sandsmark committed R494:27f53f7fbd69: port to qregularexpression (authored by sandsmark).
port to qregularexpression
Tue, Dec 4, 6:43 PM
sandsmark committed R494:f79bb13cfab2: port limitedcharlineedit to qregularexpression (authored by sandsmark).
port limitedcharlineedit to qregularexpression
Tue, Dec 4, 6:43 PM
sandsmark committed R494:8c2eb7b8b74b: remove unused class (authored by sandsmark).
remove unused class
Tue, Dec 4, 6:43 PM
sandsmark committed R494:f59162987afa: drop unnecessary dependency on kwidgetaddons (authored by sandsmark).
drop unnecessary dependency on kwidgetaddons
Tue, Dec 4, 6:43 PM
sandsmark committed R494:ce02030b799d: avoid roundtrip into khelpclient when we already know the URLs we want to get… (authored by sandsmark).
avoid roundtrip into khelpclient when we already know the URLs we want to get…
Tue, Dec 4, 6:43 PM
sandsmark committed R494:96567b03efe1: make the ktextwidgets dependency optional (authored by sandsmark).
make the ktextwidgets dependency optional
Tue, Dec 4, 6:43 PM
sandsmark committed R494:e07a207ee190: some cleanup (authored by sandsmark).
some cleanup
Tue, Dec 4, 6:43 PM
sandsmark committed R494:e4808c9de915: remove unnecessary dependencies (authored by sandsmark).
remove unnecessary dependencies
Tue, Dec 4, 6:43 PM
sandsmark updated the diff for D16947: fix drawing box chars, avoid storing and saving state all the time.

fix format for phabricator

Tue, Dec 4, 4:02 PM · Konsole
sandsmark updated the diff for D17264: Fix crash when changing from blinking cursor to block cursor.

fix format for phabricator

Tue, Dec 4, 4:01 PM · Konsole
sandsmark updated the diff for D17266: Use DECSCUSR 0 to reset to default.

fix format of patch for phabricator

Tue, Dec 4, 4:00 PM · Konsole
sandsmark updated the diff for D17293: Add warning when pasting unprintable chars and ask to filter them out.

fix patch format for phabricator

Tue, Dec 4, 4:00 PM · Konsole
sandsmark updated the diff for D17294: Add special support for block characters.

fix format of patch for phabricator

Tue, Dec 4, 3:59 PM · Konsole

Sun, Dec 2

sandsmark requested review of D17294: Add special support for block characters.
Sun, Dec 2, 4:42 AM · Konsole
sandsmark requested review of D17293: Add warning when pasting unprintable chars and ask to filter them out.
Sun, Dec 2, 4:38 AM · Konsole

Sat, Dec 1

sandsmark updated the diff for D16947: fix drawing box chars, avoid storing and saving state all the time.

fixed it

Sat, Dec 1, 10:55 PM · Konsole
sandsmark added a comment to D16947: fix drawing box chars, avoid storing and saving state all the time.

I tested a bit more, the problem is that drawArc and drawLine look very different with antialiasing on.

Sat, Dec 1, 10:02 PM · Konsole
sandsmark added a comment to D17266: Use DECSCUSR 0 to reset to default.

Yeah, the current way is fine, but I started using it in my own application, and I missed a way to just reset to the original state.

Sat, Dec 1, 9:49 PM · Konsole

Fri, Nov 30

sandsmark requested review of D17266: Use DECSCUSR 0 to reset to default.
Fri, Nov 30, 4:56 PM · Konsole
sandsmark requested review of D17264: Fix crash when changing from blinking cursor to block cursor.
Fri, Nov 30, 4:41 PM · Konsole
sandsmark added a comment to D16947: fix drawing box chars, avoid storing and saving state all the time.

so should I go ahead and push this patch?

Fri, Nov 30, 4:38 PM · Konsole

Nov 17 2018

sandsmark added a comment to D16947: fix drawing box chars, avoid storing and saving state all the time.

uhm, never mind this for now. I didn't notice that it actually just didn't draw any antialiasing on the corners. but I guess that also explains why the current antialiasing doesn't work very well.

Nov 17 2018, 10:10 AM · Konsole
sandsmark requested review of D16947: fix drawing box chars, avoid storing and saving state all the time.
Nov 17 2018, 10:07 AM · Konsole

Nov 3 2018

sandsmark committed R529:3e8fef5a386a: fix storing popularity match strings (authored by sandsmark).
fix storing popularity match strings
Nov 3 2018, 11:44 AM
sandsmark committed R529:4ed4c840686d: allow displaying errors from calculator (authored by sandsmark).
allow displaying errors from calculator
Nov 3 2018, 11:35 AM
sandsmark committed R529:fa11edd0f486: use locale appropriate formatting if it is easy (authored by sandsmark).
use locale appropriate formatting if it is easy
Nov 3 2018, 11:26 AM
sandsmark committed R529:c9450d707b11: put unit conversion result in normal clipboard (authored by sandsmark).
put unit conversion result in normal clipboard
Nov 3 2018, 11:26 AM
sandsmark committed R529:22410f8368a0: enable calculations in unit conversion (authored by sandsmark).
enable calculations in unit conversion
Nov 3 2018, 11:26 AM
sandsmark committed R529:c8ae778f3999: after david edmundson's patch in qt this shouldn't be necessary anymore (authored by sandsmark).
after david edmundson's patch in qt this shouldn't be necessary anymore
Nov 3 2018, 11:26 AM
sandsmark committed R529:11de131d817f: put calculator result in normal clipboard (authored by sandsmark).
put calculator result in normal clipboard
Nov 3 2018, 11:26 AM
sandsmark committed R529:1c1b2b25f43e: less indentation (authored by sandsmark).
less indentation
Nov 3 2018, 11:26 AM
sandsmark committed R529:2f88f55f3a73: limit decimals (authored by sandsmark).
limit decimals
Nov 3 2018, 11:26 AM

Oct 26 2018

sandsmark updated the diff for D16198: Add support for dimming the colors when losing focus.

rebased

Oct 26 2018, 11:28 AM · Konsole
sandsmark updated the diff for D16198: Add support for dimming the colors when losing focus.

fixed the prefixes so phabricator is happy

Oct 26 2018, 8:04 AM · Konsole
sandsmark updated the diff for D16227: Use correct color and font when exporting to HTML.

Added the prefixes to the diff, sorry for the delay.

Oct 26 2018, 8:00 AM · Konsole

Oct 18 2018

sandsmark added a comment to D16227: Use correct color and font when exporting to HTML.

it's probably because phabricator doesn't handle patches generated when I have diff.noprefix=true (which is very convenient when working on stuff), it seems to indiscriminately just strip the first path component. I'll upload a new version when I get home.

Oct 18 2018, 11:30 AM · Konsole

Oct 15 2018

sandsmark requested review of D16227: Use correct color and font when exporting to HTML.
Oct 15 2018, 4:53 PM · Konsole

Oct 14 2018

sandsmark updated the diff for D16198: Add support for dimming the colors when losing focus.

started using it on my system, and noticed that some colors didn't get dimmed, and those are the ones that aren't normal terminal colors from the color scheme... so instead just use a simpler solution by drawing a semi-transparent black rect on top.

Oct 14 2018, 6:11 PM · Konsole
sandsmark added a comment to D16198: Add support for dimming the colors when losing focus.

yeah, this is more when I can't use KWin or another compositor. I tested with a compositor now, and even with it turned on it didn't look as bad as I feared (not too dark, still readable).

Oct 14 2018, 6:10 PM · Konsole
sandsmark committed R319:5b470ff7242b: a bit simpler, and handles colors not in the color scheme as well (authored by sandsmark).
a bit simpler, and handles colors not in the color scheme as well
Oct 14 2018, 6:07 PM
sandsmark added a comment to D15915: Antialias line drawing characters.

I think it makes sense to revert to drawing the box chars without anti-aliasing. using the box chars in the font itself is supposed to be the right and pretty way, so I think it's a fair tradeoff to let the built-in box chars look a bit uglier but more correct. or something like that.

Oct 14 2018, 4:57 PM · Konsole
sandsmark requested changes to D16134: Secure history file.

just did a quite read-through, but hindenburg has the final say if he disagrees with any of my requests.

Oct 14 2018, 4:52 PM · Konsole
sandsmark added a comment to D16134: Secure history file.

this is pretty useless if you have an encrypted disk, so I'd like it to be optional as well.

Oct 14 2018, 4:30 PM · Konsole
sandsmark committed R319:f1c0a0a7640a: rename things to be more consistent (authored by sandsmark).
rename things to be more consistent
Oct 14 2018, 4:27 PM
sandsmark committed R319:f7079fcb54d5: fix when changing system palette (authored by sandsmark).
fix when changing system palette
Oct 14 2018, 4:27 PM
sandsmark committed R319:a633199549d8: some more tiny fixes (authored by sandsmark).
some more tiny fixes
Oct 14 2018, 4:27 PM
sandsmark committed R319:42fbbd8778f3: move some common code out into a small static function (authored by sandsmark).
move some common code out into a small static function
Oct 14 2018, 4:27 PM
sandsmark committed R319:0b5bc3ee0218: fix inactive color for scrollbar (authored by sandsmark).
fix inactive color for scrollbar
Oct 14 2018, 4:27 PM
sandsmark committed R319:23ebb9593e5b: refactor a bit (authored by sandsmark).
refactor a bit
Oct 14 2018, 4:27 PM
sandsmark committed R319:9a79ddebf634: allow changing background when losing focus (authored by sandsmark).
allow changing background when losing focus
Oct 14 2018, 4:27 PM
sandsmark added inline comments to D15295: [konsole]: proper fix for a crash-on-exit.
Oct 14 2018, 4:17 PM · Konsole
sandsmark added a comment to D16198: Add support for dimming the colors when losing focus.

occured to me that this might be useful for e. g. split views as well, so not only dimming when the window loses focus. should I change it to just check for widget focus?

Oct 14 2018, 4:12 PM · Konsole
sandsmark added a comment to D16198: Add support for dimming the colors when losing focus.

I think this also fixes the colors when changing system colors (I don't think the new scrollbar color code works well with 568095c482785903148130fe72ee3d45f325c453).

Oct 14 2018, 4:08 PM · Konsole
sandsmark requested review of D16198: Add support for dimming the colors when losing focus.
Oct 14 2018, 4:05 PM · Konsole

Oct 8 2018

sandsmark added a comment to D15915: Antialias line drawing characters.

there's some new ugly artifacts between linechars now:

Oct 8 2018, 12:35 PM · Konsole
sandsmark abandoned D16010: Re-introduce bounds check removed in fcea6742c142fdbfdf53d17c862bfae7652fae3b.

just committed it normally, I don't understand phabricator very well. :-)

Oct 8 2018, 12:20 PM · Konsole
sandsmark committed R319:5006d0e194d6: Re-introduce bounds check removed in fcea6742c142fdbfdf53d17c862bfae7652fae3b (authored by sandsmark).
Re-introduce bounds check removed in fcea6742c142fdbfdf53d17c862bfae7652fae3b
Oct 8 2018, 12:20 PM

Oct 7 2018

sandsmark accepted D13876: Display more readable tooltip text.

thought I acked this already, but phabricator confuses me

Oct 7 2018, 12:22 PM
sandsmark requested review of D16010: Re-introduce bounds check removed in fcea6742c142fdbfdf53d17c862bfae7652fae3b.
Oct 7 2018, 12:21 PM · Konsole
sandsmark committed R319:f01c6e544fe8: build without kio widgets (authored by sandsmark).
build without kio widgets
Oct 7 2018, 12:07 PM
sandsmark committed R319:733af4833986: enable building without kbookmarks (authored by sandsmark).
enable building without kbookmarks
Oct 7 2018, 12:07 PM
sandsmark committed R319:cbd4c4c8e07e: enable building without knewstuff (authored by sandsmark).
enable building without knewstuff
Oct 7 2018, 12:06 PM
sandsmark committed R319:6eb27fe55405: drop ktextwidgets for a couple more libraries (authored by sandsmark).
drop ktextwidgets for a couple more libraries
Oct 7 2018, 12:06 PM
sandsmark committed R319:0a441254573e: Allow building without KNotify (authored by sandsmark).
Allow building without KNotify
Oct 7 2018, 12:06 PM

Sep 29 2018

sandsmark requested review of D15834: port away from deprecated ffmpeg APIs.
Sep 29 2018, 2:35 PM

Aug 18 2018

sandsmark committed R529:a7a3b3a9accb: fix shell provider, also clean up a bit (authored by sandsmark).
fix shell provider, also clean up a bit
Aug 18 2018, 11:18 AM
sandsmark committed R529:b0ef3b786dfd: 'fix' garbled display when waking from suspend with nvidia (authored by sandsmark).
'fix' garbled display when waking from suspend with nvidia
Aug 18 2018, 11:18 AM

Jul 21 2018

sandsmark committed R352:aa597cb8e55d: tiny code style fixes in map::colorise (authored by sandsmark).
tiny code style fixes in map::colorise
Jul 21 2018, 1:30 PM
sandsmark committed R352:f045538172b1: fix coloring on summary screen with different translations (authored by sandsmark).
fix coloring on summary screen with different translations
Jul 21 2018, 1:30 PM
sandsmark added inline comments to D13882: Use QTabBar: drop tons of code.
Jul 21 2018, 12:34 PM · Konsole
sandsmark added a comment to D13882: Use QTabBar: drop tons of code.

in general a lot of regressions, and some things that should be cleaned up.

Jul 21 2018, 12:31 PM · Konsole
sandsmark requested review of D14262: fix emoji rendering.
Jul 21 2018, 11:41 AM · Konsole
sandsmark added a comment to D13876: Display more readable tooltip text.

yeah, I prefer to use i18n() wherever possible, different languages have very different ways of structuring text and information. (and use i18nc() to explain to the translators the context)

Jul 21 2018, 11:36 AM
sandsmark added a comment to D13882: Use QTabBar: drop tons of code.

shouldn't this has been postponed until after hindenburg had time to review it? it's pretty large, but I'll try to review it as well.

Jul 21 2018, 11:25 AM · Konsole

Jul 16 2018

sandsmark added a comment to D6083: Bump max thumbnail size to 512px.

I love the idea, but what about caching? Cached thumbnails are supposed to follow https://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html#THUMBSIZE, which still, sadly, says 256.

Jul 16 2018, 11:55 AM · Gwenview
sandsmark committed R319:ac59cc7e007a: Fix hang on a lot of output from a program (authored by sandsmark).
Fix hang on a lot of output from a program
Jul 16 2018, 11:49 AM
sandsmark closed D6078: Fix hang on a lot of output from a program.
Jul 16 2018, 11:49 AM · Konsole
sandsmark added a comment to D11188: Fix use after free in RadialMap::Widget::invalidate().

it looks correct to me (i. e. we should never delete a Folder without invalidating), but it would be nice with at least a shortened backtrace because I'm still not 100% sure how it ends up in that state.

Jul 16 2018, 11:36 AM
sandsmark requested changes to D13876: Display more readable tooltip text.

please fix what harald pointed out, otherwise it looks good.

Jul 16 2018, 11:14 AM

Jun 19 2018

sandsmark requested review of D13620: fix potential crash.
Jun 19 2018, 7:53 PM · Konsole

May 26 2018

sandsmark committed R529:067005a4ee03: tweak prioritizing a bit (authored by sandsmark).
tweak prioritizing a bit
May 26 2018, 12:44 PM

May 10 2018

sandsmark committed R529:db00a6899fe8: keep result list size constant (authored by sandsmark).
keep result list size constant
May 10 2018, 12:20 PM
sandsmark committed R529:ecff24884ff0: show history (authored by sandsmark).
show history
May 10 2018, 12:17 PM
sandsmark committed R529:a75397a8e007: use speedcrunch for calculating (authored by sandsmark).
use speedcrunch for calculating
May 10 2018, 11:45 AM

May 7 2018

sandsmark added a comment to D11155: handle zip files embedded within zip files.
May 7 2018, 9:49 AM · Frameworks
sandsmark updated the diff for D11155: handle zip files embedded within zip files.
May 7 2018, 9:49 AM · Frameworks

Apr 29 2018

sandsmark committed R773:39644abe16a6: fix behavior with tiling window managers (authored by sandsmark).
fix behavior with tiling window managers
Apr 29 2018, 7:14 AM
sandsmark committed R773:944dc74e080f: reposition to current desktop when falling out of working area (authored by sandsmark).
reposition to current desktop when falling out of working area
Apr 29 2018, 7:14 AM
sandsmark committed R773:a266978bcf67: fix window flags (authored by sandsmark).
fix window flags
Apr 29 2018, 7:06 AM
sandsmark committed R773:8a2fae5e367d: don't switch to blur animation until we know we need it (authored by sandsmark).
don't switch to blur animation until we know we need it
Apr 29 2018, 7:06 AM
sandsmark committed R773:9fa9e854d97e: port from kconfig to qsettings, kconfig doesn't seem to be able to parse… (authored by sandsmark).
port from kconfig to qsettings, kconfig doesn't seem to be able to parse…
Apr 29 2018, 7:06 AM
sandsmark committed R773:9c8ce38eb21d: port away from some deprecated api (authored by sandsmark).
port away from some deprecated api
Apr 29 2018, 7:06 AM
sandsmark committed R773:d6cd5a1210f2: disable some annoying defines that aren't really useful (authored by sandsmark).
disable some annoying defines that aren't really useful
Apr 29 2018, 7:06 AM
sandsmark committed R773:bce6943fca87: fix segfault when failing to load config (authored by sandsmark).
fix segfault when failing to load config
Apr 29 2018, 7:06 AM

Apr 5 2018

sandsmark requested review of D11956: terminalcharacterdecoder: fix HTML escaping of &.
Apr 5 2018, 12:51 PM · Konsole