- User Since
- Jun 9 2015, 5:16 PM (219 w, 1 d)
Sat, Aug 3
Wed, Jul 31
Tue, Jul 23
Jul 15 2019
Jul 7 2019
Created a merge request here, I think I did it right: https://invent.kde.org/kde/konsole/merge_requests/12
Jul 5 2019
You'll have to throw in a bunch of qAsConst() to silence clazy and the code ends up less readable imho. So I actually like Q_FOREACH better if you want to make clazy shut up as well (but in general I think clazy is a bit too triggerhappy, readable code is more important than fast code, if it is too slow you bring out a profiler and fix where the problems are).
May 26 2019
May 12 2019
Mar 8 2019
Mar 4 2019
Mar 2 2019
How about just a checkbox to turn on/off the new "fancy" search look for now? I've tested with all the color schemes I have available, and I believe we handle it OK, but I could have missed some.
updated so it applies cleanly
Updated so it applies cleanly.
FWIW, looking at the code briefly, I think this patch does the right thing if we end up in that bad "something went wrong"-state. But there's probably a second bug somewhere that leads us to that state, so a bit hard to reproduce, I guess.
Removing the changing the lightness of the buttonColor makes it a bit more visible, imho:
Mar 1 2019
Feb 18 2019
Feb 9 2019
Feb 8 2019
What about hidding the tab, showing kmessagewidget "Tab xxx closed. undo" + timeout, and really closing the tab after the timeout? Works well on web/mobiles.
thanks for doing this, been dreading doing something like it myself. :-)
I've been wanting to refactor it to remove all the individual getters and setters in TerminalDisplay, and just let TerminalDisplay hold the Profile::Ptr, then terminaldisplay can just directly use the values from Profile instead of duplicating all the variables and getters/setters.
Removed the unrelated cleanup/moving of the code in hotSpotRegion()
I consistently lose any settings I make the first time I run konsole (ie, no .config/konsolerc and no files in .local/share/konsole/). I confirmed this with other users.