sandsmark (Martin Tobias Holmedahl Sandsmark)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2015, 5:16 PM (260 w, 2 d)
Availability
Available

Recent Activity

Tue, Jun 2

sandsmark committed R819:a246d049c13f: fix build of kmedia (authored by sandsmark).
fix build of kmedia
Tue, Jun 2, 11:53 PM
sandsmark committed R816:c4b13e658a84: fix paths (authored by sandsmark).
fix paths
Tue, Jun 2, 11:39 PM
sandsmark committed R820:2cae390428ed: fix build with system qt (authored by sandsmark).
fix build with system qt
Tue, Jun 2, 11:33 PM
sandsmark committed R822:cc60f0d65da5: fix building against system version of qt (authored by sandsmark).
fix building against system version of qt
Tue, Jun 2, 11:28 PM
sandsmark committed R816:aea908d9298f: fix build with system qt (authored by sandsmark).
fix build with system qt
Tue, Jun 2, 11:25 PM
sandsmark committed R815:757f1fb59058: Remember to update the references to the target (authored by sandsmark).
Remember to update the references to the target
Tue, Jun 2, 11:19 PM
sandsmark committed R815:7417d266b469: avoid naming conflict for konsole (authored by sandsmark).
avoid naming conflict for konsole
Tue, Jun 2, 11:18 PM
sandsmark committed R815:7a4bcbed268e: fix build with system qt (authored by sandsmark).
fix build with system qt
Tue, Jun 2, 11:16 PM
sandsmark committed R821:2fdce629a6ba: fix build with system qt1 (authored by sandsmark).
fix build with system qt1
Tue, Jun 2, 11:00 PM
sandsmark committed R818:d60a93a11539: Now I finally got rid of opt (authored by sandsmark).
Now I finally got rid of opt
Tue, Jun 2, 10:58 PM
sandsmark committed R818:70f1daa25d9a: don't hardcode install paths (authored by sandsmark).
don't hardcode install paths
Tue, Jun 2, 10:28 PM
sandsmark committed R818:592a008b43d3: fix building with system qt (authored by sandsmark).
fix building with system qt
Tue, Jun 2, 9:42 PM
sandsmark committed R823:dc8a8d6431f4: fix build (authored by sandsmark).
fix build
Tue, Jun 2, 9:16 PM

Sat, May 30

sandsmark closed D17744: New search result look, resurrected.
Sat, May 30, 4:11 PM · Konsole
sandsmark added a comment to D17744: New search result look, resurrected.

Moved it to invent: https://invent.kde.org/utilities/konsole/-/merge_requests/105

Sat, May 30, 4:11 PM · Konsole
sandsmark requested changes to D29004: Close main window after displaying the information about invalid URL.

If filelight is launched with a path I'm fairly certain it's quicker for the user to just correct the path rather than navigating the open dialog, so go ahead. (I'm almost tempted to just print a warning on the command line).

Sat, May 30, 2:44 PM

Sat, May 23

sandsmark committed R111:fa0675414785: remove unnecessary dependency (authored by sandsmark).
remove unnecessary dependency
Sat, May 23, 8:17 PM

Fri, May 22

sandsmark committed R352:1a9fe765923f: don't rescan everything when deleting in a subdirectory and going up again (authored by sandsmark).
don't rescan everything when deleting in a subdirectory and going up again
Fri, May 22, 11:59 AM
sandsmark committed R352:b36e2e85d734: Fix memory leaks all over the place (I was dumb when porting to QList) (authored by sandsmark).
Fix memory leaks all over the place (I was dumb when porting to QList)
Fri, May 22, 11:39 AM
sandsmark committed R352:187c322d2943: fix invalid cast (authored by sandsmark).
fix invalid cast
Fri, May 22, 11:39 AM

Wed, May 20

sandsmark added inline comments to D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files..
Wed, May 20, 8:22 AM · Plasma
sandsmark added inline comments to D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files..
Wed, May 20, 8:18 AM · Plasma
sandsmark added a comment to D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files..

It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now.

Wed, May 20, 8:10 AM · Plasma

Sun, May 10

sandsmark committed R287:8562ce18f1ab: Add some sanity and bounds checking (authored by sandsmark).
Add some sanity and bounds checking
Sun, May 10, 4:08 PM
sandsmark closed D24367: Some sanity verification.
Sun, May 10, 4:08 PM · Frameworks
sandsmark added inline comments to D28982: Use Qt instead of a full glib event loop just for pulseaudio.
Sun, May 10, 4:03 PM
sandsmark updated the diff for D28982: Use Qt instead of a full glib event loop just for pulseaudio.

Replaced it with a pointer, but as explained in the reply to the comment about deleting and recreating I don't think it makes sense to delete and recreate the fake "mainloop"/event loop since it only wraps the Qt event loop (and can't delete and recreate the Qt event loop obviously).

Sun, May 10, 4:03 PM

Apr 22 2020

sandsmark committed R529:e73ffc3829d9: a bit less spammy (authored by sandsmark).
a bit less spammy
Apr 22 2020, 9:35 AM
sandsmark committed R529:54316b98ab59: fix build (authored by sandsmark).
fix build
Apr 22 2020, 9:35 AM
sandsmark committed R529:28b1bf937a81: a bit better matching (authored by sandsmark).
a bit better matching
Apr 22 2020, 9:35 AM
sandsmark committed R529:ccb6197ae74b: bit faster collating results, warn about slow providers (authored by sandsmark).
bit faster collating results, warn about slow providers
Apr 22 2020, 9:35 AM
sandsmark committed R529:60f354dd6103: massive speed improvement for applications provider (authored by sandsmark).
massive speed improvement for applications provider
Apr 22 2020, 9:35 AM
sandsmark committed R529:594ff7ca85d7: massive speedup of paths provider (authored by sandsmark).
massive speedup of paths provider
Apr 22 2020, 9:35 AM
sandsmark committed R529:7bf0faf03098: ensure initialization when starting (authored by sandsmark).
ensure initialization when starting
Apr 22 2020, 9:35 AM
sandsmark committed R529:7da41ad93d8a: significantly speed up applications provider (todo remove kservicetrader, it's… (authored by sandsmark).
significantly speed up applications provider (todo remove kservicetrader, it's…
Apr 22 2020, 9:35 AM
sandsmark committed R529:b676a03a735e: significantly speed up paths provider (authored by sandsmark).
significantly speed up paths provider
Apr 22 2020, 9:35 AM
sandsmark committed R529:7b2af308184f: cleaner shutdown in units provider (authored by sandsmark).
cleaner shutdown in units provider
Apr 22 2020, 9:35 AM
sandsmark committed R529:1979fcd94c19: speed up Shell provider (authored by sandsmark).
speed up Shell provider
Apr 22 2020, 9:35 AM
sandsmark committed R529:87f98ba4edb6: fix leak (authored by sandsmark).
fix leak
Apr 22 2020, 9:35 AM
sandsmark committed R529:f8eaf6a029e5: kunitconversion has decided that blocking while downloading a file in the UI… (authored by sandsmark).
kunitconversion has decided that blocking while downloading a file in the UI…
Apr 22 2020, 9:35 AM
sandsmark committed R529:efcf2c217a9e: fix warnings (authored by sandsmark).
fix warnings
Apr 22 2020, 9:35 AM

Apr 21 2020

sandsmark added a comment to D29004: Close main window after displaying the information about invalid URL.

I'm a bit thorn, because I like this but it's different from what more or less all other applications do.

Apr 21 2020, 2:20 PM

Apr 19 2020

sandsmark updated the diff for D28651: Load and use global animation settings.

Remove the duplication of animation control, and don't override the animation settings if people haven't adjusted it globally.

Apr 19 2020, 2:56 PM · Plasma, Breeze
sandsmark committed R260:4f7d35d17532: Fix leaking ThumbnailGenerators (authored by sandsmark).
Fix leaking ThumbnailGenerators
Apr 19 2020, 2:47 PM
sandsmark closed D28346: Fix leaking ThumbnailGenerators.
Apr 19 2020, 2:47 PM · Gwenview
sandsmark added a comment to D28345: Fix segfault/call on invalid pointer.

Sorry for missing this.

Apr 19 2020, 2:44 PM · Gwenview
sandsmark committed R260:2f48c6267095: Fix undefined behavior by calling on almost destroyed object (authored by sandsmark).
Fix undefined behavior by calling on almost destroyed object
Apr 19 2020, 2:44 PM
sandsmark committed R260:24e881134a94: Fix leak of Rows in infocontextmanageritem (authored by sandsmark).
Fix leak of Rows in infocontextmanageritem
Apr 19 2020, 2:44 PM
sandsmark closed D28342: Fix undefined behavior by calling on almost destroyed object.
Apr 19 2020, 2:44 PM · Gwenview
sandsmark closed D28343: Fix leak of Rows in infocontextmanageritem.
Apr 19 2020, 2:44 PM · Gwenview
sandsmark committed R260:e2e905973c47: Fix memory leak in CMS (authored by sandsmark).
Fix memory leak in CMS
Apr 19 2020, 2:44 PM
sandsmark closed D28344: Fix memory leak in CMS.
Apr 19 2020, 2:44 PM · Gwenview
sandsmark committed R260:6cc5a511e1bf: Fix segfault/call on invalid pointer (authored by sandsmark).
Fix segfault/call on invalid pointer
Apr 19 2020, 2:44 PM
sandsmark closed D28345: Fix segfault/call on invalid pointer.
Apr 19 2020, 2:44 PM · Gwenview
sandsmark requested review of D28982: Use Qt instead of a full glib event loop just for pulseaudio.
Apr 19 2020, 2:35 PM
sandsmark closed D28769: Add Icelandic Krona.
Apr 19 2020, 2:17 PM · Frameworks
sandsmark committed R292:1a7d46d3f753: Add Icelandic Krona to currencies (authored by sandsmark).
Add Icelandic Krona to currencies
Apr 19 2020, 2:17 PM

Apr 15 2020

sandsmark added a comment to D25267: Improve XCF support.

There, build fixed and all tests pass on msvc.

Apr 15 2020, 7:50 AM · Frameworks
sandsmark committed R287:497b6b81bdf5: Fix build on Windows. (authored by sandsmark).
Fix build on Windows.
Apr 15 2020, 7:48 AM

Apr 13 2020

sandsmark added a comment to D25267: Improve XCF support.
Apr 13 2020, 9:17 PM · Frameworks
sandsmark abandoned D25267: Improve XCF support.

I messed up and it got linked to the wrong phabricator review... Here it is anyways:

Apr 13 2020, 1:08 PM · Frameworks
sandsmark added a comment to D28651: Load and use global animation settings.

As for runtime changes I'm trying to migrate more things to KConfigWatcher which I wrote to replace random ad-hoc ints everywhere as well as making sure we automatically reparse the config once and only once.

It's going to be /amazing/ but it's being rolled out as a slow migration, so there's nothing wrong with merging this as-is and migrating later.

Apr 13 2020, 1:06 PM · Plasma, Breeze
sandsmark committed R287:c60e77c048d3: Add support for modern Gimp images/XCF files (authored by sandsmark).
Add support for modern Gimp images/XCF files
Apr 13 2020, 1:05 PM
sandsmark added a comment to D28344: Fix memory leak in CMS.

Again, fairly trivial, I hope.

Apr 13 2020, 12:50 PM · Gwenview
sandsmark added a comment to D28345: Fix segfault/call on invalid pointer.

This should be a fairly trivial and straightforward fix, fwiw. And without this and the other patches I can't really run gwenview with ubsan and asan.

Apr 13 2020, 12:49 PM · Gwenview
sandsmark added a comment to D28651: Load and use global animation settings.

You need to fix the git author info. If you upload a patch via the web UI instead of arc, the author info gets messed up.

Apr 13 2020, 12:48 PM · Plasma, Breeze
sandsmark added inline comments to D28770: Avoid blocking the UI thread.
Apr 13 2020, 12:45 PM · Frameworks
sandsmark updated the diff for D28770: Avoid blocking the UI thread.

Fixed review comments

Apr 13 2020, 12:45 PM · Frameworks
sandsmark added a comment to D28770: Avoid blocking the UI thread.

I don't fully understand the need for a thread here.
It merely blocks because the API is synchronous and thus we create a nested eventloop.
I don't think the writing and parsing of the cache file is a real bottleneck here.

Apr 13 2020, 12:31 PM · Frameworks
sandsmark updated the diff for D28769: Add Icelandic Krona.

Forgot to base it on master instead of my feature branch.

Apr 13 2020, 12:27 PM · Frameworks

Apr 12 2020

sandsmark updated the diff for D25267: Improve XCF support.

Fixed the layer composition modes, so now my fruit pilot got colors.

Apr 12 2020, 1:09 PM · Frameworks
sandsmark updated the diff for D25267: Improve XCF support.

Implemented the last few properties that were missing for my beautiful XCF (not actually using them, though, I'm not in the mood to implement blending in the LAB color space).

Apr 12 2020, 12:29 PM · Frameworks
sandsmark updated the diff for D25267: Improve XCF support.

Added test files (my own beautiful drawing).

Apr 12 2020, 11:36 AM · Frameworks
sandsmark added inline comments to D24367: Some sanity verification.
Apr 12 2020, 11:06 AM · Frameworks
sandsmark updated the diff for D24367: Some sanity verification.

Added missing return.

Apr 12 2020, 11:06 AM · Frameworks
sandsmark updated the diff for D28651: Load and use global animation settings.

Now should reload the animation settings when changed anywhere.

Apr 12 2020, 11:02 AM · Plasma, Breeze
sandsmark added a comment to D28651: Load and use global animation settings.

I don't know enough about KDE configuration management to judge the code, but with this patch, changing animation speeds in SySe works if I restart apps after the change.

Apr 12 2020, 10:40 AM · Plasma, Breeze
sandsmark updated the diff for D28651: Load and use global animation settings.

Also made it store to the global configuration. This way it is backwards compatible, but the config can also be changed from both places.

Apr 12 2020, 10:38 AM · Plasma, Breeze
sandsmark added a comment to D28659: Fix crashing on starting and quitting.

Feel free to just push on behalf of me in the future, though, work and holidays often get in the way of quickly following up on stuff..

Apr 12 2020, 10:18 AM · Dolphin
sandsmark committed R318:35b4c6d4df12: Fix crashing on starting and quitting (authored by sandsmark).
Fix crashing on starting and quitting
Apr 12 2020, 10:17 AM
sandsmark closed D28659: Fix crashing on starting and quitting.
Apr 12 2020, 10:17 AM · Dolphin
sandsmark added a comment to D28659: Fix crashing on starting and quitting.

But yeah, it seems to only crash with a newer dolphin and icu, and seems to be very threading-dependent and hard to reproduce. But locking this should be the right thing to do anyways.

Apr 12 2020, 10:14 AM · Dolphin
sandsmark requested review of D28770: Avoid blocking the UI thread.
Apr 12 2020, 10:12 AM · Frameworks
sandsmark requested review of D28769: Add Icelandic Krona.
Apr 12 2020, 10:08 AM · Frameworks

Apr 7 2020

sandsmark added a comment to D28628: Fix opening relative urls from the command line.

We switched to gitlab some months ago. I think you first have to log in to gitlab (https://invent.kde.org ) using the identity credentials.
Then add or switch to the gitlab remote.
git@invent.kde.org:kde/kdenlive.git

Apr 7 2020, 3:24 PM · Kdenlive
sandsmark closed D28628: Fix opening relative urls from the command line.
Apr 7 2020, 3:23 PM · Kdenlive
sandsmark committed R158:3ec9dbed157e: Fix opening relative paths from the command line (authored by sandsmark).
Fix opening relative paths from the command line
Apr 7 2020, 3:23 PM
sandsmark requested review of D28659: Fix crashing on starting and quitting.
Apr 7 2020, 3:18 PM · Dolphin
sandsmark added a comment to D17732: Respect animation settings.

And FWIW, after https://phabricator.kde.org/D28373 landed animations are smooth where they used to bother me, so this isn't really that important for me personally anymore. But being able to turn off animations (without cluttering the gwenview settings more) is nice anyways.

Apr 7 2020, 1:20 PM · Gwenview
sandsmark requested review of D28651: Load and use global animation settings.
Apr 7 2020, 1:16 PM · Plasma, Breeze
sandsmark added a comment to D17732: Respect animation settings.
+        KSharedConfig::Ptr config = KSharedConfig::openConfig(QStringLiteral("kdeglobals"));

Just KSharedConfig::openConfig()

it'll include kdeglobals wihtout a reparse

Apr 7 2020, 1:07 PM · Gwenview
sandsmark added a reviewer for D28346: Fix leaking ThumbnailGenerators: ngraham.
Apr 7 2020, 1:05 PM · Gwenview
sandsmark added a reviewer for D28345: Fix segfault/call on invalid pointer: ngraham.
Apr 7 2020, 1:05 PM · Gwenview
sandsmark added a reviewer for D28344: Fix memory leak in CMS: ngraham.
Apr 7 2020, 1:05 PM · Gwenview
sandsmark added a reviewer for D28343: Fix leak of Rows in infocontextmanageritem: ngraham.
Apr 7 2020, 1:04 PM · Gwenview
sandsmark added a reviewer for D28342: Fix undefined behavior by calling on almost destroyed object: ngraham.
Apr 7 2020, 1:04 PM · Gwenview
sandsmark abandoned D27910: Make sure warning output is enabled before testing if the correct warning is printed.

Note that in both cases the env var QT_LOGGING_RULES would break the unittest anyway... so yeah it's only about qtlogging.ini which we can easily skip with test mode.

Apr 7 2020, 1:03 PM · Frameworks
sandsmark added a comment to D28628: Fix opening relative urls from the command line.

Thanks a lot, can you push the change?

Apr 7 2020, 12:58 PM · Kdenlive
sandsmark committed R374:86b3782d9751: remove some/most of the defines (authored by sandsmark).
remove some/most of the defines
Apr 7 2020, 12:54 PM
sandsmark committed R374:28a54164f545: enable all DEBUG defines by default, let Q_LOGGING_CATEGORY handle turning it… (authored by sandsmark).
enable all DEBUG defines by default, let Q_LOGGING_CATEGORY handle turning it…
Apr 7 2020, 12:54 PM