- User Since
- Jun 9 2015, 5:16 PM (260 w, 2 d)
Tue, Jun 2
Sat, May 30
Moved it to invent: https://invent.kde.org/utilities/konsole/-/merge_requests/105
If filelight is launched with a path I'm fairly certain it's quicker for the user to just correct the path rather than navigating the open dialog, so go ahead. (I'm almost tempted to just print a warning on the command line).
Sat, May 23
Fri, May 22
Wed, May 20
It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now.
Sun, May 10
Replaced it with a pointer, but as explained in the reply to the comment about deleting and recreating I don't think it makes sense to delete and recreate the fake "mainloop"/event loop since it only wraps the Qt event loop (and can't delete and recreate the Qt event loop obviously).
Apr 22 2020
Apr 21 2020
I'm a bit thorn, because I like this but it's different from what more or less all other applications do.
Apr 19 2020
Remove the duplication of animation control, and don't override the animation settings if people haven't adjusted it globally.
Apr 15 2020
There, build fixed and all tests pass on msvc.
Apr 13 2020
I messed up and it got linked to the wrong phabricator review... Here it is anyways:
Again, fairly trivial, I hope.
This should be a fairly trivial and straightforward fix, fwiw. And without this and the other patches I can't really run gwenview with ubsan and asan.
Fixed review comments
Forgot to base it on master instead of my feature branch.
Apr 12 2020
Fixed the layer composition modes, so now my fruit pilot got colors.
Implemented the last few properties that were missing for my beautiful XCF (not actually using them, though, I'm not in the mood to implement blending in the LAB color space).
Added test files (my own beautiful drawing).
Added missing return.
Now should reload the animation settings when changed anywhere.
Also made it store to the global configuration. This way it is backwards compatible, but the config can also be changed from both places.
Feel free to just push on behalf of me in the future, though, work and holidays often get in the way of quickly following up on stuff..
But yeah, it seems to only crash with a newer dolphin and icu, and seems to be very threading-dependent and hard to reproduce. But locking this should be the right thing to do anyways.
Apr 7 2020
And FWIW, after https://phabricator.kde.org/D28373 landed animations are smooth where they used to bother me, so this isn't really that important for me personally anymore. But being able to turn off animations (without cluttering the gwenview settings more) is nice anyways.