sandsmark (Martin Tobias Holmedahl Sandsmark)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2015, 5:16 PM (235 w, 2 d)
Availability
Available

Recent Activity

Thu, Nov 14

sandsmark requested review of D25302: Remove stale symlink.
Thu, Nov 14, 12:51 PM · Frameworks

Nov 11 2019

sandsmark updated the diff for D25267: Improve XCF support.

Fixed masks as well, now even some more complex XCF files work again.

Nov 11 2019, 11:28 PM · Frameworks
sandsmark updated the diff for D25267: Improve XCF support.

Forgot to fix the layer offset reading, and read the precision after instead of before the image properties

Nov 11 2019, 11:08 PM · Frameworks
sandsmark requested review of D25267: Improve XCF support.
Nov 11 2019, 10:32 PM · Frameworks

Oct 11 2019

sandsmark added a comment to D17732: Respect animation settings.

Please feel free to send a Plasma patch!

Oct 11 2019, 9:44 PM · Gwenview
sandsmark added a comment to D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".

Any reason not to use kexiv2?

Oct 11 2019, 9:42 PM · Gwenview
sandsmark updated the diff for D24576: Don't link directly against Purpose for sharing.
Oct 11 2019, 9:38 PM · Gwenview
sandsmark requested review of D24576: Don't link directly against Purpose for sharing.
Oct 11 2019, 9:34 PM · Gwenview
sandsmark committed R529:58a3a4416ed6: fix crash because sorting is hard (authored by sandsmark).
fix crash because sorting is hard
Oct 11 2019, 8:00 PM
sandsmark committed R529:72d88625eae2: fix leak (authored by sandsmark).
fix leak
Oct 11 2019, 8:00 PM
sandsmark added a comment to D17732: Respect animation settings.

Something like this I think should work:

Oct 11 2019, 7:39 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

In fact we now have a shiny new global animation slider in the General Behavior KCM. If you change the patch to make Gwenview respect that setting, I'll be happy with it.

Do you know what that adjusts? If it adjusts the normal Qt animation hints/properties like QStyle::SH_Widget_Animation_Duration this patch Should Just Work™.

Oct 11 2019, 7:29 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

In fact we now have a shiny new global animation slider in the General Behavior KCM. If you change the patch to make Gwenview respect that setting, I'll be happy with it.

Oct 11 2019, 7:12 PM · Gwenview
sandsmark closed D24364: Fix crash with animations disabled.

Already fixed with another approach in master.

Oct 11 2019, 7:10 PM · Gwenview

Oct 5 2019

sandsmark added reviewers for D24364: Fix crash with animations disabled: mlaurent, meven, ngraham, yurchor, tommo.
Oct 5 2019, 9:42 AM · Gwenview

Oct 2 2019

sandsmark requested review of D24367: Some sanity verification.
Oct 2 2019, 3:45 PM · Frameworks
sandsmark updated the diff for D17732: Respect animation settings.
Oct 2 2019, 2:36 PM · Gwenview
sandsmark requested review of D24364: Fix crash with animations disabled.
Oct 2 2019, 2:28 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

However, I'm seeing that this appears to always disable all animations for me, no matter what value the animation speed is set up in the Breeze style settings:

Oct 2 2019, 1:35 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

As for the discussion above, I don't see how plasma-integration is relevant. It does control QStyleHints, but you're not using any of that.
Everything you use here comes from the QStyle which is all from Breeze.

Oct 2 2019, 1:21 PM · Gwenview

Aug 3 2019

sandsmark committed R352:4a0eae4b31ec: make sure our tooltip isn't outside the visible screen (authored by sandsmark).
make sure our tooltip isn't outside the visible screen
Aug 3 2019, 5:49 PM
sandsmark committed R352:165404a92d8e: Make sure our tooltip doesn't pop up in unexpected places (authored by sandsmark).
Make sure our tooltip doesn't pop up in unexpected places
Aug 3 2019, 5:49 PM
sandsmark committed R352:39c29b4d1a2e: use some defines, and simplify the code for drawing the radial map (authored by sandsmark).
use some defines, and simplify the code for drawing the radial map
Aug 3 2019, 4:55 PM
sandsmark committed R352:d7c7c5d75cfd: make the radial map resizing logic a bit easier to follow (authored by sandsmark).
make the radial map resizing logic a bit easier to follow
Aug 3 2019, 4:55 PM
sandsmark committed R352:cd7e4886fbe4: avoid unnecessary qpainter state trashing (authored by sandsmark).
avoid unnecessary qpainter state trashing
Aug 3 2019, 4:55 PM
sandsmark committed R352:3acc805774b0: fix ugly edges on radial map when indicating things below threshold (authored by sandsmark).
fix ugly edges on radial map when indicating things below threshold
Aug 3 2019, 4:55 PM
sandsmark committed R352:c6a61a5d009c: fix ugly borders in map (authored by sandsmark).
fix ugly borders in map
Aug 3 2019, 4:43 PM
sandsmark accepted D22794: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON.
Aug 3 2019, 4:37 PM · Frameworks

Jul 31 2019

sandsmark committed R816:9c50f4e74c84: fix kreversi (authored by sandsmark).
fix kreversi
Jul 31 2019, 12:28 AM
sandsmark committed R816:effec348116b: fix ksirtet (authored by sandsmark).
fix ksirtet
Jul 31 2019, 12:28 AM
sandsmark committed R816:15d2595405a8: re-enable ksmiletris (authored by sandsmark).
re-enable ksmiletris
Jul 31 2019, 12:28 AM
sandsmark committed R816:a672386d2553: qt 1's truecolor doesn't work with modern compositing X11 all that well (authored by sandsmark).
qt 1's truecolor doesn't work with modern compositing X11 all that well
Jul 31 2019, 12:28 AM
sandsmark committed R816:f169fbcffbde: port kpoker (authored by sandsmark).
port kpoker
Jul 31 2019, 12:28 AM
sandsmark committed R816:cc75a464d54d: port ksnake (authored by sandsmark).
port ksnake
Jul 31 2019, 12:28 AM
sandsmark committed R816:e89b1c262387: port ksame (authored by sandsmark).
port ksame
Jul 31 2019, 12:28 AM
sandsmark committed R816:cb5cde19706e: port kasteroids (authored by sandsmark).
port kasteroids
Jul 31 2019, 12:28 AM
sandsmark committed R816:15bb2a593f42: Fix build system for kshisen (authored by sandsmark).
Fix build system for kshisen
Jul 31 2019, 12:28 AM
sandsmark committed R816:94c12647b022: fix installing pixmaps for kpat (authored by sandsmark).
fix installing pixmaps for kpat
Jul 31 2019, 12:28 AM

Jul 23 2019

sandsmark committed R352:fda98ae8f15f: display hardlinks (authored by sandsmark).
display hardlinks
Jul 23 2019, 9:20 PM
sandsmark committed R352:703c06680983: use some defines, and simplify the code for drawing the radial map (authored by sandsmark).
use some defines, and simplify the code for drawing the radial map
Jul 23 2019, 9:20 PM
sandsmark committed R352:8d902cf30cb1: make the radial map resizing logic a bit easier to follow (authored by sandsmark).
make the radial map resizing logic a bit easier to follow
Jul 23 2019, 9:20 PM
sandsmark committed R352:d67f559d3d5c: fix ugly edges on radial map when indicating things below threshold (authored by sandsmark).
fix ugly edges on radial map when indicating things below threshold
Jul 23 2019, 9:20 PM
sandsmark committed R352:5d266cae4232: avoid unnecessary qpainter state trashing (authored by sandsmark).
avoid unnecessary qpainter state trashing
Jul 23 2019, 9:20 PM
sandsmark committed R352:36dfa7c737e0: fix ugly borders in map (authored by sandsmark).
fix ugly borders in map
Jul 23 2019, 9:20 PM
sandsmark committed R352:41a61a1924a7: check for hardlinks when scanning (authored by sandsmark).
check for hardlinks when scanning
Jul 23 2019, 9:20 PM

Jul 15 2019

sandsmark committed R374:424027215dd4: drop ktextwidgets dependency just for a single plural handling spinbox (authored by sandsmark).
drop ktextwidgets dependency just for a single plural handling spinbox
Jul 15 2019, 5:31 PM
sandsmark committed R374:9876a3925326: drop dependency on kicontheme (authored by sandsmark).
drop dependency on kicontheme
Jul 15 2019, 4:52 PM
sandsmark committed R374:66556b222e8c: actually build without kdelibs4support (authored by sandsmark).
actually build without kdelibs4support
Jul 15 2019, 4:35 PM
sandsmark requested review of D22476: Port away from kdelibs4support.
Jul 15 2019, 4:00 PM
sandsmark committed R374:3b5c83a86335: fix build without kdelibs4support (authored by sandsmark).
fix build without kdelibs4support
Jul 15 2019, 3:54 PM
sandsmark committed R374:50f69eacfcd9: silence deprecation warning for dumbest deprecation so far (authored by sandsmark).
silence deprecation warning for dumbest deprecation so far
Jul 15 2019, 3:49 PM
sandsmark committed R374:e0a9bce531e1: silence useless warnings about alignment changes (authored by sandsmark).
silence useless warnings about alignment changes
Jul 15 2019, 3:49 PM
sandsmark committed R374:d95acbf7259a: silence more warnings in blitz (authored by sandsmark).
silence more warnings in blitz
Jul 15 2019, 3:49 PM
sandsmark committed R374:add11e6f41dc: port kpDocument_Save away from kimageio (authored by sandsmark).
port kpDocument_Save away from kimageio
Jul 15 2019, 3:49 PM
sandsmark committed R374:a55d559f677b: port kpPreeditText away from deprecated qSort (authored by sandsmark).
port kpPreeditText away from deprecated qSort
Jul 15 2019, 3:49 PM
sandsmark committed R374:8381012a7bc9: rename kpDocumentSaveOptionsWidget to kpDocumentSaveDialog to start porting… (authored by sandsmark).
rename kpDocumentSaveOptionsWidget to kpDocumentSaveDialog to start porting…
Jul 15 2019, 3:49 PM
sandsmark committed R374:a8845beed8fd: Port kpMainWindow_File away from kfiledialog (authored by sandsmark).
Port kpMainWindow_File away from kfiledialog
Jul 15 2019, 3:49 PM
sandsmark committed R374:8f2f318ddb89: port kpMainWindow away from KIO::NetAccess (authored by sandsmark).
port kpMainWindow away from KIO::NetAccess
Jul 15 2019, 3:49 PM
sandsmark committed R374:46b6eba2a0ea: Port kpDocument_Save away from deprecated KIO::NetAccess (authored by sandsmark).
Port kpDocument_Save away from deprecated KIO::NetAccess
Jul 15 2019, 3:49 PM
sandsmark committed R374:28eb26695c1e: port kpDocument_Open away from kdelibs4support (authored by sandsmark).
port kpDocument_Open away from kdelibs4support
Jul 15 2019, 3:49 PM
sandsmark committed R374:06bf669c6670: port kpDocument away from kdelibs4support (authored by sandsmark).
port kpDocument away from kdelibs4support
Jul 15 2019, 3:49 PM
sandsmark committed R374:3b6134a5b783: Port away from deprecated QRegion::rects() (authored by sandsmark).
Port away from deprecated QRegion::rects()
Jul 15 2019, 3:49 PM
sandsmark committed R374:c6d86cb79438: Port kpColorCollection away from kdelibs4support (authored by sandsmark).
Port kpColorCollection away from kdelibs4support
Jul 15 2019, 3:49 PM
sandsmark committed R374:c5a088081a94: Port away from deprecated QDrag::start() (authored by sandsmark).
Port away from deprecated QDrag::start()
Jul 15 2019, 3:49 PM

Jul 7 2019

sandsmark committed R319:12d23264c41f: forgot copyright/license headers (authored by sandsmark).
forgot copyright/license headers
Jul 7 2019, 11:05 AM
sandsmark committed R319:64924ba1f514: Fix Bookmark with duplicates (authored by tcanabrava).
Fix Bookmark with duplicates
Jul 7 2019, 11:02 AM
sandsmark committed R319:cbb298aef191: clean up (authored by sandsmark).
clean up
Jul 7 2019, 11:02 AM
sandsmark added a comment to D22291: Fix display sometimes randomly scrolling down.

Created a merge request here, I think I did it right: https://invent.kde.org/kde/konsole/merge_requests/12

Jul 7 2019, 10:18 AM · Konsole
sandsmark committed R319:b0463effd817: Fix display sometimes randomly scrolling down (authored by sandsmark).
Fix display sometimes randomly scrolling down
Jul 7 2019, 10:17 AM

Jul 5 2019

sandsmark added a comment to D21123: Compile without Q_FOREACH.

You'll have to throw in a bunch of qAsConst() to silence clazy and the code ends up less readable imho. So I actually like Q_FOREACH better if you want to make clazy shut up as well (but in general I think clazy is a bit too triggerhappy, readable code is more important than fast code, if it is too slow you bring out a profiler and fix where the problems are).

Jul 5 2019, 4:52 PM · Konsole
sandsmark requested review of D22291: Fix display sometimes randomly scrolling down.
Jul 5 2019, 4:38 PM · Konsole

May 26 2019

sandsmark committed R529:71dc968fb1a9: fix typo (authored by sandsmark).
fix typo
May 26 2019, 10:24 AM
sandsmark committed R529:fbf7e9d7ff73: force async loading of icons (it can be slow on first load) (authored by sandsmark).
force async loading of icons (it can be slow on first load)
May 26 2019, 10:24 AM
sandsmark committed R529:a27aea15d47c: fix parsing of calculations with units (authored by sandsmark).
fix parsing of calculations with units
May 26 2019, 10:24 AM
sandsmark committed R529:24cb3b8c6e36: add megabyte etc. (authored by sandsmark).
add megabyte etc.
May 26 2019, 10:24 AM
sandsmark committed R529:1f96f46c72e6: improve path matching (authored by sandsmark).
improve path matching
May 26 2019, 10:24 AM

May 12 2019

sandsmark committed R529:41da69489b42: improve sorting when the query has been used before (authored by sandsmark).
improve sorting when the query has been used before
May 12 2019, 10:23 AM
sandsmark committed R529:fa69a37ca7de: fix storing statistics in qsettings (it doesn't like /) (authored by sandsmark).
fix storing statistics in qsettings (it doesn't like /)
May 12 2019, 10:20 AM
sandsmark committed R529:1321e0213a66: fix compile warnings about shifting negative numbers (authored by sandsmark).
fix compile warnings about shifting negative numbers
May 12 2019, 9:20 AM
sandsmark committed R529:f42c5952c6bc: simplify the provider comparison function a bit (authored by sandsmark).
simplify the provider comparison function a bit
May 12 2019, 9:20 AM
sandsmark committed R529:75d4593497c7: fix crash during sorting (I think, too lazy to think), because we sort it… (authored by sandsmark).
fix crash during sorting (I think, too lazy to think), because we sort it…
May 12 2019, 9:20 AM

Mar 8 2019

sandsmark added a comment to D17744: New search result look, resurrected.
In D17744#423497, @mglb wrote:

@ngraham wrong review :)

@sandsmark I would like to modify colors/blending for it in the future (keeping all remaining code), so checkbox would be ok for now. Do we accept config options like "Use new $FEATURE (experimental)"? This would make it easier to remove the option when colors will work with everything.

Mar 8 2019, 12:08 PM · Konsole

Mar 4 2019

sandsmark committed R529:527cffeab49d: try to fix not disappearing when losing focus sometimes (authored by sandsmark).
try to fix not disappearing when losing focus sometimes
Mar 4 2019, 9:30 AM
sandsmark committed R529:660c12ce6a54: shell provider: watch the directories for added/removed executables (authored by sandsmark).
shell provider: watch the directories for added/removed executables
Mar 4 2019, 9:30 AM

Mar 2 2019

sandsmark added a comment to D17744: New search result look, resurrected.

How about just a checkbox to turn on/off the new "fancy" search look for now? I've tested with all the color schemes I have available, and I believe we handle it OK, but I could have missed some.

Mar 2 2019, 8:04 PM · Konsole
sandsmark updated the diff for D18871: Move selection code from TerminalDisplay to ScreenWindow.

updated so it applies cleanly

Mar 2 2019, 7:58 PM · Konsole
sandsmark updated the diff for D18870: Clean up/refactor selection code in TerminalDisplay.

Updated so it applies cleanly.

Mar 2 2019, 7:58 PM · Konsole
sandsmark added inline comments to D17742: Clean up content rect in TerminalDisplay.
Mar 2 2019, 7:54 PM · Konsole
sandsmark added a comment to D11188: Fix use after free in RadialMap::Widget::invalidate().

FWIW, looking at the code briefly, I think this patch does the right thing if we end up in that bad "something went wrong"-state. But there's probably a second bug somewhere that leads us to that state, so a bit hard to reproduce, I guess.

Mar 2 2019, 7:43 PM
sandsmark added a comment to D17732: Respect animation settings.

As for the discussion above, I don't see how plasma-integration is relevant. It does control QStyleHints, but you're not using any of that.
Everything you use here comes from the QStyle which is all from Breeze.

Mar 2 2019, 7:40 PM · Gwenview
sandsmark added a comment to D19482: Fix-ish scrollbar background with Qt Fusion style.

Removing the changing the lightness of the buttonColor makes it a bit more visible, imho:

Mar 2 2019, 7:17 PM · Konsole
sandsmark requested review of D19482: Fix-ish scrollbar background with Qt Fusion style.
Mar 2 2019, 7:09 PM · Konsole

Mar 1 2019

sandsmark committed R529:30020ecacf5a: improve result sorting (authored by sandsmark).
improve result sorting
Mar 1 2019, 8:03 AM

Feb 18 2019

sandsmark committed R529:13cbde53c473: try to fix occasional crash when sorting results (authored by sandsmark).
try to fix occasional crash when sorting results
Feb 18 2019, 6:18 PM

Feb 9 2019

sandsmark added a dependent revision for D18870: Clean up/refactor selection code in TerminalDisplay: D18871: Move selection code from TerminalDisplay to ScreenWindow.
Feb 9 2019, 12:46 PM · Konsole
sandsmark added a dependency for D18871: Move selection code from TerminalDisplay to ScreenWindow: D18870: Clean up/refactor selection code in TerminalDisplay.
Feb 9 2019, 12:46 PM · Konsole
sandsmark requested review of D18871: Move selection code from TerminalDisplay to ScreenWindow.
Feb 9 2019, 12:46 PM · Konsole
sandsmark requested review of D18870: Clean up/refactor selection code in TerminalDisplay.
Feb 9 2019, 12:43 PM · Konsole
sandsmark accepted D18780: Don't include <fstab.h> anymore.
Feb 9 2019, 12:26 PM
sandsmark committed R319:02acee1474e2: move selection code to screenwindow (authored by sandsmark).
move selection code to screenwindow
Feb 9 2019, 12:41 AM