sandsmark (Martin Tobias Holmedahl Sandsmark)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2015, 5:16 PM (171 w, 5 d)
Availability
Available

Recent Activity

Aug 18 2018

sandsmark committed R529:a7a3b3a9accb: fix shell provider, also clean up a bit (authored by sandsmark).
fix shell provider, also clean up a bit
Aug 18 2018, 11:18 AM
sandsmark committed R529:b0ef3b786dfd: 'fix' garbled display when waking from suspend with nvidia (authored by sandsmark).
'fix' garbled display when waking from suspend with nvidia
Aug 18 2018, 11:18 AM

Jul 21 2018

sandsmark committed R352:aa597cb8e55d: tiny code style fixes in map::colorise (authored by sandsmark).
tiny code style fixes in map::colorise
Jul 21 2018, 1:30 PM
sandsmark committed R352:f045538172b1: fix coloring on summary screen with different translations (authored by sandsmark).
fix coloring on summary screen with different translations
Jul 21 2018, 1:30 PM
sandsmark added inline comments to D13882: Use QTabBar: drop tons of code.
Jul 21 2018, 12:34 PM · Konsole
sandsmark added a comment to D13882: Use QTabBar: drop tons of code.

in general a lot of regressions, and some things that should be cleaned up.

Jul 21 2018, 12:31 PM · Konsole
sandsmark requested review of D14262: fix emoji rendering.
Jul 21 2018, 11:41 AM · Konsole
sandsmark added a comment to D13876: Display more readable tooltip text.

yeah, I prefer to use i18n() wherever possible, different languages have very different ways of structuring text and information. (and use i18nc() to explain to the translators the context)

Jul 21 2018, 11:36 AM
sandsmark added a comment to D13882: Use QTabBar: drop tons of code.

shouldn't this has been postponed until after hindenburg had time to review it? it's pretty large, but I'll try to review it as well.

Jul 21 2018, 11:25 AM · Konsole

Jul 16 2018

sandsmark added a comment to D6083: Bump max thumbnail size to 512px.

I love the idea, but what about caching? Cached thumbnails are supposed to follow https://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html#THUMBSIZE, which still, sadly, says 256.

Jul 16 2018, 11:55 AM · Gwenview
sandsmark committed R319:ac59cc7e007a: Fix hang on a lot of output from a program (authored by sandsmark).
Fix hang on a lot of output from a program
Jul 16 2018, 11:49 AM
sandsmark closed D6078: Fix hang on a lot of output from a program.
Jul 16 2018, 11:49 AM · Konsole
sandsmark added a comment to D11188: Fix use after free in RadialMap::Widget::invalidate().

it looks correct to me (i. e. we should never delete a Folder without invalidating), but it would be nice with at least a shortened backtrace because I'm still not 100% sure how it ends up in that state.

Jul 16 2018, 11:36 AM
sandsmark requested changes to D13876: Display more readable tooltip text.

please fix what harald pointed out, otherwise it looks good.

Jul 16 2018, 11:14 AM

Jun 19 2018

sandsmark requested review of D13620: fix potential crash.
Jun 19 2018, 7:53 PM · Konsole

May 26 2018

sandsmark committed R529:067005a4ee03: tweak prioritizing a bit (authored by sandsmark).
tweak prioritizing a bit
May 26 2018, 12:44 PM

May 10 2018

sandsmark committed R529:db00a6899fe8: keep result list size constant (authored by sandsmark).
keep result list size constant
May 10 2018, 12:20 PM
sandsmark committed R529:ecff24884ff0: show history (authored by sandsmark).
show history
May 10 2018, 12:17 PM
sandsmark committed R529:a75397a8e007: use speedcrunch for calculating (authored by sandsmark).
use speedcrunch for calculating
May 10 2018, 11:45 AM

May 7 2018

sandsmark added a comment to D11155: handle zip files embedded within zip files.
May 7 2018, 9:49 AM · Frameworks
sandsmark updated the diff for D11155: handle zip files embedded within zip files.
May 7 2018, 9:49 AM · Frameworks

Apr 29 2018

sandsmark committed R773:39644abe16a6: fix behavior with tiling window managers (authored by sandsmark).
fix behavior with tiling window managers
Apr 29 2018, 7:14 AM
sandsmark committed R773:944dc74e080f: reposition to current desktop when falling out of working area (authored by sandsmark).
reposition to current desktop when falling out of working area
Apr 29 2018, 7:14 AM
sandsmark committed R773:a266978bcf67: fix window flags (authored by sandsmark).
fix window flags
Apr 29 2018, 7:06 AM
sandsmark committed R773:8a2fae5e367d: don't switch to blur animation until we know we need it (authored by sandsmark).
don't switch to blur animation until we know we need it
Apr 29 2018, 7:06 AM
sandsmark committed R773:9fa9e854d97e: port from kconfig to qsettings, kconfig doesn't seem to be able to parse… (authored by sandsmark).
port from kconfig to qsettings, kconfig doesn't seem to be able to parse…
Apr 29 2018, 7:06 AM
sandsmark committed R773:9c8ce38eb21d: port away from some deprecated api (authored by sandsmark).
port away from some deprecated api
Apr 29 2018, 7:06 AM
sandsmark committed R773:d6cd5a1210f2: disable some annoying defines that aren't really useful (authored by sandsmark).
disable some annoying defines that aren't really useful
Apr 29 2018, 7:06 AM
sandsmark committed R773:bce6943fca87: fix segfault when failing to load config (authored by sandsmark).
fix segfault when failing to load config
Apr 29 2018, 7:06 AM

Apr 5 2018

sandsmark requested review of D11956: terminalcharacterdecoder: fix HTML escaping of &.
Apr 5 2018, 12:51 PM · Konsole
sandsmark added a comment to D11859: Copy&paste exploits.

this was the patch I was about to upload before I saw this, I think this makes more sense:

Apr 5 2018, 12:49 PM · Konsole

Mar 20 2018

sandsmark committed R529:f85548efce6e: fix formatting of unit conversion results (should probably merge this with the… (authored by sandsmark).
fix formatting of unit conversion results (should probably merge this with the…
Mar 20 2018, 10:32 PM

Mar 8 2018

sandsmark accepted D9791: Wrong progress in tray.
Mar 8 2018, 5:30 PM
sandsmark committed R529:6cf53ab8a18b: applications: fix storing the popularity (authored by sandsmark).
applications: fix storing the popularity
Mar 8 2018, 5:09 PM
sandsmark committed R529:7db2a81eea56: applications: kservice can't give us proper paths for some reason (authored by sandsmark).
applications: kservice can't give us proper paths for some reason
Mar 8 2018, 5:09 PM
sandsmark requested review of D11156: add autotest for zips within zips.
Mar 8 2018, 3:07 PM · Frameworks
sandsmark requested review of D11155: handle zip files embedded within zip files.
Mar 8 2018, 3:03 PM · Frameworks
sandsmark committed R243:6736aca49c2d: karchive, kzip: try to handle duplicate files in a bit nicer way (authored by sandsmark).
karchive, kzip: try to handle duplicate files in a bit nicer way
Mar 8 2018, 2:58 PM
sandsmark closed D10543: fix crashing with duplicate entries.
Mar 8 2018, 2:58 PM · Frameworks
sandsmark committed R243:6959a256f777: autotests: add crashing test with duplicate names (authored by sandsmark).
autotests: add crashing test with duplicate names
Mar 8 2018, 2:58 PM
sandsmark closed D10551: autotest for crashing in KArchiveDirectory::addEntry.
Mar 8 2018, 2:58 PM · Frameworks

Mar 1 2018

sandsmark added a comment to D10551: autotest for crashing in KArchiveDirectory::addEntry.
Mar 1 2018, 9:51 AM · Frameworks
sandsmark updated the diff for D10551: autotest for crashing in KArchiveDirectory::addEntry.

use a local const copy of entries

Mar 1 2018, 9:49 AM · Frameworks

Feb 22 2018

sandsmark committed R529:8f424d275d0b: qml: add some glow behind icons, for dark icons (authored by sandsmark).
qml: add some glow behind icons, for dark icons
Feb 22 2018, 10:14 AM
sandsmark committed R529:8880a50e8501: shell provider: fix executables with same name in different paths (authored by sandsmark).
shell provider: fix executables with same name in different paths
Feb 22 2018, 10:14 AM

Feb 21 2018

sandsmark updated the diff for D10543: fix crashing with duplicate entries.
Feb 21 2018, 11:00 AM · Frameworks
sandsmark updated the diff for D10551: autotest for crashing in KArchiveDirectory::addEntry.

fix comment from dfaure

Feb 21 2018, 10:59 AM · Frameworks
sandsmark updated the diff for D10543: fix crashing with duplicate entries.

fixes to issues raised

Feb 21 2018, 10:48 AM · Frameworks

Feb 20 2018

sandsmark committed R529:593aec2e60a8: add ugly hack for nvidia drivers (authored by sandsmark).
add ugly hack for nvidia drivers
Feb 20 2018, 9:53 AM
sandsmark committed R529:fef762da1b19: tweak look a bit (authored by sandsmark).
tweak look a bit
Feb 20 2018, 9:12 AM
sandsmark committed R529:680dcdcb5762: fix build, we don't use qttest (authored by sandsmark).
fix build, we don't use qttest
Feb 20 2018, 9:12 AM
sandsmark committed R529:f30d228a40b1: remove some cmake includes that we don't use, and that give us warnings (authored by sandsmark).
remove some cmake includes that we don't use, and that give us warnings
Feb 20 2018, 9:12 AM

Feb 15 2018

sandsmark updated the diff for D10543: fix crashing with duplicate entries.

an actual fix, which passes all unit tests.

Feb 15 2018, 7:11 PM · Frameworks
sandsmark added a dependent revision for D10551: autotest for crashing in KArchiveDirectory::addEntry: D10543: fix crashing with duplicate entries.
Feb 15 2018, 6:10 PM · Frameworks
sandsmark added a dependency for D10543: fix crashing with duplicate entries: D10551: autotest for crashing in KArchiveDirectory::addEntry.
Feb 15 2018, 6:10 PM · Frameworks
sandsmark requested review of D10551: autotest for crashing in KArchiveDirectory::addEntry.
Feb 15 2018, 6:10 PM · Frameworks
sandsmark updated the diff for D10543: fix crashing with duplicate entries.

prettify

Feb 15 2018, 6:08 PM · Frameworks
sandsmark updated the diff for D10543: fix crashing with duplicate entries.

handle stuff a bit prettier. I don't think there's a "right" way to handle this, so parsing is a bit best-effort, but at least it doesn't crash anymore.

Feb 15 2018, 4:17 PM · Frameworks
sandsmark updated the diff for D10543: fix crashing with duplicate entries.

actually do the correct thing

Feb 15 2018, 4:14 PM · Frameworks
sandsmark requested review of D10543: fix crashing with duplicate entries.
Feb 15 2018, 1:59 PM · Frameworks

Dec 15 2017

sandsmark accepted D9345: use correct native separators when prettifying a local path.
Dec 15 2017, 10:55 AM

Oct 22 2017

sandsmark committed R529:4af97569387a: paths provider: enumerate folder which is queried (authored by sandsmark).
paths provider: enumerate folder which is queried
Oct 22 2017, 2:27 PM
sandsmark committed R529:f1d01518f265: applications: improve priority calculations (authored by sandsmark).
applications: improve priority calculations
Oct 22 2017, 2:27 PM
sandsmark committed R529:c482e9ce9551: shell provider: use last modified for priority (authored by sandsmark).
shell provider: use last modified for priority
Oct 22 2017, 2:27 PM
sandsmark committed R529:7f1e3ceb5820: applications: escape query before passing to kservice (authored by sandsmark).
applications: escape query before passing to kservice
Oct 22 2017, 2:27 PM
sandsmark committed R529:ac309230925f: applications: use qint64 for last modified etc. (authored by sandsmark).
applications: use qint64 for last modified etc.
Oct 22 2017, 2:27 PM
sandsmark committed R529:66ca805c686a: fix launching of applications that supports arguments (authored by sandsmark).
fix launching of applications that supports arguments
Oct 22 2017, 1:06 PM
sandsmark committed R529:e6870ca9b253: port to qsettings (authored by sandsmark).
port to qsettings
Oct 22 2017, 1:06 PM
sandsmark committed R529:785c2bb92a8c: fix usage of kuit markup in startup notification (authored by sandsmark).
fix usage of kuit markup in startup notification
Oct 22 2017, 12:40 PM
sandsmark committed R529:c7292bc5b07b: remove unused dependency (authored by sandsmark).
remove unused dependency
Oct 22 2017, 12:40 PM
sandsmark created D8420: Unbreak TerminalInterfaceTest.
Oct 22 2017, 11:19 AM · Konsole
sandsmark added a comment to D6078: Fix hang on a lot of output from a program.

yeah, this is a different bug: https://bugs.kde.org/show_bug.cgi?id=230184

Oct 22 2017, 10:59 AM · Konsole
sandsmark added a dependency for D8417: Use enum/QFlags to avoid boolean trap with confusing arguments: D8381: Implement support for trimming leading whitespace.
Oct 22 2017, 10:52 AM · Konsole
sandsmark added a dependent revision for D8381: Implement support for trimming leading whitespace: D8417: Use enum/QFlags to avoid boolean trap with confusing arguments.
Oct 22 2017, 10:52 AM · Konsole
sandsmark created D8417: Use enum/QFlags to avoid boolean trap with confusing arguments.
Oct 22 2017, 10:41 AM · Konsole
sandsmark updated the diff for D8381: Implement support for trimming leading whitespace.

Uploaded the wrong patch...

Oct 22 2017, 10:39 AM · Konsole
sandsmark updated the diff for D8381: Implement support for trimming leading whitespace.

Re-ordered the code, have a separate patch for the arguments.

Oct 22 2017, 10:38 AM · Konsole
sandsmark accepted D8413: Filelight crashes if readdir returns very long file name.

so it's really ntfs-3g that is broken, I guess? but we should never crash anyways, so thanks.

Oct 22 2017, 9:52 AM

Oct 20 2017

sandsmark created D8381: Implement support for trimming leading whitespace.
Oct 20 2017, 1:53 PM · Konsole

Oct 8 2017

sandsmark committed R529:1b97b4421ba3: use abakus for calculations (authored by sandsmark).
use abakus for calculations
Oct 8 2017, 4:19 PM
sandsmark committed R529:56474e8a82d9: Revert "calculator add support for functions (just sqrt and abs for now)" (authored by sandsmark).
Revert "calculator add support for functions (just sqrt and abs for now)"
Oct 8 2017, 3:09 PM
sandsmark committed R529:ef55c8469211: try to make formatting of numbers from calculator less ugly (authored by sandsmark).
try to make formatting of numbers from calculator less ugly
Oct 8 2017, 3:09 PM
sandsmark added a reverting change for R529:df6cba3d7bfd: calculator add support for functions (just sqrt and abs for now): R529:56474e8a82d9: Revert "calculator add support for functions (just sqrt and abs for now)".
Oct 8 2017, 3:09 PM
sandsmark committed R529:df6cba3d7bfd: calculator add support for functions (just sqrt and abs for now) (authored by sandsmark).
calculator add support for functions (just sqrt and abs for now)
Oct 8 2017, 2:43 PM
sandsmark committed R529:308b4f4504f4: remove spurious debug output (authored by sandsmark).
remove spurious debug output
Oct 8 2017, 1:29 PM
sandsmark committed R529:280c3ac99d1a: units: improve unit matching (authored by sandsmark).
units: improve unit matching
Oct 8 2017, 1:28 PM
sandsmark committed R529:07835f46ba0a: units: work around kunitconversion not being very good with uppercase/lowercase (authored by sandsmark).
units: work around kunitconversion not being very good with uppercase/lowercase
Oct 8 2017, 12:37 PM
sandsmark committed R529:b52be1d40944: qml: fix hiding of type when no item selected (authored by sandsmark).
qml: fix hiding of type when no item selected
Oct 8 2017, 12:37 PM
sandsmark committed R529:1c5d1d66a7e2: calculator: ugly hack to remove trailing zeroes (authored by sandsmark).
calculator: ugly hack to remove trailing zeroes
Oct 8 2017, 12:00 PM
sandsmark committed R529:9a4718c68a9a: calculator: improve output when tests fail (authored by sandsmark).
calculator: improve output when tests fail
Oct 8 2017, 12:00 PM
sandsmark committed R529:305d82ca22ed: calculator: use static const for list of functions (authored by sandsmark).
calculator: use static const for list of functions
Oct 8 2017, 12:00 PM
sandsmark committed R529:a1a3cb44c84f: calculator: fix ordering of operators (authored by sandsmark).
calculator: fix ordering of operators
Oct 8 2017, 12:00 PM

Oct 4 2017

sandsmark committed R529:70c6d396ec48: calculator: try to hide the fact that we don't do fixed precision (authored by sandsmark).
calculator: try to hide the fact that we don't do fixed precision
Oct 4 2017, 8:25 AM
sandsmark committed R529:cc96d7739376: calculator: fix formatting of numbers (authored by sandsmark).
calculator: fix formatting of numbers
Oct 4 2017, 8:13 AM
sandsmark committed R529:97f2df6d66ad: port away from kxmlgui (authored by sandsmark).
port away from kxmlgui
Oct 4 2017, 8:13 AM
sandsmark committed R529:af431d53bd7c: port away from kiowidgets (authored by sandsmark).
port away from kiowidgets
Oct 4 2017, 8:13 AM
sandsmark committed R529:b2f743ec1077: paths: port away from kio (authored by sandsmark).
paths: port away from kio
Oct 4 2017, 7:41 AM

Sep 25 2017

sandsmark committed R529:928961041084: fix fetching of shortcut for displaying notification (authored by sandsmark).
fix fetching of shortcut for displaying notification
Sep 25 2017, 8:30 AM

Sep 24 2017

sandsmark committed R529:07864c34cb13: make it wider and show more results if possible (authored by sandsmark).
make it wider and show more results if possible
Sep 24 2017, 2:42 PM
sandsmark committed R529:b4baabbfbdb0: add some shadow and blur cuz we can (authored by sandsmark).
add some shadow and blur cuz we can
Sep 24 2017, 2:42 PM