sandsmark (Martin Tobias Holmedahl Sandsmark)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2015, 5:16 PM (209 w, 5 d)
Availability
Available

Recent Activity

Sun, May 26

sandsmark committed R529:71dc968fb1a9: fix typo (authored by sandsmark).
fix typo
Sun, May 26, 10:24 AM
sandsmark committed R529:fbf7e9d7ff73: force async loading of icons (it can be slow on first load) (authored by sandsmark).
force async loading of icons (it can be slow on first load)
Sun, May 26, 10:24 AM
sandsmark committed R529:a27aea15d47c: fix parsing of calculations with units (authored by sandsmark).
fix parsing of calculations with units
Sun, May 26, 10:24 AM
sandsmark committed R529:24cb3b8c6e36: add megabyte etc. (authored by sandsmark).
add megabyte etc.
Sun, May 26, 10:24 AM
sandsmark committed R529:1f96f46c72e6: improve path matching (authored by sandsmark).
improve path matching
Sun, May 26, 10:24 AM

May 12 2019

sandsmark committed R529:41da69489b42: improve sorting when the query has been used before (authored by sandsmark).
improve sorting when the query has been used before
May 12 2019, 10:23 AM
sandsmark committed R529:fa69a37ca7de: fix storing statistics in qsettings (it doesn't like /) (authored by sandsmark).
fix storing statistics in qsettings (it doesn't like /)
May 12 2019, 10:20 AM
sandsmark committed R529:1321e0213a66: fix compile warnings about shifting negative numbers (authored by sandsmark).
fix compile warnings about shifting negative numbers
May 12 2019, 9:20 AM
sandsmark committed R529:f42c5952c6bc: simplify the provider comparison function a bit (authored by sandsmark).
simplify the provider comparison function a bit
May 12 2019, 9:20 AM
sandsmark committed R529:75d4593497c7: fix crash during sorting (I think, too lazy to think), because we sort it… (authored by sandsmark).
fix crash during sorting (I think, too lazy to think), because we sort it…
May 12 2019, 9:20 AM

Mar 8 2019

sandsmark added a comment to D17744: New search result look, resurrected.
In D17744#423497, @mglb wrote:

@ngraham wrong review :)

@sandsmark I would like to modify colors/blending for it in the future (keeping all remaining code), so checkbox would be ok for now. Do we accept config options like "Use new $FEATURE (experimental)"? This would make it easier to remove the option when colors will work with everything.

Mar 8 2019, 12:08 PM · Konsole

Mar 4 2019

sandsmark committed R529:527cffeab49d: try to fix not disappearing when losing focus sometimes (authored by sandsmark).
try to fix not disappearing when losing focus sometimes
Mar 4 2019, 9:30 AM
sandsmark committed R529:660c12ce6a54: shell provider: watch the directories for added/removed executables (authored by sandsmark).
shell provider: watch the directories for added/removed executables
Mar 4 2019, 9:30 AM

Mar 2 2019

sandsmark added a comment to D17744: New search result look, resurrected.

How about just a checkbox to turn on/off the new "fancy" search look for now? I've tested with all the color schemes I have available, and I believe we handle it OK, but I could have missed some.

Mar 2 2019, 8:04 PM · Konsole
sandsmark updated the diff for D18871: Move selection code from TerminalDisplay to ScreenWindow.

updated so it applies cleanly

Mar 2 2019, 7:58 PM · Konsole
sandsmark updated the diff for D18870: Clean up/refactor selection code in TerminalDisplay.

Updated so it applies cleanly.

Mar 2 2019, 7:58 PM · Konsole
sandsmark added inline comments to D17742: Clean up content rect in TerminalDisplay.
Mar 2 2019, 7:54 PM · Konsole
sandsmark added a comment to D11188: Fix use after free in RadialMap::Widget::invalidate().

FWIW, looking at the code briefly, I think this patch does the right thing if we end up in that bad "something went wrong"-state. But there's probably a second bug somewhere that leads us to that state, so a bit hard to reproduce, I guess.

Mar 2 2019, 7:43 PM
sandsmark added a comment to D17732: Respect animation settings.

As for the discussion above, I don't see how plasma-integration is relevant. It does control QStyleHints, but you're not using any of that.
Everything you use here comes from the QStyle which is all from Breeze.

Mar 2 2019, 7:40 PM · Gwenview
sandsmark added a comment to D19482: Fix-ish scrollbar background with Qt Fusion style.

Removing the changing the lightness of the buttonColor makes it a bit more visible, imho:

Mar 2 2019, 7:17 PM · Konsole
sandsmark requested review of D19482: Fix-ish scrollbar background with Qt Fusion style.
Mar 2 2019, 7:09 PM · Konsole

Mar 1 2019

sandsmark committed R529:30020ecacf5a: improve result sorting (authored by sandsmark).
improve result sorting
Mar 1 2019, 8:03 AM

Feb 18 2019

sandsmark committed R529:13cbde53c473: try to fix occasional crash when sorting results (authored by sandsmark).
try to fix occasional crash when sorting results
Feb 18 2019, 6:18 PM

Feb 9 2019

sandsmark added a dependent revision for D18870: Clean up/refactor selection code in TerminalDisplay: D18871: Move selection code from TerminalDisplay to ScreenWindow.
Feb 9 2019, 12:46 PM · Konsole
sandsmark added a dependency for D18871: Move selection code from TerminalDisplay to ScreenWindow: D18870: Clean up/refactor selection code in TerminalDisplay.
Feb 9 2019, 12:46 PM · Konsole
sandsmark requested review of D18871: Move selection code from TerminalDisplay to ScreenWindow.
Feb 9 2019, 12:46 PM · Konsole
sandsmark requested review of D18870: Clean up/refactor selection code in TerminalDisplay.
Feb 9 2019, 12:43 PM · Konsole
sandsmark accepted D18780: Don't include <fstab.h> anymore.
Feb 9 2019, 12:26 PM
sandsmark committed R319:02acee1474e2: move selection code to screenwindow (authored by sandsmark).
move selection code to screenwindow
Feb 9 2019, 12:41 AM
sandsmark committed R319:279cd0e7d4a6: start moving selection code out of terminaldisplay (authored by sandsmark).
start moving selection code out of terminaldisplay
Feb 9 2019, 12:41 AM

Feb 8 2019

sandsmark committed R319:dbe9675bbd8b: fix selection at the bottom (authored by sandsmark).
fix selection at the bottom
Feb 8 2019, 10:39 PM
sandsmark committed R319:ab5ca452fe79: more cleanup (authored by sandsmark).
more cleanup
Feb 8 2019, 10:39 PM
sandsmark committed R319:db49d46d25cd: try to clean up initial selection a bit (authored by sandsmark).
try to clean up initial selection a bit
Feb 8 2019, 10:39 PM
sandsmark committed R319:f6f55f672766: blarfgh (authored by sandsmark).
blarfgh
Feb 8 2019, 10:39 PM
sandsmark committed R319:4435714eb5d3: more cleanup (authored by sandsmark).
more cleanup
Feb 8 2019, 10:39 PM
sandsmark committed R319:e57cfa8d22bb: fix crash (authored by sandsmark).
fix crash
Feb 8 2019, 10:39 PM
sandsmark committed R319:ba0ac228a3da: wip? (authored by sandsmark).
wip?
Feb 8 2019, 10:39 PM
sandsmark committed R319:c75b4b12742c: fix crash when selecting at the uppermost line (authored by sandsmark).
fix crash when selecting at the uppermost line
Feb 8 2019, 10:39 PM
sandsmark committed R319:083705c7ecb0: terminaldisplay: correctly set whether we want edge selection (authored by sandsmark).
terminaldisplay: correctly set whether we want edge selection
Feb 8 2019, 10:39 PM
sandsmark committed R319:6b1a051447b9: clean up findwordstart (authored by sandsmark).
clean up findwordstart
Feb 8 2019, 10:39 PM
sandsmark committed R319:75efbba77cf7: clean up findwordend (authored by sandsmark).
clean up findwordend
Feb 8 2019, 10:39 PM
sandsmark added a comment to D18606: [WIP]Close tab on middle mouse button event.

What about hidding the tab, showing kmessagewidget "Tab xxx closed. undo" + timeout, and really closing the tab after the timeout? Works well on web/mobiles.

Feb 8 2019, 9:05 PM · Konsole
sandsmark requested review of D18862: Fix crash when extending selection.
Feb 8 2019, 7:47 PM · Konsole
sandsmark added a comment to D18735: Improve built-in line/block characters drawing.

thanks for doing this, been dreading doing something like it myself. :-)

Feb 8 2019, 6:03 PM · Konsole
sandsmark added a comment to D18520: Remove dead code in TerminalDisplay.

I've been wanting to refactor it to remove all the individual getters and setters in TerminalDisplay, and just let TerminalDisplay hold the Profile::Ptr, then terminaldisplay can just directly use the values from Profile instead of duplicating all the variables and getters/setters.

Feb 8 2019, 5:46 PM · Konsole
sandsmark requested review of D18858: Some trivial cleanup of the TerminalDisplay::hotSpotRegion() function.
Feb 8 2019, 5:40 PM · Konsole
sandsmark updated the diff for D17742: Clean up content rect in TerminalDisplay.

Removed the unrelated cleanup/moving of the code in hotSpotRegion()

Feb 8 2019, 5:36 PM · Konsole
sandsmark added a comment to D16138: Create the default profile if it doesn't exist.

I consistently lose any settings I make the first time I run konsole (ie, no .config/konsolerc and no files in .local/share/konsole/). I confirmed this with other users.

Feb 8 2019, 5:28 PM · Konsole
sandsmark accepted D15295: [konsole]: proper fix for a crash-on-exit.

The issues are just cosmetic, didn't intend to block this.

Feb 8 2019, 5:18 PM · Konsole
sandsmark added a comment to D18606: [WIP]Close tab on middle mouse button event.

There is already a confirmation dialog when you close a tab with a running process, so unless we cleverly account for that, this would result in two dialogs.

Feb 8 2019, 4:49 PM · Konsole
sandsmark added a comment to D18606: [WIP]Close tab on middle mouse button event.

How about a normal confirmation dialog (with the normal "don't ask again")?

Feb 8 2019, 4:44 PM · Konsole

Jan 28 2019

sandsmark committed R529:a4d4915e0e00: don't deref pointers when sorting (authored by sandsmark).
don't deref pointers when sorting
Jan 28 2019, 11:33 AM

Jan 21 2019

sandsmark committed R319:674261169fc3: fix crash when selecting at the uppermost line (authored by sandsmark).
fix crash when selecting at the uppermost line
Jan 21 2019, 8:38 PM
sandsmark committed R319:a533259498a2: clean up findwordend (authored by sandsmark).
clean up findwordend
Jan 21 2019, 8:38 PM
sandsmark committed R319:43c4516c0293: terminaldisplay: correctly set whether we want edge selection (authored by sandsmark).
terminaldisplay: correctly set whether we want edge selection
Jan 21 2019, 8:38 PM
sandsmark committed R319:38af1ce71917: clean up findwordstart (authored by sandsmark).
clean up findwordstart
Jan 21 2019, 8:38 PM
sandsmark added a comment to D17744: New search result look, resurrected.

This looks rather bad on some of my color schemes. How do we handle where this looks bad w/ color schemes?

Jan 21 2019, 8:16 PM · Konsole

Dec 31 2018

sandsmark added a comment to D17732: Respect animation settings.

I'm afraid not, sorry. But @cfeck or another Frameworks or KDE Applications person may know.

Dec 31 2018, 4:09 PM · Gwenview
sandsmark updated subscribers of D17732: Respect animation settings.
Dec 31 2018, 3:53 PM · Gwenview
sandsmark updated the diff for D17744: New search result look, resurrected.

Apply patches from mglb, except the color one. Doesn't work well with my color scheme (way too low contrast), we can potentially fix that in a later patch.

Dec 31 2018, 3:52 PM · Konsole

Dec 25 2018

sandsmark abandoned D17740: Fix crash in extendSelection.

closing this, then

Dec 25 2018, 1:29 PM · Konsole
sandsmark added a comment to D17732: Respect animation settings.

However, I'm seeing that this appears to always disable all animations for me, no matter what value the animation speed is set up in the Breeze style settings:

Dec 25 2018, 12:49 PM · Gwenview
sandsmark added a comment to D17744: New search result look, resurrected.

Totally awesome! While you're at it, how about adding ticks to the scrollbar where there are search results? This would fix https://bugs.kde.org/show_bug.cgi?id=302284.

Dec 25 2018, 12:39 PM · Konsole
sandsmark added a comment to D17744: New search result look, resurrected.
In D17744#381034, @mglb wrote:
    • Invoke search, type text: all nice, I see current search line and remaining search results
    • Close search
    • Invoke search again: There is no current line (this is OK) and no dim (not OK) - search results are barely visible (without transparency they are not visible at all)
Dec 25 2018, 12:38 PM · Konsole
sandsmark updated the diff for D17744: New search result look, resurrected.

fix the issues

Dec 25 2018, 12:35 PM · Konsole

Dec 22 2018

sandsmark accepted D17629: Add method to BackgroundChecker to add word to session.
Dec 22 2018, 11:00 PM · Frameworks
sandsmark updated the test plan for D17744: New search result look, resurrected.
Dec 22 2018, 10:57 PM · Konsole
sandsmark requested review of D17744: New search result look, resurrected.
Dec 22 2018, 10:53 PM · Konsole
sandsmark requested review of D17742: Clean up content rect in TerminalDisplay.
Dec 22 2018, 8:12 PM · Konsole
sandsmark requested review of D17740: Fix crash in extendSelection.
Dec 22 2018, 6:34 PM · Konsole
sandsmark added a comment to D17588: MainWindow: Add Frameless option.

I think it looks good, just some trivial comments so I can show that I actually read the code.

Dec 22 2018, 5:43 PM · Konsole
sandsmark added a comment to D15834: port away from deprecated ffmpeg APIs.

I'm not too familiar with phabricator, so if someone else wants to go ahead and merge it feel free, otherwise I'll just push it normally.

Dec 22 2018, 5:33 PM
sandsmark updated the diff for D6083: Bump max thumbnail size to 512px.

Make sure we avoid the disk cache if we use thumbnails larger than the XDG spec allows.

Dec 22 2018, 5:31 PM · Gwenview
sandsmark added a comment to D6083: Bump max thumbnail size to 512px.

Seems like gnome just went with their own private folder ($XDG_CACHE_HOME/gnome-photos/thumbnails/$SIZE-$GENERATION), though not only because of the size issue:

Dec 22 2018, 5:27 PM · Gwenview
sandsmark updated the diff for D17732: Respect animation settings.

Fixed the issue with the fullscreenbar.

Dec 22 2018, 4:42 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

A good idea. However I found a regression: in full screen view, the top bar now never disappears; it's always visible. It needs to on;y appear when the mouse approached the top edge of the screen.

Dec 22 2018, 4:39 PM · Gwenview
sandsmark committed R260:97c5e50ba41b: propagate the visual hash with the thumbnail (authored by sandsmark).
propagate the visual hash with the thumbnail
Dec 22 2018, 2:00 PM
sandsmark committed R260:ef332347b12e: start on model (authored by sandsmark).
start on model
Dec 22 2018, 2:00 PM
sandsmark committed R260:5ed3624dce83: hash (authored by sandsmark).
hash
Dec 22 2018, 2:00 PM
sandsmark committed R260:e53e6c0c1956: respect animation settings (authored by sandsmark).
respect animation settings
Dec 22 2018, 2:00 PM
sandsmark requested review of D17732: Respect animation settings.
Dec 22 2018, 11:14 AM · Gwenview

Dec 20 2018

sandsmark committed R529:ce4d5efea0f0: normalize priority (authored by sandsmark).
normalize priority
Dec 20 2018, 10:56 AM
sandsmark committed R529:8356d49f73a5: settings is synced when qsettings is destroyed (authored by sandsmark).
settings is synced when qsettings is destroyed
Dec 20 2018, 10:49 AM

Dec 13 2018

sandsmark updated subscribers of D17266: Use DECSCUSR 0 to reset to default.
Dec 13 2018, 10:51 AM · Konsole
sandsmark updated subscribers of D17293: Add warning when pasting unprintable chars and ask to filter them out.
Dec 13 2018, 10:51 AM · Konsole

Dec 7 2018

sandsmark added a comment to D17414: fix cursor when anti aliasing is enabled.

i. e. there is a _margin of 1 pixel, but some of the antialiasing "blur" leaks to 0,0. so it is fixed with a full update() (e. g. when it regains focus), but not when just some content updates in the window.

Dec 7 2018, 8:13 PM · Konsole
sandsmark requested review of D17414: fix cursor when anti aliasing is enabled.
Dec 7 2018, 8:11 PM · Konsole
sandsmark updated the diff for D17294: Add special support for block characters.

Fixed the bound, added some comments

Dec 7 2018, 5:44 PM · Konsole

Dec 4 2018

sandsmark committed R494:27f53f7fbd69: port to qregularexpression (authored by sandsmark).
port to qregularexpression
Dec 4 2018, 6:43 PM
sandsmark committed R494:f79bb13cfab2: port limitedcharlineedit to qregularexpression (authored by sandsmark).
port limitedcharlineedit to qregularexpression
Dec 4 2018, 6:43 PM
sandsmark committed R494:8c2eb7b8b74b: remove unused class (authored by sandsmark).
remove unused class
Dec 4 2018, 6:43 PM
sandsmark committed R494:f59162987afa: drop unnecessary dependency on kwidgetaddons (authored by sandsmark).
drop unnecessary dependency on kwidgetaddons
Dec 4 2018, 6:43 PM
sandsmark committed R494:ce02030b799d: avoid roundtrip into khelpclient when we already know the URLs we want to get… (authored by sandsmark).
avoid roundtrip into khelpclient when we already know the URLs we want to get…
Dec 4 2018, 6:43 PM
sandsmark committed R494:96567b03efe1: make the ktextwidgets dependency optional (authored by sandsmark).
make the ktextwidgets dependency optional
Dec 4 2018, 6:43 PM
sandsmark committed R494:e07a207ee190: some cleanup (authored by sandsmark).
some cleanup
Dec 4 2018, 6:43 PM
sandsmark committed R494:e4808c9de915: remove unnecessary dependencies (authored by sandsmark).
remove unnecessary dependencies
Dec 4 2018, 6:43 PM
sandsmark updated the diff for D16947: fix drawing box chars, avoid storing and saving state all the time.

fix format for phabricator

Dec 4 2018, 4:02 PM · Konsole
sandsmark updated the diff for D17264: Fix crash when changing from blinking cursor to block cursor.

fix format for phabricator

Dec 4 2018, 4:01 PM · Konsole
sandsmark updated the diff for D17266: Use DECSCUSR 0 to reset to default.

fix format of patch for phabricator

Dec 4 2018, 4:00 PM · Konsole
sandsmark updated the diff for D17293: Add warning when pasting unprintable chars and ask to filter them out.

fix patch format for phabricator

Dec 4 2018, 4:00 PM · Konsole