sandsmark (Martin Tobias Holmedahl Sandsmark)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2015, 5:16 PM (276 w, 4 d)
Availability
Available

Recent Activity

Jul 16 2020

sandsmark added a comment to T12140: Killing KInit With Fire.

And existing things like prelink won't help with e. g. fonts

I think an interesting piece of profiling would be whether any potential boost is actually from linking or whether it is from the extra kdeinit things like fonts. If it's mostly fonts maybe we can look into alternative solutions at a binary level.

Jul 16 2020, 3:13 PM · Frameworks, KF6
sandsmark added a comment to T12140: Killing KInit With Fire.

FWIW, kdeinit still provides a very noticeable improvement here as well.

Jul 16 2020, 2:32 PM · Frameworks, KF6

Jul 9 2020

ognarb awarded D28651: Load and use global animation settings a Party Time token.
Jul 9 2020, 4:19 PM · Plasma, Breeze
sandsmark added a comment to D28651: Load and use global animation settings.

Should I move this to invent, or just push it?

Jul 9 2020, 12:00 PM · Plasma, Breeze

Jun 20 2020

sandsmark committed R319:f6e5e20508ab: Merge branch 'martin/unbreak-multi-instance' into 'master' (authored by sandsmark).
Merge branch 'martin/unbreak-multi-instance' into 'master'
Jun 20 2020, 10:53 AM

Jun 19 2020

sandsmark committed R319:acdb527d0779: Merge branch 'martin/newsearchlook' into 'master' (authored by sandsmark).
Merge branch 'martin/newsearchlook' into 'master'
Jun 19 2020, 10:51 PM

Jun 18 2020

sandsmark committed R319:f1f900c597c5: Merge branch 'martin/newsearchlook' into 'master' (authored by sandsmark).
Merge branch 'martin/newsearchlook' into 'master'
Jun 18 2020, 10:15 PM
sandsmark committed R319:368843d85b72: Merge branch 'martin/newsearchlook' into 'master' (authored by sandsmark).
Merge branch 'martin/newsearchlook' into 'master'
Jun 18 2020, 3:12 AM

Jun 15 2020

sandsmark committed R319:6d9be975e30f: Merge branch 'martin/newsearchlook' into 'master' (authored by sandsmark).
Merge branch 'martin/newsearchlook' into 'master'
Jun 15 2020, 10:14 PM
sandsmark committed R319:3bfb84cb88e6: Add support for turning off 'URL'-matching of email addresses (authored by sandsmark).
Add support for turning off 'URL'-matching of email addresses
Jun 15 2020, 3:52 AM
sandsmark committed R319:69dffd8e4580: fix deprecated qset warnings (authored by sandsmark).
fix deprecated qset warnings
Jun 15 2020, 3:52 AM
sandsmark committed R319:ad25fe2326fc: Add support for turning off 'URL'-matching of email addresses (authored by sandsmark).
Add support for turning off 'URL'-matching of email addresses
Jun 15 2020, 3:51 AM
sandsmark committed R319:95998ef04931: Merge branch 'martin/qset-qlist' into 'master' (authored by sandsmark).
Merge branch 'martin/qset-qlist' into 'master'
Jun 15 2020, 3:51 AM
sandsmark committed R319:1a82a01d2129: fix deprecated qset warnings (authored by sandsmark).
fix deprecated qset warnings
Jun 15 2020, 3:51 AM
sandsmark committed R319:7be45ec88849: Make the URL hints ignore email addresses (authored by sandsmark).
Make the URL hints ignore email addresses
Jun 15 2020, 3:49 AM
sandsmark committed R319:0f570dbc42eb: Disable the Scrim™ (thanks ngraham) if we don't have any results to highlight (authored by sandsmark).
Disable the Scrim™ (thanks ngraham) if we don't have any results to highlight
Jun 15 2020, 3:48 AM
sandsmark committed R319:46b80b5a4dbc: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Jun 15 2020, 3:48 AM
sandsmark committed R319:376c3a450e24: Fix matching for files within folders (authored by tcanabrava).
Fix matching for files within folders
Jun 15 2020, 3:48 AM
sandsmark committed R319:0380399b81e1: Take in consideration the Word Characters of the profile (authored by tcanabrava).
Take in consideration the Word Characters of the profile
Jun 15 2020, 3:48 AM
sandsmark committed R319:18266a240b9a: Disable the Scrim™ (thanks ngraham) if we don't have any results to highlight (authored by sandsmark).
Disable the Scrim™ (thanks ngraham) if we don't have any results to highlight
Jun 15 2020, 3:48 AM
sandsmark committed R319:5d55f916dc3c: Improve the display of search results (authored by sandsmark).
Improve the display of search results
Jun 15 2020, 3:48 AM
sandsmark committed R319:50c2a960d4e7: Make the URL hints ignore email addresses (authored by sandsmark).
Make the URL hints ignore email addresses
Jun 15 2020, 3:48 AM
sandsmark committed R319:8cd7b9651e18: Merge branch 'martin/unbreak-multi-instance' into 'master' (authored by sandsmark).
Merge branch 'martin/unbreak-multi-instance' into 'master'
Jun 15 2020, 3:47 AM
sandsmark committed R319:ac25ff8eb871: Revert "Correctly trigger a Konsole window when using single process" (authored by sandsmark).
Revert "Correctly trigger a Konsole window when using single process"
Jun 15 2020, 3:47 AM
sandsmark committed R319:f1495c74323c: add a very explicit warning after fixing this for the Nth time (authored by sandsmark).
add a very explicit warning after fixing this for the Nth time
Jun 15 2020, 3:47 AM
sandsmark added a reverting change for R319:59ff5d37301a: Correctly trigger a Konsole window when using single process: R319:ac25ff8eb871: Revert "Correctly trigger a Konsole window when using single process".
Jun 15 2020, 3:47 AM
sandsmark committed R319:6fda6059bf04: Improve the display of search results (authored by sandsmark).
Improve the display of search results
Jun 15 2020, 3:47 AM
sandsmark committed R319:74069f77dcb6: Merge branch 'martin/newsearchlook' into 'master' (authored by sandsmark).
Merge branch 'martin/newsearchlook' into 'master'
Jun 15 2020, 3:47 AM
sandsmark committed R319:77093eb82446: Improve the display of search results (authored by sandsmark).
Improve the display of search results
Jun 15 2020, 3:47 AM
sandsmark committed R319:180fdaf3004f: Improve the display of search results (authored by sandsmark).
Improve the display of search results
Jun 15 2020, 3:47 AM
sandsmark committed R319:275cb09a7304: better indication of non-current search result lines (authored by sandsmark).
better indication of non-current search result lines
Jun 15 2020, 3:47 AM
sandsmark committed R319:7c3c8bedafb7: Improve the display of search results (authored by sandsmark).
Improve the display of search results
Jun 15 2020, 3:47 AM
sandsmark committed R319:9e5e6f6ef3d6: Make the URL hints ignore email addresses (authored by sandsmark).
Make the URL hints ignore email addresses
Jun 15 2020, 3:47 AM
sandsmark committed R319:406d081d3102: Merge branch 'martin/urlmatchmode' into 'master' (authored by sandsmark).
Merge branch 'martin/urlmatchmode' into 'master'
Jun 15 2020, 3:47 AM

Jun 8 2020

sandsmark committed R819:8bcc29f9d70e: fix installing kmedia icons (authored by sandsmark).
fix installing kmedia icons
Jun 8 2020, 4:10 PM
sandsmark committed R819:587c367a6069: fix name of KMedia link (authored by sandsmark).
fix name of KMedia link
Jun 8 2020, 4:08 PM
sandsmark committed R817:170e6a768313: fix kiconedit (authored by sandsmark).
fix kiconedit
Jun 8 2020, 4:03 PM
sandsmark committed R817:0e98e4cae3f0: fix kfract (authored by sandsmark).
fix kfract
Jun 8 2020, 3:47 PM
sandsmark committed R817:f71c3a9209ed: fix kview build (authored by sandsmark).
fix kview build
Jun 8 2020, 3:42 PM
sandsmark committed R817:da2b85605c7f: fix install target of kdelnk (authored by sandsmark).
fix install target of kdelnk
Jun 8 2020, 3:42 PM
sandsmark committed R817:fda3fc9935ef: normalize kpaint's text tool icon loading (authored by sandsmark).
normalize kpaint's text tool icon loading
Jun 8 2020, 3:24 PM
sandsmark committed R817:9e1215965a98: copy in the large text icon from kdvi to kpaint (authored by sandsmark).
copy in the large text icon from kdvi to kpaint
Jun 8 2020, 3:20 PM
sandsmark committed R817:af8d7cbea1d3: fix install path of icons (authored by sandsmark).
fix install path of icons
Jun 8 2020, 3:18 PM
sandsmark committed R817:60a29167b398: skip installing icons already installed by kdelibs (authored by sandsmark).
skip installing icons already installed by kdelibs
Jun 8 2020, 3:16 PM
sandsmark added a reverting change for R817:472c060462fe: remove unnecessary configure_file(): R817:f93865d3dc3f: Revert "remove unnecessary configure_file()".
Jun 8 2020, 3:13 PM
sandsmark committed R817:f93865d3dc3f: Revert "remove unnecessary configure_file()" (authored by sandsmark).
Revert "remove unnecessary configure_file()"
Jun 8 2020, 3:13 PM
sandsmark committed R817:472c060462fe: remove unnecessary configure_file() (authored by sandsmark).
remove unnecessary configure_file()
Jun 8 2020, 3:12 PM
sandsmark committed R817:36d22c58ad27: fix build of kpaint (authored by sandsmark).
fix build of kpaint
Jun 8 2020, 3:11 PM
sandsmark committed R822:0d9f27de2335: fix kedit (authored by sandsmark).
fix kedit
Jun 8 2020, 2:52 PM
sandsmark committed R815:fac090378bd6: avoid some stack smashing/crashing of the kioslaves (authored by sandsmark).
avoid some stack smashing/crashing of the kioslaves
Jun 8 2020, 2:25 PM
sandsmark committed R815:e60b2773ee29: the color spec stuff doesn't really work with compositing, hopefully people… (authored by sandsmark).
the color spec stuff doesn't really work with compositing, hopefully people…
Jun 8 2020, 2:17 PM
sandsmark committed R818:df00990b8d54: fix running of kmail (authored by sandsmark).
fix running of kmail
Jun 8 2020, 2:01 PM
sandsmark committed R822:7f0cb0750b70: update name of non-conflicting kfmclient (authored by sandsmark).
update name of non-conflicting kfmclient
Jun 8 2020, 1:45 PM
sandsmark committed R822:991ff6908e37: enable khexdit (authored by sandsmark).
enable khexdit
Jun 8 2020, 1:45 PM
sandsmark committed R820:157d50dd1adf: fix conflict with kdelibs (authored by sandsmark).
fix conflict with kdelibs
Jun 8 2020, 1:39 PM
sandsmark committed R820:279cf82aa6a2: fix kmail build (authored by sandsmark).
fix kmail build
Jun 8 2020, 1:37 PM
sandsmark committed R815:48e55c74aa9d: update with name of non-conflicting kcheckpass (authored by sandsmark).
update with name of non-conflicting kcheckpass
Jun 8 2020, 1:17 PM
sandsmark committed R815:87c60e7d2cc1: update kdelnk for kmenuedit with non-conflicting name (authored by sandsmark).
update kdelnk for kmenuedit with non-conflicting name
Jun 8 2020, 1:17 PM
sandsmark committed R820:06acbee5f471: update name of non-conflicting kfmclient (authored by sandsmark).
update name of non-conflicting kfmclient
Jun 8 2020, 1:11 PM
sandsmark committed R818:7285a3acf83e: fix name of non-conflicting kfmclient (authored by sandsmark).
fix name of non-conflicting kfmclient
Jun 8 2020, 1:06 PM
sandsmark committed R815:c9b3a80bd332: fix kdelnk for non-colliding name of konsole (authored by sandsmark).
fix kdelnk for non-colliding name of konsole
Jun 8 2020, 1:04 PM
sandsmark committed R815:afbe5eb54810: try to avoid conflict with kfmclient in modern konqueror (authored by sandsmark).
try to avoid conflict with kfmclient in modern konqueror
Jun 8 2020, 1:04 PM
sandsmark committed R815:ce2b360cf05e: avoid some more conflicts with modern versions of applications (authored by sandsmark).
avoid some more conflicts with modern versions of applications
Jun 8 2020, 12:55 PM
sandsmark committed R818:ea8e207d3d3c: avoid conflicts with docs in modern KDE (authored by sandsmark).
avoid conflicts with docs in modern KDE
Jun 8 2020, 12:51 PM
sandsmark committed R818:e921f3cc42b3: avoid conflicts with translations in modern KDE (authored by sandsmark).
avoid conflicts with translations in modern KDE
Jun 8 2020, 12:50 PM

Jun 7 2020

sandsmark added a comment to D27034: Fix message box when passing a remote url that includes a file.

This is wrong, isn't it? The logic was: if setDirectory is passed something that _isn't_ a directory, try to strip the filename.

Jun 7 2020, 5:36 PM · Plasma

Jun 2 2020

sandsmark committed R819:a246d049c13f: fix build of kmedia (authored by sandsmark).
fix build of kmedia
Jun 2 2020, 11:53 PM
sandsmark committed R816:c4b13e658a84: fix paths (authored by sandsmark).
fix paths
Jun 2 2020, 11:39 PM
sandsmark committed R820:2cae390428ed: fix build with system qt (authored by sandsmark).
fix build with system qt
Jun 2 2020, 11:33 PM
sandsmark committed R822:cc60f0d65da5: fix building against system version of qt (authored by sandsmark).
fix building against system version of qt
Jun 2 2020, 11:28 PM
sandsmark committed R816:aea908d9298f: fix build with system qt (authored by sandsmark).
fix build with system qt
Jun 2 2020, 11:25 PM
sandsmark committed R815:757f1fb59058: Remember to update the references to the target (authored by sandsmark).
Remember to update the references to the target
Jun 2 2020, 11:19 PM
sandsmark committed R815:7417d266b469: avoid naming conflict for konsole (authored by sandsmark).
avoid naming conflict for konsole
Jun 2 2020, 11:18 PM
sandsmark committed R815:7a4bcbed268e: fix build with system qt (authored by sandsmark).
fix build with system qt
Jun 2 2020, 11:16 PM
sandsmark committed R821:2fdce629a6ba: fix build with system qt1 (authored by sandsmark).
fix build with system qt1
Jun 2 2020, 11:00 PM
sandsmark committed R818:d60a93a11539: Now I finally got rid of opt (authored by sandsmark).
Now I finally got rid of opt
Jun 2 2020, 10:58 PM
sandsmark committed R818:70f1daa25d9a: don't hardcode install paths (authored by sandsmark).
don't hardcode install paths
Jun 2 2020, 10:28 PM
sandsmark committed R818:592a008b43d3: fix building with system qt (authored by sandsmark).
fix building with system qt
Jun 2 2020, 9:42 PM
sandsmark committed R823:dc8a8d6431f4: fix build (authored by sandsmark).
fix build
Jun 2 2020, 9:16 PM

May 30 2020

sandsmark closed D17744: New search result look, resurrected.
May 30 2020, 4:11 PM · Konsole
sandsmark added a comment to D17744: New search result look, resurrected.

Moved it to invent: https://invent.kde.org/utilities/konsole/-/merge_requests/105

May 30 2020, 4:11 PM · Konsole
sandsmark requested changes to D29004: Close main window after displaying the information about invalid URL.

If filelight is launched with a path I'm fairly certain it's quicker for the user to just correct the path rather than navigating the open dialog, so go ahead. (I'm almost tempted to just print a warning on the command line).

May 30 2020, 2:44 PM

May 23 2020

sandsmark committed R111:fa0675414785: remove unnecessary dependency (authored by sandsmark).
remove unnecessary dependency
May 23 2020, 8:17 PM

May 22 2020

sandsmark committed R352:1a9fe765923f: don't rescan everything when deleting in a subdirectory and going up again (authored by sandsmark).
don't rescan everything when deleting in a subdirectory and going up again
May 22 2020, 11:59 AM
sandsmark committed R352:b36e2e85d734: Fix memory leaks all over the place (I was dumb when porting to QList) (authored by sandsmark).
Fix memory leaks all over the place (I was dumb when porting to QList)
May 22 2020, 11:39 AM
sandsmark committed R352:187c322d2943: fix invalid cast (authored by sandsmark).
fix invalid cast
May 22 2020, 11:39 AM

May 20 2020

sandsmark added inline comments to D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files..
May 20 2020, 8:22 AM · Plasma
sandsmark added inline comments to D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files..
May 20 2020, 8:18 AM · Plasma
sandsmark added a comment to D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files..

It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now.

May 20 2020, 8:10 AM · Plasma

May 10 2020

sandsmark committed R287:8562ce18f1ab: Add some sanity and bounds checking (authored by sandsmark).
Add some sanity and bounds checking
May 10 2020, 4:08 PM
sandsmark closed D24367: Some sanity verification.
May 10 2020, 4:08 PM · Frameworks
sandsmark added inline comments to D28982: Use Qt instead of a full glib event loop just for pulseaudio.
May 10 2020, 4:03 PM
sandsmark updated the diff for D28982: Use Qt instead of a full glib event loop just for pulseaudio.

Replaced it with a pointer, but as explained in the reply to the comment about deleting and recreating I don't think it makes sense to delete and recreate the fake "mainloop"/event loop since it only wraps the Qt event loop (and can't delete and recreate the Qt event loop obviously).

May 10 2020, 4:03 PM

Apr 22 2020

sandsmark committed R529:e73ffc3829d9: a bit less spammy (authored by sandsmark).
a bit less spammy
Apr 22 2020, 9:35 AM
sandsmark committed R529:54316b98ab59: fix build (authored by sandsmark).
fix build
Apr 22 2020, 9:35 AM
sandsmark committed R529:28b1bf937a81: a bit better matching (authored by sandsmark).
a bit better matching
Apr 22 2020, 9:35 AM
sandsmark committed R529:ccb6197ae74b: bit faster collating results, warn about slow providers (authored by sandsmark).
bit faster collating results, warn about slow providers
Apr 22 2020, 9:35 AM
sandsmark committed R529:60f354dd6103: massive speed improvement for applications provider (authored by sandsmark).
massive speed improvement for applications provider
Apr 22 2020, 9:35 AM
sandsmark committed R529:594ff7ca85d7: massive speedup of paths provider (authored by sandsmark).
massive speedup of paths provider
Apr 22 2020, 9:35 AM
sandsmark committed R529:7bf0faf03098: ensure initialization when starting (authored by sandsmark).
ensure initialization when starting
Apr 22 2020, 9:35 AM