- User Since
- Jun 9 2015, 5:16 PM (209 w, 5 d)
Sun, May 26
May 12 2019
Mar 8 2019
Mar 4 2019
Mar 2 2019
How about just a checkbox to turn on/off the new "fancy" search look for now? I've tested with all the color schemes I have available, and I believe we handle it OK, but I could have missed some.
updated so it applies cleanly
Updated so it applies cleanly.
FWIW, looking at the code briefly, I think this patch does the right thing if we end up in that bad "something went wrong"-state. But there's probably a second bug somewhere that leads us to that state, so a bit hard to reproduce, I guess.
Removing the changing the lightness of the buttonColor makes it a bit more visible, imho:
Mar 1 2019
Feb 18 2019
Feb 9 2019
Feb 8 2019
What about hidding the tab, showing kmessagewidget "Tab xxx closed. undo" + timeout, and really closing the tab after the timeout? Works well on web/mobiles.
thanks for doing this, been dreading doing something like it myself. :-)
I've been wanting to refactor it to remove all the individual getters and setters in TerminalDisplay, and just let TerminalDisplay hold the Profile::Ptr, then terminaldisplay can just directly use the values from Profile instead of duplicating all the variables and getters/setters.
Removed the unrelated cleanup/moving of the code in hotSpotRegion()
I consistently lose any settings I make the first time I run konsole (ie, no .config/konsolerc and no files in .local/share/konsole/). I confirmed this with other users.
The issues are just cosmetic, didn't intend to block this.
There is already a confirmation dialog when you close a tab with a running process, so unless we cleverly account for that, this would result in two dialogs.
How about a normal confirmation dialog (with the normal "don't ask again")?
Jan 28 2019
Jan 21 2019
Dec 31 2018
Apply patches from mglb, except the color one. Doesn't work well with my color scheme (way too low contrast), we can potentially fix that in a later patch.
Dec 25 2018
closing this, then
fix the issues
Dec 22 2018
I think it looks good, just some trivial comments so I can show that I actually read the code.
I'm not too familiar with phabricator, so if someone else wants to go ahead and merge it feel free, otherwise I'll just push it normally.
Make sure we avoid the disk cache if we use thumbnails larger than the XDG spec allows.
Seems like gnome just went with their own private folder ($XDG_CACHE_HOME/gnome-photos/thumbnails/$SIZE-$GENERATION), though not only because of the size issue:
Fixed the issue with the fullscreenbar.
Dec 20 2018
Dec 13 2018
Dec 7 2018
i. e. there is a _margin of 1 pixel, but some of the antialiasing "blur" leaks to 0,0. so it is fixed with a full update() (e. g. when it regains focus), but not when just some content updates in the window.
Fixed the bound, added some comments
Dec 4 2018
fix format for phabricator
fix format for phabricator
fix format of patch for phabricator
fix patch format for phabricator