vmatare (Victor Mataré)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2020, 5:37 PM (26 w, 3 d)
Availability
Available

Recent Activity

Aug 7 2020

vmatare added a comment to D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

whats the common sense of using different names for the same product? MariaDB is the same as MySql, just different names; core and everything else stays the same.

Aug 7 2020, 11:19 PM · Amarok

Mar 25 2020

vmatare added a comment to D28165: Fix compatibility with modern MySQL.

I assume you don't have commit access and you'll need somebody to push this patch for you, right?

Yes, please go ahead if you think this has been tested well enough.

Mar 25 2020, 6:17 PM · Amarok
vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

Another attempt at a simple solution that works with all versions of MariaDB and MySQL. This one comes with the added cost of including the full mysql.h because that seems to be the only consistently supplied drop-in header by MariaDB. Other solutions would involve additional CMake hackery to distinguish between MariaDB and MySQL, but for the sake of sanity, let's sacrifice compilation time for simplicity here.

Mar 25 2020, 2:49 AM · Amarok
vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

indent with 4 spaces in cmake

Mar 25 2020, 2:19 AM · Amarok

Mar 24 2020

vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

The whole thing as one combined patch

Mar 24 2020, 12:34 AM · Amarok
vmatare added a comment to D28165: Fix compatibility with modern MySQL.

I know, the question was whether that supersedes or amends the previous diff. But seems like it's the former. I'll update, sorry.

Mar 24 2020, 12:31 AM · Amarok
vmatare added a comment to D28165: Fix compatibility with modern MySQL.

This breaks compilation here on openSUSE with MariaDB:

Mar 24 2020, 12:26 AM · Amarok
vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

storage: distinguish MariaDB and MySQL for API quirks

Mar 24 2020, 12:17 AM · Amarok

Mar 20 2020

vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

storage: Fix for MySQL 8.0 onward

Mar 20 2020, 5:42 PM · Amarok
vmatare requested review of D28165: Fix compatibility with modern MySQL.
Mar 20 2020, 5:40 PM · Amarok