vmatare (Victor Mataré)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Fri, Mar 20, 5:37 PM (1 w, 2 d)
Availability
Available

Recent Activity

Wed, Mar 25

vmatare added a comment to D28165: Fix compatibility with modern MySQL.

I assume you don't have commit access and you'll need somebody to push this patch for you, right?

Yes, please go ahead if you think this has been tested well enough.

Wed, Mar 25, 6:17 PM · Amarok
vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

Another attempt at a simple solution that works with all versions of MariaDB and MySQL. This one comes with the added cost of including the full mysql.h because that seems to be the only consistently supplied drop-in header by MariaDB. Other solutions would involve additional CMake hackery to distinguish between MariaDB and MySQL, but for the sake of sanity, let's sacrifice compilation time for simplicity here.

Wed, Mar 25, 2:49 AM · Amarok
vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

indent with 4 spaces in cmake

Wed, Mar 25, 2:19 AM · Amarok

Tue, Mar 24

vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

The whole thing as one combined patch

Tue, Mar 24, 12:34 AM · Amarok
vmatare added a comment to D28165: Fix compatibility with modern MySQL.

I know, the question was whether that supersedes or amends the previous diff. But seems like it's the former. I'll update, sorry.

Tue, Mar 24, 12:31 AM · Amarok
vmatare added a comment to D28165: Fix compatibility with modern MySQL.

This breaks compilation here on openSUSE with MariaDB:

Tue, Mar 24, 12:26 AM · Amarok
vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

storage: distinguish MariaDB and MySQL for API quirks

Tue, Mar 24, 12:17 AM · Amarok

Fri, Mar 20

vmatare updated the diff for D28165: Fix compatibility with modern MySQL.

storage: Fix for MySQL 8.0 onward

Fri, Mar 20, 5:42 PM · Amarok
vmatare requested review of D28165: Fix compatibility with modern MySQL.
Fri, Mar 20, 5:40 PM · Amarok