Shouldn't KFileCustomDialog be used instead?

IIRC KConfigGroup::readEntry() reads the translated version of the key, and every kf5_entry.desktop` has such translations. QSettings does not do that.

Or maybe switch this module to use pkg-config as primary way to detect taglib, falling back to taglib-config only when the pkg-config file is not available.

There are various issues here:

• we are touching even branches that are dead or in maintenance mode, which means an high risk of issues
• the same 4 lines of patterns is repeated over and over
• the way to get the directory of a script is overly verbose, using realpath is way easier/faster...

Nice start.

Duplicate of D25638: autotests: Find perl executable on all platforms.

In D25484#566482, @ndavis wrote:

In D25484#566477, @pino wrote:

Do people frequently misclick with the middle mouse button?

It can happen, and more often with a touchpad.

I hadn't considered that. By default, you have to tap with 3 fingers to middle click. What are you doing with the touchpad when this happens? [...]

Do people frequently misclick with the middle mouse button?

Please make it configurable, and off by default (otherwise it is too easy to mis-click and close a document).

In R1045:426d362cf6b0b1226392d0606780f637349db852#3841420, @aspotashev wrote:

Behaviour did not change, however I think the former version was more bulletproof.

Import kup translations (all but 'tl')

... and enable extraction.
tl (Tagalog) has not been imported for now
because we don't have any other translation for it.

In T4803#208465, @pino wrote:

In T4803#208462, @aspotashev wrote:

1. Import the 5 branches (*/l10n-kf5*/scripts and */l10n-kde4/scripts) to Git as subling directories:
   • branches_stable_l10n-kde4

Ugh no, please import them as branches, as they actually are.

As a counter-argument to this statement, I'm going to explain why */l10n-kf5*/ and */l10n-kde4/ are not real branches. Even though the various scripts/ directories are stored under branches/stable/ and trunk/ in SVN, they are not used as branches anymore.

In T4803#208462, @aspotashev wrote:

1. Import the 5 branches (*/l10n-kf5*/scripts and */l10n-kde4/scripts) to Git as subling directories:
   • branches_stable_l10n-kde4
   • branches_stable_l10n-kf5
   • branches_stable_l10n-kf5-plasma-lts
   • trunk_l10n-kde4
   • trunk_l10n-kf5

Mostly OK from my POV, just please remove the unrelated changes to the patch (i.e. the brackets additions in two places).
I have no idea what "Boy Scout rule" is supposed to mean, however adding unrelated changes makes history reading harder, especially when wanting to check why certain changes were done. Again, material for a different patch than this.

In D25095#557349, @heikobecker wrote:

Not sure if that makes it worth to depend on KWindowSystem, or if it's maybe better to copy the header over.

IMHO:

• moving includes like this is more an hack than a real solution, as future changes in other Qt includes may cause this issue again -- see also the comment right before the phonon include...
• the real solution is to #include <fixx11h.h> right after the X11 includes -- see the KWindowSystem framework

In D24476#543298, @ngraham wrote:

In D24476#543297, @broulik wrote:

Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount.

Don't you already have the free space information in the status bar though?

! In T11721#201558, @romangg wrote:
If not via newlines could it be possible to make it work by combining strings with +? Like:

i18n("Lorem ipsum dolor sit amet, consectetur adipisici elit, " +
     "sed eiusmod tempor incidunt ut labore et dolore magna aliqua.")

Not sure why this doesn't work at the moment. Is it because of this xgettext tool?

Also, please write why a Comment was added, especially that the referenced bug does not explain that either.

I do not think this solution is correct. The project ID is set by the user, so translating it with i18n() will simply not work.

BTW, since the "100 characters per line" was brought as single argument, let's actually check what the KDE Frameworks Coding Style actually say.
Quoting bits from https://techbase.kde.org/Policies/Frameworks_Coding_Style (emphases mine):

@aspotashev: please read the discussion in this review request...

In D23815#528543, @dfaure wrote:

If we want to enable this flag (to "punish" the first KDE developer who upgrades Qt, like me currently), then at least we should only do so in git checkouts, not in release tarballs.
This is easy to do: if (EXISTS "${CMAKE_SOURCE_DIR}/.git").