Differential D26273

cmake: don't use taglib-config if we are cross compiling
AcceptedPublic
Actions

Authored by bshah on Dec 29 2019, 10:31 AM.

Details

Reviewers
vkrause
Summary

If we are cross compiling two things are possible,

  • cmake finds host taglib-config
  • cmake finds target taglib-config in sysroot

depending on toolchain configuration. In both cases taglib-config values
are useless since, we can't link to host libraries or can't run target
taglib-config in most cases.

Test Plan

tested it finds the taglib from sysroot when cross compiling

Diff Detail

Repository
R286 KFileMetaData
Branch
bshah/cross
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20362
Build 20380: arc lint + arc unit
bshah created this revision.Dec 29 2019, 10:31 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 29 2019, 10:31 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
bshah requested review of this revision.Dec 29 2019, 10:31 AM
vkrause accepted this revision.Dec 29 2019, 12:53 PM

Longer term we probably either want to convince upstream to install cmake config files, or at least have this in ECM, a quick local grep find a handful of copies of this.

This revision is now accepted and ready to land.Dec 29 2019, 12:53 PM
pino added a subscriber: pino.Dec 29 2019, 1:07 PM

Or maybe switch this module to use pkg-config as primary way to detect taglib, falling back to taglib-config only when the pkg-config file is not available.

elvisangelaccio added a subscriber: elvisangelaccio.Dec 29 2019, 4:01 PM
In D26273#584234, @vkrause wrote:

Longer term we probably either want to convince upstream to install cmake config files, or at least have this in ECM, a quick local grep find a handful of copies of this.

There was an attempt with D21695 but it got stuck.

Revision Contents
Changeset List

PathPackages
Mcmake/FindTaglib.cmake (2 lines)

Diff 72323

View Options

cmake/FindTaglib.cmake

Loading...