Differential D26410

Port KLanguageButton from KConfig to QSettings
AbandonedPublic
Actions

Authored by nicolasfella on Jan 4 2020, 2:07 AM.

Details

Reviewers
davidedmundson
aacid
Group Reviewers
Frameworks
Maniphest Tasks
T12197: Move KLanguageButton from KConfig -> QSettings
Summary

Implement T12197

Test Plan

Still see proper language name in Dolpin's switch language dialog

Diff Detail

Repository
R265 KConfigWidgets
Branch
klb
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20600
Build 20618: arc lint + arc unit
nicolasfella created this revision.Jan 4 2020, 2:07 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 4 2020, 2:07 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jan 4 2020, 2:07 AM
davidedmundson accepted this revision.Jan 4 2020, 8:53 AM
This revision is now accepted and ready to land.Jan 4 2020, 8:53 AM
pino added a subscriber: pino.Jan 4 2020, 12:18 PM

IIRC KConfigGroup::readEntry() reads the translated version of the key, and every kf5_entry.desktop` has such translations. QSettings does not do that.

Did you test only in an English setup?

nicolasfella added a comment.Jan 4 2020, 4:32 PM
In D26410#587473, @pino wrote:

IIRC KConfigGroup::readEntry() reads the translated version of the key, and every kf5_entry.desktop` has such translations. QSettings does not do that.

Did you test only in an English setup?

Indeed, now the language names are only in english

aacid requested changes to this revision.Jan 4 2020, 5:59 PM
This revision now requires changes to proceed.Jan 4 2020, 5:59 PM
nicolasfella abandoned this revision.Jan 4 2020, 6:01 PM

Revision Contents
Changeset List

PathPackages
Msrc/klanguagebutton.cpp (11 lines)

Diff 72724

View Options

src/klanguagebutton.cpp

Loading...