autotests: Find perl executable on all platforms
ClosedPublic

Authored by aspotashev on Sat, Nov 30, 7:09 PM.

Details

Summary

Attempt to fix unit tests on FreeBSD.

Test Plan

Unit tests are able to run Perl script on Linux. (Would be better to test this on all platforms, but I can't do that easily.)

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aspotashev created this revision.Sat, Nov 30, 7:09 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSat, Nov 30, 7:09 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
aspotashev requested review of this revision.Sat, Nov 30, 7:09 PM
aspotashev added a project: Frameworks.
aspotashev added a subscriber: Frameworks.
apol added a subscriber: apol.Sat, Nov 30, 7:51 PM
apol added inline comments.
autotests/CMakeLists.txt
93

maybe it would make sense to check for BSD instead?
I don't know much about BSD, but I'd expect the shebang to work there as well.

aspotashev added inline comments.Sun, Dec 1, 9:30 AM
autotests/CMakeLists.txt
93

I think it's better to minimize platform-specific if-endifs and make CMake code clean rather than micro-optimize per platform.

dfaure accepted this revision.Sun, Dec 1, 12:14 PM
dfaure added a subscriber: dfaure.

I approve, given that I wrote the same in D25643 :-)

This revision is now accepted and ready to land.Sun, Dec 1, 12:14 PM
This revision was automatically updated to reflect the committed changes.